[PATCH] D26694: [analyzer] Drop explicit mention of range constraint solver

2016-12-01 Thread Dominic Chen via Phabricator via cfe-commits 
This revision was automatically updated to reflect the committed changes.
Closed by commit rL288372: [analyzer] Drop explicit mention of range constraint 
solver (authored by ddcc).

Changed prior to commit:
  https://reviews.llvm.org/D26694?vs=78060=79924#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D26694

Files:
  cfe/trunk/test/Analysis/CFDateGC.m
  cfe/trunk/test/Analysis/CFNumber.c
  cfe/trunk/test/Analysis/CFRetainRelease_NSAssertionHandler.m
  cfe/trunk/test/Analysis/CGColorSpace.c
  cfe/trunk/test/Analysis/CheckNSError.m
  cfe/trunk/test/Analysis/NSPanel.m
  cfe/trunk/test/Analysis/NSString.m
  cfe/trunk/test/Analysis/NSWindow.m
  cfe/trunk/test/Analysis/ObjCProperties.m
  cfe/trunk/test/Analysis/PR2599.m
  cfe/trunk/test/Analysis/PR3991.m
  cfe/trunk/test/Analysis/additive-folding-range-constraints.c
  cfe/trunk/test/Analysis/additive-folding.cpp
  cfe/trunk/test/Analysis/array-struct-region.c
  cfe/trunk/test/Analysis/array-struct.c
  cfe/trunk/test/Analysis/cfref_PR2519.c
  cfe/trunk/test/Analysis/cfref_rdar6080742.c
  cfe/trunk/test/Analysis/comparison-implicit-casts.cpp
  cfe/trunk/test/Analysis/complex.c
  cfe/trunk/test/Analysis/dead-stores.c
  cfe/trunk/test/Analysis/dead-stores.cpp
  cfe/trunk/test/Analysis/misc-ps-64.m
  cfe/trunk/test/Analysis/misc-ps-eager-assume.m
  cfe/trunk/test/Analysis/misc-ps-ranges.m
  cfe/trunk/test/Analysis/misc-ps.m
  
cfe/trunk/test/Analysis/nil-receiver-undefined-larger-than-voidptr-ret-region.m
  cfe/trunk/test/Analysis/nil-receiver-undefined-larger-than-voidptr-ret.m
  cfe/trunk/test/Analysis/null-deref-ps.c
  cfe/trunk/test/Analysis/rdar-6562655.m
  cfe/trunk/test/Analysis/rdar-6600344-nil-receiver-undefined-struct-ret.m
  cfe/trunk/test/Analysis/reference.cpp
  cfe/trunk/test/Analysis/unions-region.m

Index: cfe/trunk/test/Analysis/CheckNSError.m
===
--- cfe/trunk/test/Analysis/CheckNSError.m
+++ cfe/trunk/test/Analysis/CheckNSError.m
@@ -1,4 +1,4 @@
-// RUN: %clang_cc1 -analyze -analyzer-checker=core,osx.cocoa.NSError,osx.coreFoundation.CFError -analyzer-store=region -analyzer-constraints=range -verify -Wno-objc-root-class %s
+// RUN: %clang_cc1 -analyze -analyzer-checker=core,osx.cocoa.NSError,osx.coreFoundation.CFError -analyzer-store=region -verify -Wno-objc-root-class %s
 
 
 typedef signed char BOOL;
Index: cfe/trunk/test/Analysis/rdar-6600344-nil-receiver-undefined-struct-ret.m
===
--- cfe/trunk/test/Analysis/rdar-6600344-nil-receiver-undefined-struct-ret.m
+++ cfe/trunk/test/Analysis/rdar-6600344-nil-receiver-undefined-struct-ret.m
@@ -1,4 +1,4 @@
-// RUN: %clang_cc1 -analyze -analyzer-checker=core,alpha.core -analyzer-constraints=range -analyzer-store=region -verify -Wno-objc-root-class %s
+// RUN: %clang_cc1 -analyze -analyzer-checker=core,alpha.core -analyzer-store=region -verify -Wno-objc-root-class %s
 // expected-no-diagnostics
 
 typedef struct Foo { int x; } Bar;
Index: cfe/trunk/test/Analysis/misc-ps-ranges.m
===
--- cfe/trunk/test/Analysis/misc-ps-ranges.m
+++ cfe/trunk/test/Analysis/misc-ps-ranges.m
@@ -1,4 +1,4 @@
-// RUN: %clang_cc1 -analyze -analyzer-checker=core,alpha.core -analyzer-store=region -analyzer-constraints=range -verify -fblocks %s
+// RUN: %clang_cc1 -analyze -analyzer-checker=core,alpha.core -analyzer-store=region -verify -fblocks %s
 
 // 
 // main's 'argc' argument is always > 0
Index: cfe/trunk/test/Analysis/comparison-implicit-casts.cpp
===
--- cfe/trunk/test/Analysis/comparison-implicit-casts.cpp
+++ cfe/trunk/test/Analysis/comparison-implicit-casts.cpp
@@ -1,5 +1,5 @@
-// RUN: %clang_cc1 -analyze -analyzer-checker=core,unix.cstring,debug.ExprInspection -analyzer-constraints=range -triple i386-apple-darwin9 -verify %s
-// RUN: %clang_cc1 -analyze -analyzer-checker=core,unix.cstring,debug.ExprInspection -analyzer-constraints=range -triple x86_64-apple-darwin9 -verify %s
+// RUN: %clang_cc1 -analyze -analyzer-checker=core,unix.cstring,debug.ExprInspection -triple i386-apple-darwin9 -verify %s
+// RUN: %clang_cc1 -analyze -analyzer-checker=core,unix.cstring,debug.ExprInspection -triple x86_64-apple-darwin9 -verify %s
 
 // This file runs in C++ mode so that the comparison type is 'bool', not 'int'.
 void clang_analyzer_eval(int);
Index: cfe/trunk/test/Analysis/PR2599.m
===
--- cfe/trunk/test/Analysis/PR2599.m
+++ cfe/trunk/test/Analysis/PR2599.m
@@ -1,4 +1,4 @@
-// RUN: %clang_cc1 -triple %itanium_abi_triple -analyze -analyzer-checker=core,osx.cocoa.RetainCount,alpha.core -analyzer-constraints=range -analyzer-store=region -fobjc-gc -verify %s
+// RUN: %clang_cc1 -triple %itanium_abi_triple -analyze -analyzer-checker=core,osx.cocoa.RetainCount,alpha.core -analyzer-store=region -fobjc-gc -verify

[PATCH] D26694: [analyzer] Drop explicit mention of range constraint solver

2016-11-30 Thread Artem Dergachev via Phabricator via cfe-commits 
NoQ added a comment.

Approve! And probably `-analyzer-store=region` is worth dropping as well 
eventually.


https://reviews.llvm.org/D26694



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26694: [analyzer] Drop explicit mention of range constraint solver

2016-11-30 Thread Anna Zaks via Phabricator via cfe-commits 
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.

Awesome!!! Thanks for the cleanup!


https://reviews.llvm.org/D26694



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26694: [analyzer] Drop explicit mention of range constraint solver

2016-11-15 Thread Dominic Chen via cfe-commits 
ddcc created this revision.
ddcc added reviewers: zaks.anna, dcoughlin.
ddcc added a subscriber: cfe-commits.

The basic constraint solver was dropped in https://reviews.llvm.org/rL162384, 
leaving the range constraint solver as the default and only constraint solver. 
Explicitly specifying it is unnecessary, and makes it difficult to test with 
other solver backends.


https://reviews.llvm.org/D26694

Files:
  test/Analysis/CFDateGC.m
  test/Analysis/CFNumber.c
  test/Analysis/CFRetainRelease_NSAssertionHandler.m
  test/Analysis/CGColorSpace.c
  test/Analysis/CheckNSError.m
  test/Analysis/NSPanel.m
  test/Analysis/NSString.m
  test/Analysis/NSWindow.m
  test/Analysis/ObjCProperties.m
  test/Analysis/PR2599.m
  test/Analysis/PR3991.m
  test/Analysis/additive-folding-range-constraints.c
  test/Analysis/additive-folding.cpp
  test/Analysis/array-struct-region.c
  test/Analysis/array-struct.c
  test/Analysis/cfref_PR2519.c
  test/Analysis/cfref_rdar6080742.c
  test/Analysis/comparison-implicit-casts.cpp
  test/Analysis/complex.c
  test/Analysis/dead-stores.c
  test/Analysis/dead-stores.cpp
  test/Analysis/misc-ps-64.m
  test/Analysis/misc-ps-eager-assume.m
  test/Analysis/misc-ps-ranges.m
  test/Analysis/misc-ps.m
  test/Analysis/nil-receiver-undefined-larger-than-voidptr-ret-region.m
  test/Analysis/nil-receiver-undefined-larger-than-voidptr-ret.m
  test/Analysis/null-deref-ps.c
  test/Analysis/rdar-6562655.m
  test/Analysis/rdar-6600344-nil-receiver-undefined-struct-ret.m
  test/Analysis/reference.cpp
  test/Analysis/unions-region.m

Index: test/Analysis/unions-region.m
===
--- test/Analysis/unions-region.m
+++ test/Analysis/unions-region.m
@@ -1,4 +1,4 @@
-// RUN: %clang_cc1 -analyze -analyzer-checker=core -analyzer-store=region -analyzer-constraints=range %s -verify
+// RUN: %clang_cc1 -analyze -analyzer-checker=core -analyzer-store=region %s -verify
 // expected-no-diagnostics
 
 //===-- unions-region.m ---===//
Index: test/Analysis/reference.cpp
===
--- test/Analysis/reference.cpp
+++ test/Analysis/reference.cpp
@@ -1,4 +1,4 @@
-// RUN: %clang_cc1 -analyze -analyzer-checker=core,alpha.core,debug.ExprInspection -analyzer-store=region -analyzer-constraints=range -verify -Wno-null-dereference -Wno-tautological-undefined-compare %s
+// RUN: %clang_cc1 -analyze -analyzer-checker=core,alpha.core,debug.ExprInspection -analyzer-store=region -verify -Wno-null-dereference -Wno-tautological-undefined-compare %s
 
 void clang_analyzer_eval(bool);
 
Index: test/Analysis/rdar-6600344-nil-receiver-undefined-struct-ret.m
===
--- test/Analysis/rdar-6600344-nil-receiver-undefined-struct-ret.m
+++ test/Analysis/rdar-6600344-nil-receiver-undefined-struct-ret.m
@@ -1,4 +1,4 @@
-// RUN: %clang_cc1 -analyze -analyzer-checker=core,alpha.core -analyzer-constraints=range -analyzer-store=region -verify -Wno-objc-root-class %s
+// RUN: %clang_cc1 -analyze -analyzer-checker=core,alpha.core -analyzer-store=region -verify -Wno-objc-root-class %s
 // expected-no-diagnostics
 
 typedef struct Foo { int x; } Bar;
Index: test/Analysis/rdar-6562655.m
===
--- test/Analysis/rdar-6562655.m
+++ test/Analysis/rdar-6562655.m
@@ -1,4 +1,4 @@
-// RUN: %clang_cc1 -analyze -analyzer-checker=core,osx.cocoa.RetainCount,alpha.core -analyzer-constraints=range -analyzer-store=region -verify %s
+// RUN: %clang_cc1 -analyze -analyzer-checker=core,osx.cocoa.RetainCount,alpha.core -analyzer-store=region -verify %s
 // expected-no-diagnostics
 //
 // This test case mainly checks that the retain/release checker doesn't crash
Index: test/Analysis/null-deref-ps.c
===
--- test/Analysis/null-deref-ps.c
+++ test/Analysis/null-deref-ps.c
@@ -1,5 +1,5 @@
-// RUN: %clang_cc1 -triple i386-apple-darwin10 -analyze -analyzer-checker=core,deadcode,alpha.core -std=gnu99 -analyzer-store=region -analyzer-constraints=range -analyzer-purge=none -verify %s -Wno-error=return-type
-// RUN: %clang_cc1 -triple i386-apple-darwin10 -analyze -analyzer-checker=core,deadcode,alpha.core -std=gnu99 -analyzer-store=region -analyzer-constraints=range -verify %s -Wno-error=return-type 
+// RUN: %clang_cc1 -triple i386-apple-darwin10 -analyze -analyzer-checker=core,deadcode,alpha.core -std=gnu99 -analyzer-store=region -analyzer-purge=none -verify %s -Wno-error=return-type
+// RUN: %clang_cc1 -triple i386-apple-darwin10 -analyze -analyzer-checker=core,deadcode,alpha.core -std=gnu99 -analyzer-store=region -verify %s -Wno-error=return-type 
 
 typedef unsigned uintptr_t;
 
Index: test/Analysis/nil-receiver-undefined-larger-than-voidptr-ret.m
===
---