[PATCH] D28790: [Modules] Correct test comment from obsolete earlier version of code. NFC
This revision was automatically updated to reflect the committed changes. Closed by commit rL292435: [Modules] Correct test comment from obsolete earlier version of code. NFC (authored by graydon). Changed prior to commit: https://reviews.llvm.org/D28790?vs=84616=84879#toc Repository: rL LLVM https://reviews.llvm.org/D28790 Files: cfe/trunk/test/Modules/implicit-private-with-different-name.m Index: cfe/trunk/test/Modules/implicit-private-with-different-name.m === --- cfe/trunk/test/Modules/implicit-private-with-different-name.m +++ cfe/trunk/test/Modules/implicit-private-with-different-name.m @@ -3,7 +3,7 @@ // Build PCH using A, with adjacent private module APrivate, which winds up being implicitly referenced // RUN: %clang_cc1 -verify -fmodules -fimplicit-module-maps -fmodules-cache-path=%t -F %S/Inputs/implicit-private-with-different-name -emit-pch -o %t-A.pch %s -// Use the PCH with no explicit way to resolve PrivateA, still pick it up through MODULE_DIRECTORY reference in PCH control block +// Use the PCH with no explicit way to resolve APrivate, still pick it up by automatic second-chance search for "A" with "Private" appended // RUN: %clang_cc1 -verify -fmodules -fimplicit-module-maps -fmodules-cache-path=%t -F %S/Inputs/implicit-private-with-different-name -include-pch %t-A.pch %s -fsyntax-only // Check the fixit Index: cfe/trunk/test/Modules/implicit-private-with-different-name.m === --- cfe/trunk/test/Modules/implicit-private-with-different-name.m +++ cfe/trunk/test/Modules/implicit-private-with-different-name.m @@ -3,7 +3,7 @@ // Build PCH using A, with adjacent private module APrivate, which winds up being implicitly referenced // RUN: %clang_cc1 -verify -fmodules -fimplicit-module-maps -fmodules-cache-path=%t -F %S/Inputs/implicit-private-with-different-name -emit-pch -o %t-A.pch %s -// Use the PCH with no explicit way to resolve PrivateA, still pick it up through MODULE_DIRECTORY reference in PCH control block +// Use the PCH with no explicit way to resolve APrivate, still pick it up by automatic second-chance search for "A" with "Private" appended // RUN: %clang_cc1 -verify -fmodules -fimplicit-module-maps -fmodules-cache-path=%t -F %S/Inputs/implicit-private-with-different-name -include-pch %t-A.pch %s -fsyntax-only // Check the fixit ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D28790: [Modules] Correct test comment from obsolete earlier version of code. NFC
manmanren accepted this revision. manmanren added a comment. This revision is now accepted and ready to land. LGTM Manman https://reviews.llvm.org/D28790 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D28790: [Modules] Correct test comment from obsolete earlier version of code. NFC
graydon created this revision. Code committed in https://reviews.llvm.org/rL290219 went through a few iterations; test wound up with stale comment. https://reviews.llvm.org/D28790 Files: test/Modules/implicit-private-with-different-name.m Index: test/Modules/implicit-private-with-different-name.m === --- test/Modules/implicit-private-with-different-name.m +++ test/Modules/implicit-private-with-different-name.m @@ -3,7 +3,7 @@ // Build PCH using A, with adjacent private module APrivate, which winds up being implicitly referenced // RUN: %clang_cc1 -verify -fmodules -fimplicit-module-maps -fmodules-cache-path=%t -F %S/Inputs/implicit-private-with-different-name -emit-pch -o %t-A.pch %s -// Use the PCH with no explicit way to resolve PrivateA, still pick it up through MODULE_DIRECTORY reference in PCH control block +// Use the PCH with no explicit way to resolve APrivate, still pick it up by automatic second-chance search for "A" with "Private" appended // RUN: %clang_cc1 -verify -fmodules -fimplicit-module-maps -fmodules-cache-path=%t -F %S/Inputs/implicit-private-with-different-name -include-pch %t-A.pch %s -fsyntax-only // Check the fixit Index: test/Modules/implicit-private-with-different-name.m === --- test/Modules/implicit-private-with-different-name.m +++ test/Modules/implicit-private-with-different-name.m @@ -3,7 +3,7 @@ // Build PCH using A, with adjacent private module APrivate, which winds up being implicitly referenced // RUN: %clang_cc1 -verify -fmodules -fimplicit-module-maps -fmodules-cache-path=%t -F %S/Inputs/implicit-private-with-different-name -emit-pch -o %t-A.pch %s -// Use the PCH with no explicit way to resolve PrivateA, still pick it up through MODULE_DIRECTORY reference in PCH control block +// Use the PCH with no explicit way to resolve APrivate, still pick it up by automatic second-chance search for "A" with "Private" appended // RUN: %clang_cc1 -verify -fmodules -fimplicit-module-maps -fmodules-cache-path=%t -F %S/Inputs/implicit-private-with-different-name -include-pch %t-A.pch %s -fsyntax-only // Check the fixit ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
