[PATCH] D33955: [libcxx] [test] Remove a Clang/C2 workaround.

[Casey Carter via Phabricator via cfe-commits]

CaseyCarter accepted this revision.
CaseyCarter added a comment.
This revision is now accepted and ready to land.

As the party who originally put this workaround in place, I'll happily certify 
that it never affected any platforms that anyone but we Microsofters care 
about. I'll take responsibility for any buildbot fallout - forward any nasty 
notices to me.


https://reviews.llvm.org/D33955



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33955: [libcxx] [test] Remove a Clang/C2 workaround.

[Stephan T. Lavavej via Phabricator via cfe-commits]

STL_MSFT created this revision.

[libcxx] [test] Remove a Clang/C2 workaround.

Clang/LLVM doesn't need this workaround.


https://reviews.llvm.org/D33955

Files:
  test/std/utilities/optional/optional.object/optional.object.mod/reset.pass.cpp


Index: 
test/std/utilities/optional/optional.object/optional.object.mod/reset.pass.cpp
===
--- 
test/std/utilities/optional/optional.object/optional.object.mod/reset.pass.cpp
+++ 
test/std/utilities/optional/optional.object/optional.object.mod/reset.pass.cpp
@@ -48,14 +48,12 @@
 assert(X::dtor_called == false);
 assert(static_cast(opt) == false);
 }
-assert(X::dtor_called == false); // TRANSITION, Clang/C2 VSO#239997
 {
 optional opt(X{});
 X::dtor_called = false;
 opt.reset();
 assert(X::dtor_called == true);
 assert(static_cast(opt) == false);
 X::dtor_called = false;
 }
-assert(X::dtor_called == false); // TRANSITION, Clang/C2 VSO#239997
 }


Index: test/std/utilities/optional/optional.object/optional.object.mod/reset.pass.cpp
===
--- test/std/utilities/optional/optional.object/optional.object.mod/reset.pass.cpp
+++ test/std/utilities/optional/optional.object/optional.object.mod/reset.pass.cpp
@@ -48,14 +48,12 @@
 assert(X::dtor_called == false);
 assert(static_cast(opt) == false);
 }
-assert(X::dtor_called == false); // TRANSITION, Clang/C2 VSO#239997
 {
 optional opt(X{});
 X::dtor_called = false;
 opt.reset();
 assert(X::dtor_called == true);
 assert(static_cast(opt) == false);
 X::dtor_called = false;
 }
-assert(X::dtor_called == false); // TRANSITION, Clang/C2 VSO#239997
 }
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits