[PATCH] D34489: [scan-build-py] Patch to fix "-analyzer-config" option

[Petr Hosek via Phabricator via cfe-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL308401: [scan-build-py] Patch to fix "-analyzer-config" 
option (authored by phosek).

Changed prior to commit:
  https://reviews.llvm.org/D34489?vs=103490=107214#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D34489

Files:
  cfe/trunk/tools/scan-build-py/libscanbuild/analyze.py


Index: cfe/trunk/tools/scan-build-py/libscanbuild/analyze.py
===
--- cfe/trunk/tools/scan-build-py/libscanbuild/analyze.py
+++ cfe/trunk/tools/scan-build-py/libscanbuild/analyze.py
@@ -249,7 +249,7 @@
 if args.output_format:
 result.append('-analyzer-output={0}'.format(args.output_format))
 if args.analyzer_config:
-result.append(args.analyzer_config)
+result.extend(['-analyzer-config', args.analyzer_config])
 if args.verbose >= 4:
 result.append('-analyzer-display-progress')
 if args.plugins:


Index: cfe/trunk/tools/scan-build-py/libscanbuild/analyze.py
===
--- cfe/trunk/tools/scan-build-py/libscanbuild/analyze.py
+++ cfe/trunk/tools/scan-build-py/libscanbuild/analyze.py
@@ -249,7 +249,7 @@
 if args.output_format:
 result.append('-analyzer-output={0}'.format(args.output_format))
 if args.analyzer_config:
-result.append(args.analyzer_config)
+result.extend(['-analyzer-config', args.analyzer_config])
 if args.verbose >= 4:
 result.append('-analyzer-display-progress')
 if args.plugins:
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34489: [scan-build-py] Patch to fix "-analyzer-config" option

[Petr Hosek via Phabricator via cfe-commits]

phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.

LGTM


https://reviews.llvm.org/D34489



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34489: [scan-build-py] Patch to fix "-analyzer-config" option

[Haowei Wu via Phabricator via cfe-commits]

haowei created this revision.
Herald added a subscriber: whisperity.

I noticed that when I use "-analyze-config" option in scan-build-py, it behaves 
differently from original perl based scan-build.

For example, command:

$ scan-build -analyzer-config ipa=basic-inlining make

Will work without any issues on perl version of scan-build. But on 
scan-build-py it will throw an error message "error reading 
'ipa=basic-inlining'". 
After debugging, it turns out that the scan-build-py does not put 
"-analyzer-config" flag in front of the analyzer config flags (in this case is 
the "ipa=basic-inlining") in the final clang command line. This patch fixes 
this issue.


https://reviews.llvm.org/D34489

Files:
  tools/scan-build-py/libscanbuild/analyze.py


Index: tools/scan-build-py/libscanbuild/analyze.py
===
--- tools/scan-build-py/libscanbuild/analyze.py
+++ tools/scan-build-py/libscanbuild/analyze.py
@@ -249,7 +249,7 @@
 if args.output_format:
 result.append('-analyzer-output={0}'.format(args.output_format))
 if args.analyzer_config:
-result.append(args.analyzer_config)
+result.extend(['-analyzer-config', args.analyzer_config])
 if args.verbose >= 4:
 result.append('-analyzer-display-progress')
 if args.plugins:


Index: tools/scan-build-py/libscanbuild/analyze.py
===
--- tools/scan-build-py/libscanbuild/analyze.py
+++ tools/scan-build-py/libscanbuild/analyze.py
@@ -249,7 +249,7 @@
 if args.output_format:
 result.append('-analyzer-output={0}'.format(args.output_format))
 if args.analyzer_config:
-result.append(args.analyzer_config)
+result.extend(['-analyzer-config', args.analyzer_config])
 if args.verbose >= 4:
 result.append('-analyzer-display-progress')
 if args.plugins:
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits