[PATCH] D34536: [libcxx] [test] Fix Clang -Wunused-local-typedef warnings.

2017-07-05 Thread Stephan T. Lavavej via Phabricator via cfe-commits
STL_MSFT added a comment.

Yeah, I just wanted to check that you didn't mean to actually use these 
typedefs for something. Thanks!


https://reviews.llvm.org/D34536



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[PATCH] D34536: [libcxx] [test] Fix Clang -Wunused-local-typedef warnings.

2017-07-05 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.

LGTM. @STL_MSFT This seems like you could commit it without review. You're a 
professional STL developer after all, if you can't get this right may God have 
mercy on your users.


https://reviews.llvm.org/D34536



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[PATCH] D34536: [libcxx] [test] Fix Clang -Wunused-local-typedef warnings.

2017-07-05 Thread Stephan T. Lavavej via Phabricator via cfe-commits
STL_MSFT added a comment.

Ping?


https://reviews.llvm.org/D34536



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[PATCH] D34536: [libcxx] [test] Fix Clang -Wunused-local-typedef warnings.

2017-06-22 Thread Stephan T. Lavavej via Phabricator via cfe-commits
STL_MSFT created this revision.

[libcxx] [test] Fix Clang -Wunused-local-typedef warnings.


https://reviews.llvm.org/D34536

Files:
  test/std/numerics/complex.number/complex.transcendentals/acos.pass.cpp
  test/std/numerics/complex.number/complex.transcendentals/acosh.pass.cpp
  test/std/numerics/complex.number/complex.transcendentals/asin.pass.cpp
  test/std/numerics/complex.number/complex.transcendentals/asinh.pass.cpp
  test/std/numerics/complex.number/complex.transcendentals/atanh.pass.cpp
  test/std/numerics/complex.number/complex.transcendentals/cos.pass.cpp
  test/std/numerics/complex.number/complex.transcendentals/cosh.pass.cpp
  test/std/numerics/complex.number/complex.transcendentals/sin.pass.cpp
  test/std/numerics/complex.number/complex.transcendentals/sinh.pass.cpp
  test/std/numerics/complex.number/complex.transcendentals/tanh.pass.cpp
  
test/std/numerics/rand/rand.dis/rand.dist.norm/rand.dist.norm.lognormal/eval.pass.cpp
  test/std/numerics/rand/rand.dis/rand.dist.norm/rand.dist.norm.t/eval.pass.cpp
  
test/std/numerics/rand/rand.dis/rand.dist.pois/rand.dist.pois.extreme/eval.pass.cpp
  
test/std/numerics/rand/rand.dis/rand.dist.pois/rand.dist.pois.gamma/eval.pass.cpp
  
test/std/numerics/rand/rand.dis/rand.dist.samp/rand.dist.samp.plinear/eval.pass.cpp
  test/std/thread/thread.threads/thread.thread.this/sleep_until.pass.cpp

Index: test/std/thread/thread.threads/thread.thread.this/sleep_until.pass.cpp
===
--- test/std/thread/thread.threads/thread.thread.this/sleep_until.pass.cpp
+++ test/std/thread/thread.threads/thread.thread.this/sleep_until.pass.cpp
@@ -22,7 +22,6 @@
 {
 typedef std::chrono::system_clock Clock;
 typedef Clock::time_point time_point;
-typedef Clock::duration duration;
 std::chrono::milliseconds ms(500);
 time_point t0 = Clock::now();
 std::this_thread::sleep_until(t0 + ms);
Index: test/std/numerics/rand/rand.dis/rand.dist.samp/rand.dist.samp.plinear/eval.pass.cpp
===
--- test/std/numerics/rand/rand.dis/rand.dist.samp/rand.dist.samp.plinear/eval.pass.cpp
+++ test/std/numerics/rand/rand.dis/rand.dist.samp/rand.dist.samp.plinear/eval.pass.cpp
@@ -44,7 +44,6 @@
 test1()
 {
 typedef std::piecewise_linear_distribution<> D;
-typedef D::param_type P;
 typedef std::mt19937_64 G;
 G g;
 double b[] = {10, 14, 16, 17};
@@ -97,7 +96,6 @@
 test2()
 {
 typedef std::piecewise_linear_distribution<> D;
-typedef D::param_type P;
 typedef std::mt19937_64 G;
 G g;
 double b[] = {10, 14, 16, 17};
@@ -150,7 +148,6 @@
 test3()
 {
 typedef std::piecewise_linear_distribution<> D;
-typedef D::param_type P;
 typedef std::mt19937_64 G;
 G g;
 double b[] = {10, 14, 16, 17};
@@ -203,7 +200,6 @@
 test4()
 {
 typedef std::piecewise_linear_distribution<> D;
-typedef D::param_type P;
 typedef std::mt19937_64 G;
 G g;
 double b[] = {10, 14, 16};
@@ -257,7 +253,6 @@
 test5()
 {
 typedef std::piecewise_linear_distribution<> D;
-typedef D::param_type P;
 typedef std::mt19937_64 G;
 G g;
 double b[] = {10, 14};
@@ -312,7 +307,6 @@
 test6()
 {
 typedef std::piecewise_linear_distribution<> D;
-typedef D::param_type P;
 typedef std::mt19937_64 G;
 G g;
 double b[] = {10, 14, 16, 17};
Index: test/std/numerics/rand/rand.dis/rand.dist.pois/rand.dist.pois.gamma/eval.pass.cpp
===
--- test/std/numerics/rand/rand.dis/rand.dist.pois/rand.dist.pois.gamma/eval.pass.cpp
+++ test/std/numerics/rand/rand.dis/rand.dist.pois/rand.dist.pois.gamma/eval.pass.cpp
@@ -33,7 +33,6 @@
 {
 {
 typedef std::gamma_distribution<> D;
-typedef D::param_type P;
 typedef std::mt19937 G;
 G g;
 D d(0.5, 2);
@@ -73,7 +72,6 @@
 }
 {
 typedef std::gamma_distribution<> D;
-typedef D::param_type P;
 typedef std::mt19937 G;
 G g;
 D d(1, .5);
@@ -113,7 +111,6 @@
 }
 {
 typedef std::gamma_distribution<> D;
-typedef D::param_type P;
 typedef std::mt19937 G;
 G g;
 D d(2, 3);
Index: test/std/numerics/rand/rand.dis/rand.dist.pois/rand.dist.pois.extreme/eval.pass.cpp
===
--- test/std/numerics/rand/rand.dis/rand.dist.pois/rand.dist.pois.extreme/eval.pass.cpp
+++ test/std/numerics/rand/rand.dis/rand.dist.pois/rand.dist.pois.extreme/eval.pass.cpp
@@ -33,7 +33,6 @@
 test1()
 {
 typedef std::extreme_value_distribution<> D;
-typedef D::param_type P;
 typedef std::mt19937 G;
 G g;
 D d(0.5, 2);
@@ -75,7 +74,6 @@
 test2()
 {
 typedef std::extreme_value_distribution<> D;
-typedef D::param_type P;
 typedef std::mt19937 G;
 G g;
 D d(1, 2);
@@ -117,7 +115,6 @@
 test3()
 {
 typedef std::extrem