Re: [PATCH] D35215: [clangd] Fix Go to Definition not working in VSCode extension
Not really. It will get confused by a setup in which you open 2 files depending on each other with spaces in their names, for example: A A: #include "B B", because clangd will not recognize that the local B%20B is the same as B B. On Tue, Jul 11, 2017 at 7:35 PM, Marc-Andre Laperle via Phabricator < revi...@reviews.llvm.org> wrote: > malaperle added a comment. > > In the other review: "The tool is fine with spaces encoded as %20 by the > way." If that's true, wouldn't that mean the other review is the way to go? > > > Repository: > rL LLVM > > https://reviews.llvm.org/D35215 > > > > ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D35215: [clangd] Fix Go to Definition not working in VSCode extension
malaperle added a comment. In the other review: "The tool is fine with spaces encoded as %20 by the way." If that's true, wouldn't that mean the other review is the way to go? Repository: rL LLVM https://reviews.llvm.org/D35215 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D35215: [clangd] Fix Go to Definition not working in VSCode extension
krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Looks good! This is better than my https://reviews.llvm.org/D35238! Repository: rL LLVM https://reviews.llvm.org/D35215 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
