[PATCH] D36051: [clang-tidy] List the checkers with autofix

[Sylvestre Ledru via Phabricator via cfe-commits]

sylvestre.ledru updated this revision to Diff 234972.
sylvestre.ledru added a comment.

alias => aliases


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D36051/new/

https://reviews.llvm.org/D36051

Files:
  clang-tools-extra/docs/clang-tidy/checks/list.rst

Index: clang-tools-extra/docs/clang-tidy/checks/list.rst
===
--- clang-tools-extra/docs/clang-tidy/checks/list.rst
+++ clang-tools-extra/docs/clang-tidy/checks/list.rst
@@ -3,388 +3,408 @@
 Clang-Tidy Checks
 =
 
+.. Severities are coming from Codechecker:
+   https://github.com/Ericsson/codechecker/blob/master/config/checker_severity_map.json
+   If you change it here, please submit a PR on codechecker too
+
+.. csv-table::
+   :header: "Name", "Offers fixes", "Severity"
+   :widths: 50, 20, 10
+
+   `abseil-duration-addition `_, "Yes", ""
+   `abseil-duration-comparison `_, "Yes", ""
+   `abseil-duration-conversion-cast `_, "Yes", ""
+   `abseil-duration-division `_, "Yes", ""
+   `abseil-duration-factory-float `_, "Yes", ""
+   `abseil-duration-factory-scale `_, "Yes", ""
+   `abseil-duration-subtraction `_, "Yes", ""
+   `abseil-duration-unnecessary-conversion `_, "Yes", ""
+   `abseil-faster-strsplit-delimiter `_, "Yes", ""
+   `abseil-no-internal-dependencies `_, , ""
+   `abseil-no-namespace `_, , ""
+   `abseil-redundant-strcat-calls `_, "Yes", ""
+   `abseil-str-cat-append `_, "Yes", ""
+   `abseil-string-find-startswith `_, "Yes", "style"
+   `abseil-time-comparison `_, "Yes", ""
+   `abseil-time-subtraction `_, "Yes", ""
+   `abseil-upgrade-duration-conversions `_, "Yes", ""
+   `android-cloexec-accept `_, "Yes", ""
+   `android-cloexec-accept4 `_, , ""
+   `android-cloexec-creat `_, , "medium"
+   `android-cloexec-dup `_, , ""
+   `android-cloexec-epoll-create `_, , ""
+   `android-cloexec-epoll-create1 `_, , ""
+   `android-cloexec-fopen `_, , "medium"
+   `android-cloexec-inotify-init `_, , ""
+   `android-cloexec-inotify-init1 `_, , ""
+   `android-cloexec-memfd-create `_, , ""
+   `android-cloexec-open `_, , "medium"
+   `android-cloexec-pipe `_, , ""
+   `android-cloexec-pipe2 `_, , ""
+   `android-cloexec-socket `_, , "medium"
+   `android-comparison-in-temp-failure-retry `_, "Yes", ""
+   `boost-use-to-string `_, "Yes", "low"
+   `bugprone-argument-comment `_, "Yes", "low"
+   `bugprone-assert-side-effect `_, , "medium"
+   `bugprone-bad-signal-to-kill-thread `_, , ""
+   `bugprone-bool-pointer-implicit-conversion `_, "Yes", "low"
+   `bugprone-branch-clone `_, , "low"
+   `bugprone-copy-constructor-init `_, "Yes", "medium"
+   `bugprone-dangling-handle `_, , "high"
+   `bugprone-dynamic-static-initializers `_, , ""
+   `bugprone-exception-escape `_, , "medium"
+   `bugprone-fold-init-type `_, , "high"
+   `bugprone-forward-declaration-namespace `_, , "low"
+   `bugprone-forwarding-reference-overload `_, , "low"
+   `bugprone-inaccurate-erase `_, "Yes", "high"
+   `bugprone-incorrect-roundings `_, , "high"
+   `bugprone-infinite-loop `_, , "medium"
+   `bugprone-integer-division `_, , "medium"
+   `bugprone-lambda-function-name `_, , "low"
+   `bugprone-macro-parentheses `_, "Yes", "medium"
+   `bugprone-macro-repeated-side-effects `_, , "medium"
+   `bugprone-misplaced-operator-in-strlen-in-alloc `_, , "medium"
+   `bugprone-misplaced-widening-cast `_, "Yes", "high"
+   `bugprone-move-forwarding-reference `_, "Yes", "medium"
+   `bugprone-multiple-statement-macro `_, , "medium"
+   `bugprone-not-null-terminated-result `_, "Yes", "medium"
+   `bugprone-parent-virtual-call `_, "Yes", "medium"
+   `bugprone-posix-return `_, "Yes", ""
+   `bugprone-sizeof-container `_, , "high"
+   `bugprone-sizeof-expression `_, , "high"
+   `bugprone-string-constructor `_, "Yes", "high"
+   `bugprone-string-integer-assignment `_, "Yes", "low"
+   `bugprone-string-literal-with-embedded-nul `_, , "medium"
+   `bugprone-suspicious-enum-usage `_, , "high"
+   `bugprone-suspicious-memset-usage `_, "Yes", "high"
+   `bugprone-suspicious-missing-comma `_, , "high"
+   `bugprone-suspicious-semicolon `_, "Yes", "high"
+   `bugprone-suspicious-string-compare `_, "Yes", "medium"
+   `bugprone-swapped-arguments `_, "Yes", "high"
+   `bugprone-terminating-continue `_, "Yes", "medium"
+   `bugprone-throw-keyword-missing `_, , "medium"
+   `bugprone-too-small-loop-variable `_, , "medium"
+   `bugprone-undefined-memory-manipulation `_, , "medium"
+   `bugprone-undelegated-constructor `_, , "medium"
+   `bugprone-unhandled-self-assignment `_, , "medium"
+   `bugprone-unused-raii `_, "Yes", "high"
+   `bugprone-unused-return-value `_, , "medium"
+   `bugprone-use-after-move `_, , "high"
+   `bugprone-virtual-near-miss `_, "Yes", "medium"
+   `cert-dcl21-cpp `_, , "low"
+   `cert-dcl50-cpp `_, , "low"
+   `cert-dcl58-cpp `_, , "high"
+   `cert-env33-c `_, , "medium"
+   `cert-err34-c `_, , "low"
+   `cert-err52-cpp `_, , "low"
+   

[PATCH] D36051: [clang-tidy] List the checkers with autofix

[Eugene Zelenko via Phabricator via cfe-commits]

Eugene.Zelenko added inline comments.



Comment at: clang-tools-extra/docs/clang-tidy/checks/list.rst:291
+
+.. csv-table:: Alias..
+   :header: "Name", "Redirect", "Offers fixes", "Severity"

Aliases?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D36051/new/

https://reviews.llvm.org/D36051



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36051: [clang-tidy] List the checkers with autofix

[Sylvestre Ledru via Phabricator via cfe-commits]

sylvestre.ledru updated this revision to Diff 234918.
sylvestre.ledru added a comment.

Fix a rst warning + update the clang link "Clang Static Analyzer"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D36051/new/

https://reviews.llvm.org/D36051

Files:
  clang-tools-extra/docs/clang-tidy/checks/list.rst

Index: clang-tools-extra/docs/clang-tidy/checks/list.rst
===
--- clang-tools-extra/docs/clang-tidy/checks/list.rst
+++ clang-tools-extra/docs/clang-tidy/checks/list.rst
@@ -3,388 +3,408 @@
 Clang-Tidy Checks
 =
 
+.. Severities are coming from Codechecker:
+   https://github.com/Ericsson/codechecker/blob/master/config/checker_severity_map.json
+   If you change it here, please submit a PR on codechecker too
+
+.. csv-table::
+   :header: "Name", "Offers fixes", "Severity"
+   :widths: 50, 20, 10
+
+   `abseil-duration-addition `_, "Yes", ""
+   `abseil-duration-comparison `_, "Yes", ""
+   `abseil-duration-conversion-cast `_, "Yes", ""
+   `abseil-duration-division `_, "Yes", ""
+   `abseil-duration-factory-float `_, "Yes", ""
+   `abseil-duration-factory-scale `_, "Yes", ""
+   `abseil-duration-subtraction `_, "Yes", ""
+   `abseil-duration-unnecessary-conversion `_, "Yes", ""
+   `abseil-faster-strsplit-delimiter `_, "Yes", ""
+   `abseil-no-internal-dependencies `_, , ""
+   `abseil-no-namespace `_, , ""
+   `abseil-redundant-strcat-calls `_, "Yes", ""
+   `abseil-str-cat-append `_, "Yes", ""
+   `abseil-string-find-startswith `_, "Yes", "style"
+   `abseil-time-comparison `_, "Yes", ""
+   `abseil-time-subtraction `_, "Yes", ""
+   `abseil-upgrade-duration-conversions `_, "Yes", ""
+   `android-cloexec-accept `_, "Yes", ""
+   `android-cloexec-accept4 `_, , ""
+   `android-cloexec-creat `_, , "medium"
+   `android-cloexec-dup `_, , ""
+   `android-cloexec-epoll-create `_, , ""
+   `android-cloexec-epoll-create1 `_, , ""
+   `android-cloexec-fopen `_, , "medium"
+   `android-cloexec-inotify-init `_, , ""
+   `android-cloexec-inotify-init1 `_, , ""
+   `android-cloexec-memfd-create `_, , ""
+   `android-cloexec-open `_, , "medium"
+   `android-cloexec-pipe `_, , ""
+   `android-cloexec-pipe2 `_, , ""
+   `android-cloexec-socket `_, , "medium"
+   `android-comparison-in-temp-failure-retry `_, "Yes", ""
+   `boost-use-to-string `_, "Yes", "low"
+   `bugprone-argument-comment `_, "Yes", "low"
+   `bugprone-assert-side-effect `_, , "medium"
+   `bugprone-bad-signal-to-kill-thread `_, , ""
+   `bugprone-bool-pointer-implicit-conversion `_, "Yes", "low"
+   `bugprone-branch-clone `_, , "low"
+   `bugprone-copy-constructor-init `_, "Yes", "medium"
+   `bugprone-dangling-handle `_, , "high"
+   `bugprone-dynamic-static-initializers `_, , ""
+   `bugprone-exception-escape `_, , "medium"
+   `bugprone-fold-init-type `_, , "high"
+   `bugprone-forward-declaration-namespace `_, , "low"
+   `bugprone-forwarding-reference-overload `_, , "low"
+   `bugprone-inaccurate-erase `_, "Yes", "high"
+   `bugprone-incorrect-roundings `_, , "high"
+   `bugprone-infinite-loop `_, , "medium"
+   `bugprone-integer-division `_, , "medium"
+   `bugprone-lambda-function-name `_, , "low"
+   `bugprone-macro-parentheses `_, "Yes", "medium"
+   `bugprone-macro-repeated-side-effects `_, , "medium"
+   `bugprone-misplaced-operator-in-strlen-in-alloc `_, , "medium"
+   `bugprone-misplaced-widening-cast `_, "Yes", "high"
+   `bugprone-move-forwarding-reference `_, "Yes", "medium"
+   `bugprone-multiple-statement-macro `_, , "medium"
+   `bugprone-not-null-terminated-result `_, "Yes", "medium"
+   `bugprone-parent-virtual-call `_, "Yes", "medium"
+   `bugprone-posix-return `_, "Yes", ""
+   `bugprone-sizeof-container `_, , "high"
+   `bugprone-sizeof-expression `_, , "high"
+   `bugprone-string-constructor `_, "Yes", "high"
+   `bugprone-string-integer-assignment `_, "Yes", "low"
+   `bugprone-string-literal-with-embedded-nul `_, , "medium"
+   `bugprone-suspicious-enum-usage `_, , "high"
+   `bugprone-suspicious-memset-usage `_, "Yes", "high"
+   `bugprone-suspicious-missing-comma `_, , "high"
+   `bugprone-suspicious-semicolon `_, "Yes", "high"
+   `bugprone-suspicious-string-compare `_, "Yes", "medium"
+   `bugprone-swapped-arguments `_, "Yes", "high"
+   `bugprone-terminating-continue `_, "Yes", "medium"
+   `bugprone-throw-keyword-missing `_, , "medium"
+   `bugprone-too-small-loop-variable `_, , "medium"
+   `bugprone-undefined-memory-manipulation `_, , "medium"
+   `bugprone-undelegated-constructor `_, , "medium"
+   `bugprone-unhandled-self-assignment `_, , "medium"
+   `bugprone-unused-raii `_, "Yes", "high"
+   `bugprone-unused-return-value `_, , "medium"
+   `bugprone-use-after-move `_, , "high"
+   `bugprone-virtual-near-miss `_, "Yes", "medium"
+   `cert-dcl21-cpp `_, , "low"
+   `cert-dcl50-cpp `_, , "low"
+   `cert-dcl58-cpp `_, , "high"
+   `cert-env33-c `_, , "medium"
+   `cert-err34-c `_, , "low"
+ 

[PATCH] D36051: [clang-tidy] List the checkers with autofix

[Sylvestre Ledru via Phabricator via cfe-commits]

sylvestre.ledru added a comment.

In D36051#1792909 , @whisperity wrote:

> I am a little bit conflicted about the //Severity// column. While I know our 
> people put a great deal of effort into keeping this classification sane, what 
> was put into CodeChecker is, at the end of the day, a pretty arbitrary 
> classification.


Sure, static analysis is often subjective... Coverity has some classification 
too. From my experience, the one from code checker matches pretty well.

> I think RSTs support comments, right? Maybe it should be indicated in the 
> code (as a comment only) where the severity was taken from, so if someone 
> comes up with a reason to change a checker's severity, they could also submit 
> a patch to CodeChecker's knowledge-base.

Added, thanks for the idea!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D36051/new/

https://reviews.llvm.org/D36051



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36051: [clang-tidy] List the checkers with autofix

[Sylvestre Ledru via Phabricator via cfe-commits]

sylvestre.ledru updated this revision to Diff 234911.
sylvestre.ledru added a comment.

Add a comment about codechecker


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D36051/new/

https://reviews.llvm.org/D36051

Files:
  clang-tools-extra/docs/clang-tidy/checks/list.rst

Index: clang-tools-extra/docs/clang-tidy/checks/list.rst
===
--- clang-tools-extra/docs/clang-tidy/checks/list.rst
+++ clang-tools-extra/docs/clang-tidy/checks/list.rst
@@ -3,388 +3,403 @@
 Clang-Tidy Checks
 =
 
-.. toctree::
-   abseil-duration-addition
-   abseil-duration-comparison
-   abseil-duration-conversion-cast
-   abseil-duration-division
-   abseil-duration-factory-float
-   abseil-duration-factory-scale
-   abseil-duration-subtraction
-   abseil-duration-unnecessary-conversion
-   abseil-faster-strsplit-delimiter
-   abseil-no-internal-dependencies
-   abseil-no-namespace
-   abseil-redundant-strcat-calls
-   abseil-str-cat-append
-   abseil-string-find-startswith
-   abseil-time-comparison
-   abseil-time-subtraction
-   abseil-upgrade-duration-conversions
-   android-cloexec-accept
-   android-cloexec-accept4
-   android-cloexec-creat
-   android-cloexec-dup
-   android-cloexec-epoll-create
-   android-cloexec-epoll-create1
-   android-cloexec-fopen
-   android-cloexec-inotify-init
-   android-cloexec-inotify-init1
-   android-cloexec-memfd-create
-   android-cloexec-open
-   android-cloexec-pipe
-   android-cloexec-pipe2
-   android-cloexec-socket
-   android-comparison-in-temp-failure-retry
-   boost-use-to-string
-   bugprone-argument-comment
-   bugprone-assert-side-effect
-   bugprone-bad-signal-to-kill-thread
-   bugprone-bool-pointer-implicit-conversion
-   bugprone-branch-clone
-   bugprone-copy-constructor-init
-   bugprone-dangling-handle
-   bugprone-dynamic-static-initializers
-   bugprone-exception-escape
-   bugprone-fold-init-type
-   bugprone-forward-declaration-namespace
-   bugprone-forwarding-reference-overload
-   bugprone-inaccurate-erase
-   bugprone-incorrect-roundings
-   bugprone-infinite-loop
-   bugprone-integer-division
-   bugprone-lambda-function-name
-   bugprone-macro-parentheses
-   bugprone-macro-repeated-side-effects
-   bugprone-misplaced-operator-in-strlen-in-alloc
-   bugprone-misplaced-widening-cast
-   bugprone-move-forwarding-reference
-   bugprone-multiple-statement-macro
-   bugprone-not-null-terminated-result
-   bugprone-parent-virtual-call
-   bugprone-posix-return
-   bugprone-sizeof-container
-   bugprone-sizeof-expression
-   bugprone-string-constructor
-   bugprone-string-integer-assignment
-   bugprone-string-literal-with-embedded-nul
-   bugprone-suspicious-enum-usage
-   bugprone-suspicious-memset-usage
-   bugprone-suspicious-missing-comma
-   bugprone-suspicious-semicolon
-   bugprone-suspicious-string-compare
-   bugprone-swapped-arguments
-   bugprone-terminating-continue
-   bugprone-throw-keyword-missing
-   bugprone-too-small-loop-variable
-   bugprone-undefined-memory-manipulation
-   bugprone-undelegated-constructor
-   bugprone-unhandled-self-assignment
-   bugprone-unused-raii
-   bugprone-unused-return-value
-   bugprone-use-after-move
-   bugprone-virtual-near-miss
-   cert-dcl03-c (redirects to misc-static-assert) 
-   cert-dcl16-c (redirects to readability-uppercase-literal-suffix) 
-   cert-dcl21-cpp
-   cert-dcl50-cpp
-   cert-dcl54-cpp (redirects to misc-new-delete-overloads) 
-   cert-dcl58-cpp
-   cert-dcl59-cpp (redirects to google-build-namespaces) 
-   cert-env33-c
-   cert-err09-cpp (redirects to misc-throw-by-value-catch-by-reference) 
-   cert-err34-c
-   cert-err52-cpp
-   cert-err58-cpp
-   cert-err60-cpp
-   cert-err61-cpp (redirects to misc-throw-by-value-catch-by-reference) 
-   cert-fio38-c (redirects to misc-non-copyable-objects) 
-   cert-flp30-c
-   cert-mem57-cpp
-   cert-msc30-c (redirects to cert-msc50-cpp) 
-   cert-msc32-c (redirects to cert-msc51-cpp) 
-   cert-msc50-cpp
-   cert-msc51-cpp
-   cert-oop11-cpp (redirects to performance-move-constructor-init) 
-   cert-oop54-cpp (redirects to bugprone-unhandled-self-assignment) 
-   cert-oop58-cpp
-   cert-pos44-c (redirects to bugprone-bad-signal-to-kill-thread) 
-   clang-analyzer-core.CallAndMessage (redirects to https://clang.llvm.org/docs/analyzer/checkers.html) 
-   clang-analyzer-core.DivideZero (redirects to https://clang.llvm.org/docs/analyzer/checkers.html) 
-   clang-analyzer-core.DynamicTypePropagation
-   clang-analyzer-core.NonNullParamChecker (redirects to https://clang.llvm.org/docs/analyzer/checkers.html) 
-   clang-analyzer-core.NullDereference (redirects to https://clang.llvm.org/docs/analyzer/checkers.html) 
-   clang-analyzer-core.StackAddressEscape (redirects to https://clang.llvm.org/docs/analyzer/checkers.html) 
-   clang-analyzer-core.UndefinedBinaryOperatorResult (redirects to https://clang.llvm.org/docs/analyzer/checkers.html) 
-   

[PATCH] D36051: [clang-tidy] List the checkers with autofix

[Whisperity via Phabricator via cfe-commits]

whisperity added a comment.

I am a little bit conflicted about the //Severity// column. While I know our 
people put a great deal of effort into keeping this classification sane, what 
was put into CodeChecker is, at the end of the day, a pretty arbitrary 
classification.

I think RSTs support comments, right? Maybe it should be indicated in the code 
(as a comment only) where the severity was taken from, so if someone comes up 
with a reason to change a checker's severity, they could also submit a patch to 
CodeChecker's knowledge-base.

Maybe not //just// in the code comment, but also in the markup that gets 
rendered for the users, too?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D36051/new/

https://reviews.llvm.org/D36051



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36051: [clang-tidy] List the checkers with autofix

[Sylvestre Ledru via Phabricator via cfe-commits]

sylvestre.ledru updated this revision to Diff 234890.
sylvestre.ledru added a comment.

Remove artifacts


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D36051/new/

https://reviews.llvm.org/D36051

Files:
  clang-tools-extra/docs/clang-tidy/checks/list.rst

Index: clang-tools-extra/docs/clang-tidy/checks/list.rst
===
--- clang-tools-extra/docs/clang-tidy/checks/list.rst
+++ clang-tools-extra/docs/clang-tidy/checks/list.rst
@@ -3,388 +3,400 @@
 Clang-Tidy Checks
 =
 
-.. toctree::
-   abseil-duration-addition
-   abseil-duration-comparison
-   abseil-duration-conversion-cast
-   abseil-duration-division
-   abseil-duration-factory-float
-   abseil-duration-factory-scale
-   abseil-duration-subtraction
-   abseil-duration-unnecessary-conversion
-   abseil-faster-strsplit-delimiter
-   abseil-no-internal-dependencies
-   abseil-no-namespace
-   abseil-redundant-strcat-calls
-   abseil-str-cat-append
-   abseil-string-find-startswith
-   abseil-time-comparison
-   abseil-time-subtraction
-   abseil-upgrade-duration-conversions
-   android-cloexec-accept
-   android-cloexec-accept4
-   android-cloexec-creat
-   android-cloexec-dup
-   android-cloexec-epoll-create
-   android-cloexec-epoll-create1
-   android-cloexec-fopen
-   android-cloexec-inotify-init
-   android-cloexec-inotify-init1
-   android-cloexec-memfd-create
-   android-cloexec-open
-   android-cloexec-pipe
-   android-cloexec-pipe2
-   android-cloexec-socket
-   android-comparison-in-temp-failure-retry
-   boost-use-to-string
-   bugprone-argument-comment
-   bugprone-assert-side-effect
-   bugprone-bad-signal-to-kill-thread
-   bugprone-bool-pointer-implicit-conversion
-   bugprone-branch-clone
-   bugprone-copy-constructor-init
-   bugprone-dangling-handle
-   bugprone-dynamic-static-initializers
-   bugprone-exception-escape
-   bugprone-fold-init-type
-   bugprone-forward-declaration-namespace
-   bugprone-forwarding-reference-overload
-   bugprone-inaccurate-erase
-   bugprone-incorrect-roundings
-   bugprone-infinite-loop
-   bugprone-integer-division
-   bugprone-lambda-function-name
-   bugprone-macro-parentheses
-   bugprone-macro-repeated-side-effects
-   bugprone-misplaced-operator-in-strlen-in-alloc
-   bugprone-misplaced-widening-cast
-   bugprone-move-forwarding-reference
-   bugprone-multiple-statement-macro
-   bugprone-not-null-terminated-result
-   bugprone-parent-virtual-call
-   bugprone-posix-return
-   bugprone-sizeof-container
-   bugprone-sizeof-expression
-   bugprone-string-constructor
-   bugprone-string-integer-assignment
-   bugprone-string-literal-with-embedded-nul
-   bugprone-suspicious-enum-usage
-   bugprone-suspicious-memset-usage
-   bugprone-suspicious-missing-comma
-   bugprone-suspicious-semicolon
-   bugprone-suspicious-string-compare
-   bugprone-swapped-arguments
-   bugprone-terminating-continue
-   bugprone-throw-keyword-missing
-   bugprone-too-small-loop-variable
-   bugprone-undefined-memory-manipulation
-   bugprone-undelegated-constructor
-   bugprone-unhandled-self-assignment
-   bugprone-unused-raii
-   bugprone-unused-return-value
-   bugprone-use-after-move
-   bugprone-virtual-near-miss
-   cert-dcl03-c (redirects to misc-static-assert) 
-   cert-dcl16-c (redirects to readability-uppercase-literal-suffix) 
-   cert-dcl21-cpp
-   cert-dcl50-cpp
-   cert-dcl54-cpp (redirects to misc-new-delete-overloads) 
-   cert-dcl58-cpp
-   cert-dcl59-cpp (redirects to google-build-namespaces) 
-   cert-env33-c
-   cert-err09-cpp (redirects to misc-throw-by-value-catch-by-reference) 
-   cert-err34-c
-   cert-err52-cpp
-   cert-err58-cpp
-   cert-err60-cpp
-   cert-err61-cpp (redirects to misc-throw-by-value-catch-by-reference) 
-   cert-fio38-c (redirects to misc-non-copyable-objects) 
-   cert-flp30-c
-   cert-mem57-cpp
-   cert-msc30-c (redirects to cert-msc50-cpp) 
-   cert-msc32-c (redirects to cert-msc51-cpp) 
-   cert-msc50-cpp
-   cert-msc51-cpp
-   cert-oop11-cpp (redirects to performance-move-constructor-init) 
-   cert-oop54-cpp (redirects to bugprone-unhandled-self-assignment) 
-   cert-oop58-cpp
-   cert-pos44-c (redirects to bugprone-bad-signal-to-kill-thread) 
-   clang-analyzer-core.CallAndMessage (redirects to https://clang.llvm.org/docs/analyzer/checkers.html) 
-   clang-analyzer-core.DivideZero (redirects to https://clang.llvm.org/docs/analyzer/checkers.html) 
-   clang-analyzer-core.DynamicTypePropagation
-   clang-analyzer-core.NonNullParamChecker (redirects to https://clang.llvm.org/docs/analyzer/checkers.html) 
-   clang-analyzer-core.NullDereference (redirects to https://clang.llvm.org/docs/analyzer/checkers.html) 
-   clang-analyzer-core.StackAddressEscape (redirects to https://clang.llvm.org/docs/analyzer/checkers.html) 
-   clang-analyzer-core.UndefinedBinaryOperatorResult (redirects to https://clang.llvm.org/docs/analyzer/checkers.html) 
-   

[PATCH] D36051: [clang-tidy] List the checkers with autofix

[Sylvestre Ledru via Phabricator via cfe-commits]

sylvestre.ledru added a comment.

> But please, let's make that table heading nice. `Severity` is capitalised, 
> `name` is not, "has an autofix" sounds weird... Maybe "offers fixes" instead?

Good point, thanks :)
Done!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D36051/new/

https://reviews.llvm.org/D36051



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36051: [clang-tidy] List the checkers with autofix

[Sylvestre Ledru via Phabricator via cfe-commits]

sylvestre.ledru added a comment.

In D36051#1792684 , @Eugene.Zelenko 
wrote:

> May be also split table by checks groups?


Maybe? I would like to see this patch land first and iterate then on it. :)
This patch is already a significant improvement over the current state!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D36051/new/

https://reviews.llvm.org/D36051



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36051: [clang-tidy] List the checkers with autofix

[Eugene Zelenko via Phabricator via cfe-commits]

Eugene.Zelenko added a comment.

May be also split table by checks groups?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D36051/new/

https://reviews.llvm.org/D36051



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36051: [clang-tidy] List the checkers with autofix

[Whisperity via Phabricator via cfe-commits]

whisperity added a comment.

In D36051#1792432 , @sylvestre.ledru 
wrote:

> F0342: Screenshot_2019-12-20 clang-tidy - Clang-Tidy Checks — Extra Clang 
> Tools 10 documentation.png  
>  here is the result


Thank you thank you, I just almost submitted a patch for removing the second 
and onwards headings from the ToC.

But please, let's make that table heading nice. `Severity` is capitalised, 
`name` is not, "has an autofix" sounds weird... Maybe "offers fixes" instead?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D36051/new/

https://reviews.llvm.org/D36051



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36051: [clang-tidy] List the checkers with autofix

[Sylvestre Ledru via Phabricator via cfe-commits]

sylvestre.ledru added a comment.

F0342: Screenshot_2019-12-20 clang-tidy - Clang-Tidy Checks — Extra Clang 
Tools 10 documentation.png  
here is the result


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D36051/new/

https://reviews.llvm.org/D36051



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36051: [clang-tidy] List the checkers with autofix

[Sylvestre Ledru via Phabricator via cfe-commits]

sylvestre.ledru updated this revision to Diff 234841.
sylvestre.ledru edited the summary of this revision.
sylvestre.ledru added a comment.
Herald added a reviewer: jdoerfert.
Herald added a project: clang.

Move to the table idea... Two years after :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D36051/new/

https://reviews.llvm.org/D36051

Files:
  clang-tools-extra/docs/clang-tidy/checks/list.rst

Index: clang-tools-extra/docs/clang-tidy/checks/list.rst
===
--- clang-tools-extra/docs/clang-tidy/checks/list.rst
+++ clang-tools-extra/docs/clang-tidy/checks/list.rst
@@ -3,388 +3,400 @@
 Clang-Tidy Checks
 =
 
-.. toctree::
-   abseil-duration-addition
-   abseil-duration-comparison
-   abseil-duration-conversion-cast
-   abseil-duration-division
-   abseil-duration-factory-float
-   abseil-duration-factory-scale
-   abseil-duration-subtraction
-   abseil-duration-unnecessary-conversion
-   abseil-faster-strsplit-delimiter
-   abseil-no-internal-dependencies
-   abseil-no-namespace
-   abseil-redundant-strcat-calls
-   abseil-str-cat-append
-   abseil-string-find-startswith
-   abseil-time-comparison
-   abseil-time-subtraction
-   abseil-upgrade-duration-conversions
-   android-cloexec-accept
-   android-cloexec-accept4
-   android-cloexec-creat
-   android-cloexec-dup
-   android-cloexec-epoll-create
-   android-cloexec-epoll-create1
-   android-cloexec-fopen
-   android-cloexec-inotify-init
-   android-cloexec-inotify-init1
-   android-cloexec-memfd-create
-   android-cloexec-open
-   android-cloexec-pipe
-   android-cloexec-pipe2
-   android-cloexec-socket
-   android-comparison-in-temp-failure-retry
-   boost-use-to-string
-   bugprone-argument-comment
-   bugprone-assert-side-effect
-   bugprone-bad-signal-to-kill-thread
-   bugprone-bool-pointer-implicit-conversion
-   bugprone-branch-clone
-   bugprone-copy-constructor-init
-   bugprone-dangling-handle
-   bugprone-dynamic-static-initializers
-   bugprone-exception-escape
-   bugprone-fold-init-type
-   bugprone-forward-declaration-namespace
-   bugprone-forwarding-reference-overload
-   bugprone-inaccurate-erase
-   bugprone-incorrect-roundings
-   bugprone-infinite-loop
-   bugprone-integer-division
-   bugprone-lambda-function-name
-   bugprone-macro-parentheses
-   bugprone-macro-repeated-side-effects
-   bugprone-misplaced-operator-in-strlen-in-alloc
-   bugprone-misplaced-widening-cast
-   bugprone-move-forwarding-reference
-   bugprone-multiple-statement-macro
-   bugprone-not-null-terminated-result
-   bugprone-parent-virtual-call
-   bugprone-posix-return
-   bugprone-sizeof-container
-   bugprone-sizeof-expression
-   bugprone-string-constructor
-   bugprone-string-integer-assignment
-   bugprone-string-literal-with-embedded-nul
-   bugprone-suspicious-enum-usage
-   bugprone-suspicious-memset-usage
-   bugprone-suspicious-missing-comma
-   bugprone-suspicious-semicolon
-   bugprone-suspicious-string-compare
-   bugprone-swapped-arguments
-   bugprone-terminating-continue
-   bugprone-throw-keyword-missing
-   bugprone-too-small-loop-variable
-   bugprone-undefined-memory-manipulation
-   bugprone-undelegated-constructor
-   bugprone-unhandled-self-assignment
-   bugprone-unused-raii
-   bugprone-unused-return-value
-   bugprone-use-after-move
-   bugprone-virtual-near-miss
-   cert-dcl03-c (redirects to misc-static-assert) 
-   cert-dcl16-c (redirects to readability-uppercase-literal-suffix) 
-   cert-dcl21-cpp
-   cert-dcl50-cpp
-   cert-dcl54-cpp (redirects to misc-new-delete-overloads) 
-   cert-dcl58-cpp
-   cert-dcl59-cpp (redirects to google-build-namespaces) 
-   cert-env33-c
-   cert-err09-cpp (redirects to misc-throw-by-value-catch-by-reference) 
-   cert-err34-c
-   cert-err52-cpp
-   cert-err58-cpp
-   cert-err60-cpp
-   cert-err61-cpp (redirects to misc-throw-by-value-catch-by-reference) 
-   cert-fio38-c (redirects to misc-non-copyable-objects) 
-   cert-flp30-c
-   cert-mem57-cpp
-   cert-msc30-c (redirects to cert-msc50-cpp) 
-   cert-msc32-c (redirects to cert-msc51-cpp) 
-   cert-msc50-cpp
-   cert-msc51-cpp
-   cert-oop11-cpp (redirects to performance-move-constructor-init) 
-   cert-oop54-cpp (redirects to bugprone-unhandled-self-assignment) 
-   cert-oop58-cpp
-   cert-pos44-c (redirects to bugprone-bad-signal-to-kill-thread) 
-   clang-analyzer-core.CallAndMessage (redirects to https://clang.llvm.org/docs/analyzer/checkers.html) 
-   clang-analyzer-core.DivideZero (redirects to https://clang.llvm.org/docs/analyzer/checkers.html) 
-   clang-analyzer-core.DynamicTypePropagation
-   clang-analyzer-core.NonNullParamChecker (redirects to https://clang.llvm.org/docs/analyzer/checkers.html) 
-   clang-analyzer-core.NullDereference (redirects to https://clang.llvm.org/docs/analyzer/checkers.html) 
-   clang-analyzer-core.StackAddressEscape (redirects to 

[PATCH] D36051: [clang-tidy] List the checkers with autofix

[Jonas Toth via Phabricator via cfe-commits]

JonasToth added a comment.

In my opinion, this list should be available to the executable for two reasons.

1. External tools, that want to integrate clang-tidy in their workflow should 
be able to get the information about fixits, since they could collidie with 
their own textual replacements
2. One might enable/disable only fixing checks. This one is less important, 
since the -fix flag is available.

Having it written in code, like maybe a flag you set when subclassing the 
check, makes it ez to automatically determine if the check is modifying for 
documentation as well.


https://reviews.llvm.org/D36051



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36051: [clang-tidy] List the checkers with autofix

[Alexander Kornienko via Phabricator via cfe-commits]

alexfh added a comment.

In https://reviews.llvm.org/D36051#825428, @xazax.hun wrote:

> Maybe instead of a separate list, having this information like yes/no column 
> in a table in the original is more user-friendly.


What the better format is would depend on for which purpose do we want to 
expose this information and how it will likely be used. Does anyone have a 
clear idea about this?

Another point is that it would be much better if we come up with a reliable way 
to keep this information up-to-date. I currently see a few ways to find which 
checks are able to issue fix-its:

1. Analyze lit tests: each test contains the name of the check and most of them 
use the check_clang_tidy script and CHECK-FIXES prefix to verify fixes. This 
only works for checks that have lit tests, but the good thing is that we'll 
only list checks that have test for fixes ;)
2. Analyze checks' source code for the presence of FixItHint or utility 
functions that generate it.
3. Require checks to issue a specific call (or be registered with a certain 
flag) to enable fix-its. This way we'll have this information in runtime and 
will be able to expose it in -list-checks.
4. Analyze checks' documentation and require it to contain a certain pattern, 
if the check supports fixes.

But first we need to answer the question on how this information is going to be 
used.


https://reviews.llvm.org/D36051



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36051: [clang-tidy] List the checkers with autofix

[Eugene Zelenko via Phabricator via cfe-commits]

Eugene.Zelenko added a comment.

I think will be good idea to do this in -list-checks too.


https://reviews.llvm.org/D36051



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36051: [clang-tidy] List the checkers with autofix

[Sylvestre Ledru via Phabricator via cfe-commits]

sylvestre.ledru added a comment.

Good ideas guys. I will try to update list.rst to a table with the extra 
information.


https://reviews.llvm.org/D36051



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36051: [clang-tidy] List the checkers with autofix

[Gábor Horváth via Phabricator via cfe-commits]

xazax.hun added a comment.

Maybe instead of a separate list, having this information like yes/no column in 
a table in the original is more user-friendly.


https://reviews.llvm.org/D36051



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36051: [clang-tidy] List the checkers with autofix

[Jonas Toth via Phabricator via cfe-commits]

JonasToth added a comment.

would be a classification of checks in general interesting?

i could think of "quality", some checks might be heuristic, some might be new 
and have some bugs, and some might catch everything correct and handle it 
perfectly.

So checks could have 2 categories:

-> autofixing/warning
-> always correct/heuristic/unsure

This would maybe improve acceptance, since you know what you get. If you are 
not interested in toying around, just activate the "always correct" stuff, and 
you wont accidentially break your code.


https://reviews.llvm.org/D36051



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36051: [clang-tidy] List the checkers with autofix

[Sylvestre Ledru via Phabricator via cfe-commits]

sylvestre.ledru created this revision.
Herald added subscribers: xazax.hun, JDevlieghere.

In the current list http://clang.llvm.org/extra/clang-tidy/checks/list.html
it is hard to know which one has autofix or not. 
This isn't perfect because we will have to list but I haven't found a better 
way.


https://reviews.llvm.org/D36051

Files:
  docs/clang-tidy/checks/list-fix.rst
  docs/clang-tidy/index.rst


Index: docs/clang-tidy/checks/list-fix.rst
===
--- docs/clang-tidy/checks/list-fix.rst
+++ docs/clang-tidy/checks/list-fix.rst
@@ -0,0 +1,53 @@
+.. title:: clang-tidy - Clang-Tidy Checks with auto fix
+
+Clang-Tidy Checks with auto fix
+===
+
+.. toctree::
+   boost-use-to-string
+   cppcoreguidelines-pro-bounds-constant-array-index
+   cppcoreguidelines-pro-type-cstyle-cast
+   cppcoreguidelines-pro-type-cstyle-cast
+   cppcoreguidelines-pro-type-static-cast-downcast
+   google-build-explicit-make-pair
+   google-readability-todo
+   llvm-header-guard
+   llvm-include-order
+   llvm-namespace-comment
+   llvm-twine-local
+   misc-argument-comment
+   misc-inefficient-algorithm
+   misc-move-forwarding-reference
+   misc-static-assert
+   misc-uniqueptr-reset-release
+   misc-unused-parameters
+   misc-unused-raii
+   misc-virtual-near-miss
+   modernize-avoid-bind
+   modernize-deprecated-headers
+   modernize-loop-convert
+   modernize-make-shared
+   modernize-pass-by-value
+   modernize-raw-string-literal
+   modernize-replace-auto-ptr
+   modernize-return-braced-init-list
+   modernize-shrink-to-fit
+   modernize-use-auto
+   modernize-use-bool-literals
+   modernize-use-emplace
+   modernize-use-equals-default
+   modernize-use-nullptr
+   modernize-use-using
+   performance-faster-string-find
+   performance-type-promotion-in-math-fn
+   readability-container-size-empty
+   readability-else-after-return
+   readability-identifier-naming
+   readability-implicit-bool-cast
+   readability-inconsistent-declaration-parameter-name
+   readability-misplaced-array-index
+   readability-redundant-smartptr-get
+   readability-redundant-string-cstr
+   readability-redundant-string-init
+   readability-simplify-boolean-expr
+   readability-uniqueptr-delete-release
Index: docs/clang-tidy/index.rst
===
--- docs/clang-tidy/index.rst
+++ docs/clang-tidy/index.rst
@@ -10,6 +10,7 @@
:maxdepth: 1
 
The list of clang-tidy checks 
+   The list of clang-tidy checks including auto fixes 
 
 :program:`clang-tidy` is a clang-based C++ "linter" tool. Its purpose is to
 provide an extensible framework for diagnosing and fixing typical programming


Index: docs/clang-tidy/checks/list-fix.rst
===
--- docs/clang-tidy/checks/list-fix.rst
+++ docs/clang-tidy/checks/list-fix.rst
@@ -0,0 +1,53 @@
+.. title:: clang-tidy - Clang-Tidy Checks with auto fix
+
+Clang-Tidy Checks with auto fix
+===
+
+.. toctree::
+   boost-use-to-string
+   cppcoreguidelines-pro-bounds-constant-array-index
+   cppcoreguidelines-pro-type-cstyle-cast
+   cppcoreguidelines-pro-type-cstyle-cast
+   cppcoreguidelines-pro-type-static-cast-downcast
+   google-build-explicit-make-pair
+   google-readability-todo
+   llvm-header-guard
+   llvm-include-order
+   llvm-namespace-comment
+   llvm-twine-local
+   misc-argument-comment
+   misc-inefficient-algorithm
+   misc-move-forwarding-reference
+   misc-static-assert
+   misc-uniqueptr-reset-release
+   misc-unused-parameters
+   misc-unused-raii
+   misc-virtual-near-miss
+   modernize-avoid-bind
+   modernize-deprecated-headers
+   modernize-loop-convert
+   modernize-make-shared
+   modernize-pass-by-value
+   modernize-raw-string-literal
+   modernize-replace-auto-ptr
+   modernize-return-braced-init-list
+   modernize-shrink-to-fit
+   modernize-use-auto
+   modernize-use-bool-literals
+   modernize-use-emplace
+   modernize-use-equals-default
+   modernize-use-nullptr
+   modernize-use-using
+   performance-faster-string-find
+   performance-type-promotion-in-math-fn
+   readability-container-size-empty
+   readability-else-after-return
+   readability-identifier-naming
+   readability-implicit-bool-cast
+   readability-inconsistent-declaration-parameter-name
+   readability-misplaced-array-index
+   readability-redundant-smartptr-get
+   readability-redundant-string-cstr
+   readability-redundant-string-init
+   readability-simplify-boolean-expr
+   readability-uniqueptr-delete-release
Index: docs/clang-tidy/index.rst
===
--- docs/clang-tidy/index.rst
+++ docs/clang-tidy/index.rst
@@ -10,6 +10,7 @@
:maxdepth: 1
 
The list of clang-tidy checks 
+   The list of clang-tidy checks including auto fixes 
 
 :program:`clang-tidy` is a clang-based C++ "linter" tool. Its purpose is to