[PATCH] D40991: [libcxx] [test] Fix line endings, avoid unnecessary non-ASCII.

[Marshall Clow via Phabricator via cfe-commits]

mclow.lists added a comment.

> Thanks, I've checked this in without the changes to TODO.TXT

Thanks - that works for me.


https://reviews.llvm.org/D40991



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40991: [libcxx] [test] Fix line endings, avoid unnecessary non-ASCII.

[Stephan T. Lavavej via Phabricator via cfe-commits]

STL_MSFT accepted this revision.
STL_MSFT added a comment.
This revision is now accepted and ready to land.

Thanks, I've checked this in without the changes to TODO.TXT. Please let me 
know if you still want them, otherwise I consider this to be complete.


https://reviews.llvm.org/D40991



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40991: [libcxx] [test] Fix line endings, avoid unnecessary non-ASCII.

[Zhihao Yuan via Phabricator via cfe-commits]

lichray added a comment.

LGTM as-is with the changes to the TODO file...


https://reviews.llvm.org/D40991



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40991: [libcxx] [test] Fix line endings, avoid unnecessary non-ASCII.

[Stephan T. Lavavej via Phabricator via cfe-commits]

STL_MSFT added a comment.

Would you like me to drop the changes to TODO.TXT?


https://reviews.llvm.org/D40991



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40991: [libcxx] [test] Fix line endings, avoid unnecessary non-ASCII.

[Marshall Clow via Phabricator via cfe-commits]

mclow.lists added a comment.

Except for the stuff in TODO.txt these look good to me.
We need to do some work on that file - it's pretty out of date.


https://reviews.llvm.org/D40991



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40991: [libcxx] [test] Fix line endings, avoid unnecessary non-ASCII.

[Stephan T. Lavavej via Phabricator via cfe-commits]

STL_MSFT created this revision.

[libcxx] [test] Fix line endings, avoid unnecessary non-ASCII.

I recently wrote a tool to audit MSVC's codebase for inconsistent line endings 
and unnecessary non-ASCII characters, and I ran it over libcxx's codebase too. 
I don't need any of these changes to be committed, so feel free to reject them 
- I just thought you might be interested.

There's a significant non-ASCII string in 
test/std/re/re.alg/re.alg.search/grep.pass.cpp which I haven't attempted to 
convert into escapes.

TODO.TXT
Avoid non-ASCII characters.

benchmarks/util_smartptr.bench.cpp
Change CRLF to LF.

test/std/localization/locale.categories/category.monetary/locale.money.get/locale.money.get.members/get_long_double_fr_FR.pass.cpp
Consistently comment "\u20ac" as EURO SIGN, its Unicode name, instead of the 
actual Unicode character.

test/std/utilities/allocator.adaptor/allocator.adaptor.members/construct_type.pass.cpp
Avoid non-ASCII dash.


https://reviews.llvm.org/D40991

Files:
  TODO.TXT
  benchmarks/util_smartptr.bench.cpp
  
test/std/localization/locale.categories/category.monetary/locale.money.get/locale.money.get.members/get_long_double_fr_FR.pass.cpp
  
test/std/utilities/allocator.adaptor/allocator.adaptor.members/construct_type.pass.cpp

Index: test/std/utilities/allocator.adaptor/allocator.adaptor.members/construct_type.pass.cpp
===
--- test/std/utilities/allocator.adaptor/allocator.adaptor.members/construct_type.pass.cpp
+++ test/std/utilities/allocator.adaptor/allocator.adaptor.members/construct_type.pass.cpp
@@ -26,7 +26,7 @@
 #include "uses_alloc_types.hpp"
 #include "controlled_allocators.hpp"
 
-// — If uses_allocator_v is false and
+// - If uses_allocator_v is false and
 //   is_constructible_v is true, calls
 //   OUTERMOST_ALLOC_TRAITS(*this)::construct(
 //  OUTERMOST (*this), p, std::forward(args)...).
Index: test/std/localization/locale.categories/category.monetary/locale.money.get/locale.money.get.members/get_long_double_fr_FR.pass.cpp
===
--- test/std/localization/locale.categories/category.monetary/locale.money.get/locale.money.get.members/get_long_double_fr_FR.pass.cpp
+++ test/std/localization/locale.categories/category.monetary/locale.money.get/locale.money.get.members/get_long_double_fr_FR.pass.cpp
@@ -117,7 +117,7 @@
 assert(ex == -123456789);
 }
 {   // zero, showbase
-std::string v = "0,00 \u20ac";  // €
+std::string v = "0,00 \u20ac";  // EURO SIGN
 showbase(ios);
 typedef input_iterator I;
 long double ex;
@@ -129,7 +129,7 @@
 assert(ex == 0);
 }
 {   // zero, showbase
-std::string v = "0,00 \u20ac";  // €
+std::string v = "0,00 \u20ac";  // EURO SIGN
 showbase(ios);
 typedef input_iterator I;
 long double ex;
@@ -141,7 +141,7 @@
 assert(ex == 0);
 }
 {   // negative one, showbase
-std::string v = "-0,01 \u20ac";
+std::string v = "-0,01 \u20ac";  // EURO SIGN
 typedef input_iterator I;
 long double ex;
 std::ios_base::iostate err = std::ios_base::goodbit;
@@ -152,7 +152,7 @@
 assert(ex == -1);
 }
 {   // negative one, showbase
-std::string v = "-0,01 \u20ac";
+std::string v = "-0,01 \u20ac";  // EURO SIGN
 showbase(ios);
 typedef input_iterator I;
 long double ex;
@@ -164,7 +164,7 @@
 assert(ex == -1);
 }
 {   // positive, showbase
-std::string v = "1 234 567,89 \u20ac";
+std::string v = "1 234 567,89 \u20ac";  // EURO SIGN
 typedef input_iterator I;
 long double ex;
 std::ios_base::iostate err = std::ios_base::goodbit;
@@ -175,7 +175,7 @@
 assert(ex == 123456789);
 }
 {   // positive, showbase
-std::string v = "1 234 567,89 \u20ac";
+std::string v = "1 234 567,89 \u20ac";  // EURO SIGN
 showbase(ios);
 typedef input_iterator I;
 long double ex;
@@ -188,7 +188,7 @@
 noshowbase(ios);
 }
 {   // negative, showbase
-std::string v = "-1 234 567,89 \u20ac";
+std::string v = "-1 234 567,89 \u20ac";  // EURO SIGN
 showbase(ios);
 typedef input_iterator I;
 long double ex;
@@ -450,7 +450,7 @@
 assert(ex == -123456789);
 }
 {   // zero, showbase
-std::wstring v = L"0,00 \u20ac";
+std::wstring v = L"0,00 \u20ac";  // EURO SIGN
 showbase(ios);
 typedef input_iterator I;
 long double ex;
@@ -462,7 +462,7 @@
 assert(ex == 0);
 }