[PATCH] D42370: Issue local statics in correct DWARF lexical scope
dblaikie added a comment. Just to clarify - the general philosophy (there are many cases of exceptions due to complications in various areas) is that clang changes should have clang tests (source code to IR), LLVM changes should have LLVM tests (IR to assembly or object code+dwarf dump) & if debuginfo-tests are optional/as-desired. https://reviews.llvm.org/D42370 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D42370: Issue local statics in correct DWARF lexical scope
rnk requested changes to this revision. rnk added a comment. This revision now requires changes to proceed. Still needs a test. https://reviews.llvm.org/D42370 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D42370: Issue local statics in correct DWARF lexical scope
JDevlieghere accepted this revision as: JDevlieghere. JDevlieghere added a comment. This revision is now accepted and ready to land. This makes sense to me, LGTM. https://reviews.llvm.org/D42370 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D42370: Issue local statics in correct DWARF lexical scope
probinson added subscribers: cfe-commits, probinson. probinson added a comment. +cfe-commits See also the LLVM change in https://reviews.llvm.org/D42369 and a debuginfo-tests test in https://reviews.llvm.org/D42371. https://reviews.llvm.org/D42370 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits