[PATCH] D43953: clangformat-vs: Fix plugin not correctly loading in some cases

[Kristina Brooks via Phabricator via cfe-commits]

kristina accepted this revision as: kristina.
kristina added a comment.
This revision is now accepted and ready to land.

Seems something that's not easy to test or reproduce even with VS (the plugin 
itself is 3rd party if I understand right) but it looks sane.


Repository:
  rC Clang

https://reviews.llvm.org/D43953



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43953: clangformat-vs: Fix plugin not correctly loading in some cases

[François-Xavier Roure via Phabricator via cfe-commits]

fxroure-ubisoft created this revision.
fxroure-ubisoft added a reviewer: clang.
fxroure-ubisoft created this object with edit policy "Only User: 
fxroure-ubisoft (François-Xavier Roure)".
Herald added a subscriber: cfe-commits.

When installing the clang-format visual studio plugin 

 sometimes it won't be loaded correctly (some users seem to have the same issue 
)
 and we must do

  devenv.exe /updateconfiguration

in order to fix the installation (normally visual studio should automatically 
execute this command whenever you install a plugin).
This issue seems to come from the fact that the plugin manifest does not list a 
VsPackage as an asset.
After adding it to assets list (code change in this review) installation of the 
plugin was working and when uninstalling the plugin visual correctly ask to 
restart it (that was not the case before).


Repository:
  rC Clang

https://reviews.llvm.org/D43953

Files:
  tools/clang-format-vs/source.extension.vsixmanifest.in


Index: tools/clang-format-vs/source.extension.vsixmanifest.in
===
--- tools/clang-format-vs/source.extension.vsixmanifest.in
+++ tools/clang-format-vs/source.extension.vsixmanifest.in
@@ -16,4 +16,7 @@
   
 
   
+  
+
+  
 


Index: tools/clang-format-vs/source.extension.vsixmanifest.in
===
--- tools/clang-format-vs/source.extension.vsixmanifest.in
+++ tools/clang-format-vs/source.extension.vsixmanifest.in
@@ -16,4 +16,7 @@
   
 
   
+  
+
+  
 
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits