[PATCH] D46995: [test-suite] Enable CUDA complex tests with libc++ now that D25403 is resolved.
This revision was automatically updated to reflect the committed changes. jlebar marked an inline comment as done. Closed by commit rL332660: [test-suite] Enable CUDA complex tests with libc++ now that D25403 is resolved. (authored by jlebar, committed by ). Repository: rL LLVM https://reviews.llvm.org/D46995 Files: test-suite/trunk/External/CUDA/complex.cu Index: test-suite/trunk/External/CUDA/complex.cu === --- test-suite/trunk/External/CUDA/complex.cu +++ test-suite/trunk/External/CUDA/complex.cu @@ -18,15 +18,10 @@ #include // These tests are pretty annoying to write without C++11, so we require that. -// In addition, these tests currently don't compile with libc++, because of the -// issue in https://reviews.llvm.org/D25403. -// -// TODO: Once that issue is resolved, take out !defined(_LIBCPP_VERSION) here. // // In addition, these tests don't work in C++14 mode with pre-C++14 versions of // libstdc++ (compile errors in ). -#if __cplusplus >= 201103L && !defined(_LIBCPP_VERSION) && \ -(__cplusplus < 201402L || STDLIB_VERSION >= 2014) +#if __cplusplus >= 201103L && (__cplusplus < 201402L || STDLIB_VERSION >= 2014) #include #include Index: test-suite/trunk/External/CUDA/complex.cu === --- test-suite/trunk/External/CUDA/complex.cu +++ test-suite/trunk/External/CUDA/complex.cu @@ -18,15 +18,10 @@ #include // These tests are pretty annoying to write without C++11, so we require that. -// In addition, these tests currently don't compile with libc++, because of the -// issue in https://reviews.llvm.org/D25403. -// -// TODO: Once that issue is resolved, take out !defined(_LIBCPP_VERSION) here. // // In addition, these tests don't work in C++14 mode with pre-C++14 versions of // libstdc++ (compile errors in ). -#if __cplusplus >= 201103L && !defined(_LIBCPP_VERSION) && \ -(__cplusplus < 201402L || STDLIB_VERSION >= 2014) +#if __cplusplus >= 201103L && (__cplusplus < 201402L || STDLIB_VERSION >= 2014) #include #include ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D46995: [test-suite] Enable CUDA complex tests with libc++ now that D25403 is resolved.
jlebar marked an inline comment as done. jlebar added inline comments. Comment at: External/CUDA/complex.cu:24 // libstdc++ (compile errors in ). -#if __cplusplus >= 201103L && !defined(_LIBCPP_VERSION) && \ -(__cplusplus < 201402L || STDLIB_VERSION >= 2014) +#if __cplusplus >= 201103L && (__cplusplus < 201402L || STDLIB_VERSION >= 2014) tra wrote: > Is this specific to c++14 only, or will we have similar conditions for > c++17,20, etc? > Perhaps we could express library version requirements as `STDLIB_VERSION >= > (__cplusplus / 100)` ? > I'm OK with either way. > > I think it's specific to c++14 -- or at least, it's not necessarily a general problem. The other benchmarks work with C++14 compiler plus C++11 stdlib -- it's just that gives us problems in the particular gcc versions we happen to use. Repository: rT test-suite https://reviews.llvm.org/D46995 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D46995: [test-suite] Enable CUDA complex tests with libc++ now that D25403 is resolved.
tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: External/CUDA/complex.cu:24 // libstdc++ (compile errors in ). -#if __cplusplus >= 201103L && !defined(_LIBCPP_VERSION) && \ -(__cplusplus < 201402L || STDLIB_VERSION >= 2014) +#if __cplusplus >= 201103L && (__cplusplus < 201402L || STDLIB_VERSION >= 2014) Is this specific to c++14 only, or will we have similar conditions for c++17,20, etc? Perhaps we could express library version requirements as `STDLIB_VERSION >= (__cplusplus / 100)` ? I'm OK with either way. Repository: rT test-suite https://reviews.llvm.org/D46995 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D46995: [test-suite] Enable CUDA complex tests with libc++ now that D25403 is resolved.
jlebar created this revision. jlebar added a reviewer: tra. Herald added subscribers: llvm-commits, sanjoy. Herald added a reviewer: EricWF. Repository: rT test-suite https://reviews.llvm.org/D46995 Files: External/CUDA/complex.cu Index: External/CUDA/complex.cu === --- External/CUDA/complex.cu +++ External/CUDA/complex.cu @@ -18,15 +18,10 @@ #include // These tests are pretty annoying to write without C++11, so we require that. -// In addition, these tests currently don't compile with libc++, because of the -// issue in https://reviews.llvm.org/D25403. -// -// TODO: Once that issue is resolved, take out !defined(_LIBCPP_VERSION) here. // // In addition, these tests don't work in C++14 mode with pre-C++14 versions of // libstdc++ (compile errors in ). -#if __cplusplus >= 201103L && !defined(_LIBCPP_VERSION) && \ -(__cplusplus < 201402L || STDLIB_VERSION >= 2014) +#if __cplusplus >= 201103L && (__cplusplus < 201402L || STDLIB_VERSION >= 2014) #include #include Index: External/CUDA/complex.cu === --- External/CUDA/complex.cu +++ External/CUDA/complex.cu @@ -18,15 +18,10 @@ #include // These tests are pretty annoying to write without C++11, so we require that. -// In addition, these tests currently don't compile with libc++, because of the -// issue in https://reviews.llvm.org/D25403. -// -// TODO: Once that issue is resolved, take out !defined(_LIBCPP_VERSION) here. // // In addition, these tests don't work in C++14 mode with pre-C++14 versions of // libstdc++ (compile errors in ). -#if __cplusplus >= 201103L && !defined(_LIBCPP_VERSION) && \ -(__cplusplus < 201402L || STDLIB_VERSION >= 2014) +#if __cplusplus >= 201103L && (__cplusplus < 201402L || STDLIB_VERSION >= 2014) #include #include ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
