[PATCH] D49348: Harden/relax clang/test/CodeGen/opt-record-MIR.c test

2018-07-17 Thread Phabricator via Phabricator via cfe-commits 
This revision was automatically updated to reflect the committed changes.
Closed by commit rL337249: Harden/relax clang/test/CodeGen/opt-record-MIR.c 
test (authored by lebedevri, committed by ).

Changed prior to commit:
  https://reviews.llvm.org/D49348?vs=155591&id=155820#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D49348

Files:
  cfe/trunk/test/CodeGen/opt-record-MIR.c


Index: cfe/trunk/test/CodeGen/opt-record-MIR.c
===
--- cfe/trunk/test/CodeGen/opt-record-MIR.c
+++ cfe/trunk/test/CodeGen/opt-record-MIR.c
@@ -21,8 +21,9 @@
 // YAML: --- !Missed
 // YAML: Pass:regalloc
 // YAML: Name:LoopSpillReload
-// YAML: DebugLoc:{ File: {{.*}},
-// YAML:Line: 10, Column: 11 }
+// YAML: DebugLoc:{ File: {{[^,]+}},
+// YAML:Line: 10,
+// YAML:Column: 11 }
 // YAML: Function:foo
 // YAML: Args:
 // YAML:   - NumSpills:   '{{.}}'


Index: cfe/trunk/test/CodeGen/opt-record-MIR.c
===
--- cfe/trunk/test/CodeGen/opt-record-MIR.c
+++ cfe/trunk/test/CodeGen/opt-record-MIR.c
@@ -21,8 +21,9 @@
 // YAML: --- !Missed
 // YAML: Pass:regalloc
 // YAML: Name:LoopSpillReload
-// YAML: DebugLoc:{ File: {{.*}},
-// YAML:Line: 10, Column: 11 }
+// YAML: DebugLoc:{ File: {{[^,]+}},
+// YAML:Line: 10,
+// YAML:Column: 11 }
 // YAML: Function:foo
 // YAML: Args:
 // YAML:   - NumSpills:   '{{.}}'
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49348: Harden/relax clang/test/CodeGen/opt-record-MIR.c test

2018-07-16 Thread Roman Lebedev via Phabricator via cfe-commits 
lebedev.ri added a comment.

In https://reviews.llvm.org/D49348#1164579, @anemet wrote:

> LGTM, thanks!


Thank you for the review.
(I'll watch the bots, obviously)


Repository:
  rC Clang

https://reviews.llvm.org/D49348



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49348: Harden/relax clang/test/CodeGen/opt-record-MIR.c test

2018-07-16 Thread Adam Nemet via Phabricator via cfe-commits 
anemet accepted this revision.
anemet added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!


Repository:
  rC Clang

https://reviews.llvm.org/D49348



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49348: Harden/relax clang/test/CodeGen/opt-record-MIR.c test

2018-07-15 Thread Roman Lebedev via Phabricator via cfe-commits 
lebedev.ri updated this revision to Diff 155591.
lebedev.ri added a comment.

Simplify regex even more.


Repository:
  rC Clang

https://reviews.llvm.org/D49348

Files:
  test/CodeGen/opt-record-MIR.c


Index: test/CodeGen/opt-record-MIR.c
===
--- test/CodeGen/opt-record-MIR.c
+++ test/CodeGen/opt-record-MIR.c
@@ -21,8 +21,9 @@
 // YAML: --- !Missed
 // YAML: Pass:regalloc
 // YAML: Name:LoopSpillReload
-// YAML: DebugLoc:{ File: {{.*}},
-// YAML:Line: 10, Column: 11 }
+// YAML: DebugLoc:{ File: {{[^,]+}},
+// YAML:Line: 10,
+// YAML:Column: 11 }
 // YAML: Function:foo
 // YAML: Args:
 // YAML:   - NumSpills:   '{{.}}'


Index: test/CodeGen/opt-record-MIR.c
===
--- test/CodeGen/opt-record-MIR.c
+++ test/CodeGen/opt-record-MIR.c
@@ -21,8 +21,9 @@
 // YAML: --- !Missed
 // YAML: Pass:regalloc
 // YAML: Name:LoopSpillReload
-// YAML: DebugLoc:{ File: {{.*}},
-// YAML:Line: 10, Column: 11 }
+// YAML: DebugLoc:{ File: {{[^,]+}},
+// YAML:Line: 10,
+// YAML:Column: 11 }
 // YAML: Function:foo
 // YAML: Args:
 // YAML:   - NumSpills:   '{{.}}'
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49348: Harden/relax clang/test/CodeGen/opt-record-MIR.c test

2018-07-15 Thread Roman Lebedev via Phabricator via cfe-commits 
lebedev.ri created this revision.
lebedev.ri added reviewers: anemet, aaron.ballman, hfinkel.
Herald added a subscriber: cfe-commits.

If the build path is short, `Line` field can end up fitting on the same line as 
`File`,
but the `{{.*}}` would consume it. Keeping in mind 
https://reviews.llvm.org/rL293149, i think we can fix it,
while keeping it working when there are and there are not any quotations.
At least this fixes this test for me.


Repository:
  rC Clang

https://reviews.llvm.org/D49348

Files:
  test/CodeGen/opt-record-MIR.c


Index: test/CodeGen/opt-record-MIR.c
===
--- test/CodeGen/opt-record-MIR.c
+++ test/CodeGen/opt-record-MIR.c
@@ -21,8 +21,9 @@
 // YAML: --- !Missed
 // YAML: Pass:regalloc
 // YAML: Name:LoopSpillReload
-// YAML: DebugLoc:{ File: {{.*}},
-// YAML:Line: 10, Column: 11 }
+// YAML: DebugLoc:{ File: {{.*}}.c{{['"]*}},
+// YAML:Line: 10,
+// YAML:Column: 11 }
 // YAML: Function:foo
 // YAML: Args:
 // YAML:   - NumSpills:   '{{.}}'


Index: test/CodeGen/opt-record-MIR.c
===
--- test/CodeGen/opt-record-MIR.c
+++ test/CodeGen/opt-record-MIR.c
@@ -21,8 +21,9 @@
 // YAML: --- !Missed
 // YAML: Pass:regalloc
 // YAML: Name:LoopSpillReload
-// YAML: DebugLoc:{ File: {{.*}},
-// YAML:Line: 10, Column: 11 }
+// YAML: DebugLoc:{ File: {{.*}}.c{{['"]*}},
+// YAML:Line: 10,
+// YAML:Column: 11 }
 // YAML: Function:foo
 // YAML: Args:
 // YAML:   - NumSpills:   '{{.}}'
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits