[PATCH] D50737: [ASTImporter] Add test for CXXNoexceptExpr

[Raphael Isemann via Phabricator via cfe-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rC340304: [ASTImporter] Add test for CXXNoexceptExpr (authored 
by teemperor, committed by ).

Repository:
  rC Clang

https://reviews.llvm.org/D50737

Files:
  test/Import/cxx-noexcept-expr/Inputs/F.cpp
  test/Import/cxx-noexcept-expr/test.cpp


Index: test/Import/cxx-noexcept-expr/test.cpp
===
--- test/Import/cxx-noexcept-expr/test.cpp
+++ test/Import/cxx-noexcept-expr/test.cpp
@@ -0,0 +1,8 @@
+// RUN: clang-import-test -dump-ast -import %S/Inputs/F.cpp -expression %s | 
FileCheck %s
+
+// CHECK: CXXNoexceptExpr
+// CHECK-NEXT: IntegerLiteral
+
+void expr() {
+  f();
+}
Index: test/Import/cxx-noexcept-expr/Inputs/F.cpp
===
--- test/Import/cxx-noexcept-expr/Inputs/F.cpp
+++ test/Import/cxx-noexcept-expr/Inputs/F.cpp
@@ -0,0 +1 @@
+bool f() { return noexcept(1); }


Index: test/Import/cxx-noexcept-expr/test.cpp
===
--- test/Import/cxx-noexcept-expr/test.cpp
+++ test/Import/cxx-noexcept-expr/test.cpp
@@ -0,0 +1,8 @@
+// RUN: clang-import-test -dump-ast -import %S/Inputs/F.cpp -expression %s | FileCheck %s
+
+// CHECK: CXXNoexceptExpr
+// CHECK-NEXT: IntegerLiteral
+
+void expr() {
+  f();
+}
Index: test/Import/cxx-noexcept-expr/Inputs/F.cpp
===
--- test/Import/cxx-noexcept-expr/Inputs/F.cpp
+++ test/Import/cxx-noexcept-expr/Inputs/F.cpp
@@ -0,0 +1 @@
+bool f() { return noexcept(1); }
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50737: [ASTImporter] Add test for CXXNoexceptExpr

[Raphael Isemann via Phabricator via cfe-commits]

teemperor added inline comments.



Comment at: test/Import/cxx-noexcept-expr/test.cpp:1
+// RUN: clang-import-test -dump-ast -import %S/Inputs/F.cpp -expression %s | 
FileCheck %s
+

hiraditya wrote:
> Can we add a line/comment to explain what this test does? Same for the input 
> files.
Well all the 'Import/' tests just try importing the respective AST 
node type and run checks on the node after importing. But we probably should 
reorganize the `test/Import` folder in the future, so then we can better 
document that the tests in the respective 'node-types` folder or so are 
supposed to do just this kind of check.


Repository:
  rC Clang

https://reviews.llvm.org/D50737



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50737: [ASTImporter] Add test for CXXNoexceptExpr

[Aleksei Sidorin via Phabricator via cfe-commits]

a_sidorin accepted this revision.
a_sidorin added a comment.
This revision is now accepted and ready to land.

Thanks!


Repository:
  rC Clang

https://reviews.llvm.org/D50737



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50737: [ASTImporter] Add test for CXXNoexceptExpr

[Aditya Kumar via Phabricator via cfe-commits]

hiraditya added inline comments.



Comment at: test/Import/cxx-noexcept-expr/test.cpp:1
+// RUN: clang-import-test -dump-ast -import %S/Inputs/F.cpp -expression %s | 
FileCheck %s
+

Can we add a line/comment to explain what this test does? Same for the input 
files.


Repository:
  rC Clang

https://reviews.llvm.org/D50737



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50737: [ASTImporter] Add test for CXXNoexceptExpr

[Raphael Isemann via Phabricator via cfe-commits]

teemperor created this revision.
Herald added a subscriber: martong.
Herald added a reviewer: a.sidorin.

Repository:
  rC Clang

https://reviews.llvm.org/D50737

Files:
  test/Import/cxx-noexcept-expr/Inputs/F.cpp
  test/Import/cxx-noexcept-expr/test.cpp


Index: test/Import/cxx-noexcept-expr/test.cpp
===
--- /dev/null
+++ test/Import/cxx-noexcept-expr/test.cpp
@@ -0,0 +1,8 @@
+// RUN: clang-import-test -dump-ast -import %S/Inputs/F.cpp -expression %s | 
FileCheck %s
+
+// CHECK: CXXNoexceptExpr
+// CHECK-NEXT: IntegerLiteral
+
+void expr() {
+  f();
+}
Index: test/Import/cxx-noexcept-expr/Inputs/F.cpp
===
--- /dev/null
+++ test/Import/cxx-noexcept-expr/Inputs/F.cpp
@@ -0,0 +1 @@
+bool f() { return noexcept(1); }


Index: test/Import/cxx-noexcept-expr/test.cpp
===
--- /dev/null
+++ test/Import/cxx-noexcept-expr/test.cpp
@@ -0,0 +1,8 @@
+// RUN: clang-import-test -dump-ast -import %S/Inputs/F.cpp -expression %s | FileCheck %s
+
+// CHECK: CXXNoexceptExpr
+// CHECK-NEXT: IntegerLiteral
+
+void expr() {
+  f();
+}
Index: test/Import/cxx-noexcept-expr/Inputs/F.cpp
===
--- /dev/null
+++ test/Import/cxx-noexcept-expr/Inputs/F.cpp
@@ -0,0 +1 @@
+bool f() { return noexcept(1); }
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits