[PATCH] D53299: [Fixed Point Arithmetic] Fix for clang-tools-extra warning

2018-10-15 Thread Leonard Chan via Phabricator via cfe-commits 
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE344549: [Fixed Point Arithmetic] Fix for clang-tools-extra 
warning (authored by leonardchan, committed by ).

Changed prior to commit:
  https://reviews.llvm.org/D53299?vs=169741=169745#toc

Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D53299

Files:
  clang-tidy/modernize/UseDefaultMemberInitCheck.cpp


Index: clang-tidy/modernize/UseDefaultMemberInitCheck.cpp
===
--- clang-tidy/modernize/UseDefaultMemberInitCheck.cpp
+++ clang-tidy/modernize/UseDefaultMemberInitCheck.cpp
@@ -60,46 +60,47 @@
   case Type::STK_IntegralComplex:
 return getValueOfValueInit(
 InitType->getAs()->getElementType());
+
   case Type::STK_FixedPoint:
 switch (InitType->getAs()->getKind()) {
-  case BuiltinType::ShortAccum:
-  case BuiltinType::SatShortAccum:
-return "0.0hk";
-  case BuiltinType::Accum:
-  case BuiltinType::SatAccum:
-return "0.0k";
-  case BuiltinType::LongAccum:
-  case BuiltinType::SatLongAccum:
-return "0.0lk";
-  case BuiltinType::UShortAccum:
-  case BuiltinType::SatUShortAccum:
-return "0.0uhk";
-  case BuiltinType::UAccum:
-  case BuiltinType::SatUAccum:
-return "0.0uk";
-  case BuiltinType::ULongAccum:
-  case BuiltinType::SatULongAccum:
-return "0.0ulk";
-  case BuiltinType::ShortFract:
-  case BuiltinType::SatShortFract:
-return "0.0hr";
-  case BuiltinType::Fract:
-  case BuiltinType::SatFract:
-return "0.0r";
-  case BuiltinType::LongFract:
-  case BuiltinType::SatLongFract:
-return "0.0lr";
-  case BuiltinType::UShortFract:
-  case BuiltinType::SatUShortFract:
-return "0.0uhr";
-  case BuiltinType::UFract:
-  case BuiltinType::SatUFract:
-return "0.0ur";
-  case BuiltinType::ULongFract:
-  case BuiltinType::SatULongFract:
-return "0.0ulr";
-  default:
-llvm_unreachable("Unhandled fixed point BuiltinType");
+case BuiltinType::ShortAccum:
+case BuiltinType::SatShortAccum:
+  return "0.0hk";
+case BuiltinType::Accum:
+case BuiltinType::SatAccum:
+  return "0.0k";
+case BuiltinType::LongAccum:
+case BuiltinType::SatLongAccum:
+  return "0.0lk";
+case BuiltinType::UShortAccum:
+case BuiltinType::SatUShortAccum:
+  return "0.0uhk";
+case BuiltinType::UAccum:
+case BuiltinType::SatUAccum:
+  return "0.0uk";
+case BuiltinType::ULongAccum:
+case BuiltinType::SatULongAccum:
+  return "0.0ulk";
+case BuiltinType::ShortFract:
+case BuiltinType::SatShortFract:
+  return "0.0hr";
+case BuiltinType::Fract:
+case BuiltinType::SatFract:
+  return "0.0r";
+case BuiltinType::LongFract:
+case BuiltinType::SatLongFract:
+  return "0.0lr";
+case BuiltinType::UShortFract:
+case BuiltinType::SatUShortFract:
+  return "0.0uhr";
+case BuiltinType::UFract:
+case BuiltinType::SatUFract:
+  return "0.0ur";
+case BuiltinType::ULongFract:
+case BuiltinType::SatULongFract:
+  return "0.0ulr";
+default:
+  llvm_unreachable("Unhandled fixed point BuiltinType");
 }
   }
   llvm_unreachable("Invalid scalar type kind");


Index: clang-tidy/modernize/UseDefaultMemberInitCheck.cpp
===
--- clang-tidy/modernize/UseDefaultMemberInitCheck.cpp
+++ clang-tidy/modernize/UseDefaultMemberInitCheck.cpp
@@ -60,46 +60,47 @@
   case Type::STK_IntegralComplex:
 return getValueOfValueInit(
 InitType->getAs()->getElementType());
+
   case Type::STK_FixedPoint:
 switch (InitType->getAs()->getKind()) {
-  case BuiltinType::ShortAccum:
-  case BuiltinType::SatShortAccum:
-return "0.0hk";
-  case BuiltinType::Accum:
-  case BuiltinType::SatAccum:
-return "0.0k";
-  case BuiltinType::LongAccum:
-  case BuiltinType::SatLongAccum:
-return "0.0lk";
-  case BuiltinType::UShortAccum:
-  case BuiltinType::SatUShortAccum:
-return "0.0uhk";
-  case BuiltinType::UAccum:
-  case BuiltinType::SatUAccum:
-return "0.0uk";
-  case BuiltinType::ULongAccum:
-  case BuiltinType::SatULongAccum:
-return "0.0ulk";
-  case BuiltinType::ShortFract:
-  case BuiltinType::SatShortFract:
-return "0.0hr";
-  case BuiltinType::Fract:
-  case BuiltinType::SatFract:
-return "0.0r";
-  case BuiltinType::LongFract:
-  case BuiltinType::SatLongFract:
-return "0.0lr";
-  case BuiltinType::UShortFract:
-  case BuiltinType::SatUShortFract:
-return "0.0uhr";
-  case BuiltinType::UFract:
-  case BuiltinType::SatUFract:
-return "0.0ur";
-  case BuiltinType::ULongFract:
-  case

[PATCH] D53299: [Fixed Point Arithmetic] Fix for clang-tools-extra warning

2018-10-15 Thread Leonard Chan via Phabricator via cfe-commits 
leonardchan updated this revision to Diff 169741.
leonardchan marked 2 inline comments as done.

Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D53299

Files:
  clang-tools-extra/clang-tidy/modernize/UseDefaultMemberInitCheck.cpp


Index: clang-tools-extra/clang-tidy/modernize/UseDefaultMemberInitCheck.cpp
===
--- clang-tools-extra/clang-tidy/modernize/UseDefaultMemberInitCheck.cpp
+++ clang-tools-extra/clang-tidy/modernize/UseDefaultMemberInitCheck.cpp
@@ -60,6 +60,48 @@
   case Type::STK_IntegralComplex:
 return getValueOfValueInit(
 InitType->getAs()->getElementType());
+
+  case Type::STK_FixedPoint:
+switch (InitType->getAs()->getKind()) {
+case BuiltinType::ShortAccum:
+case BuiltinType::SatShortAccum:
+  return "0.0hk";
+case BuiltinType::Accum:
+case BuiltinType::SatAccum:
+  return "0.0k";
+case BuiltinType::LongAccum:
+case BuiltinType::SatLongAccum:
+  return "0.0lk";
+case BuiltinType::UShortAccum:
+case BuiltinType::SatUShortAccum:
+  return "0.0uhk";
+case BuiltinType::UAccum:
+case BuiltinType::SatUAccum:
+  return "0.0uk";
+case BuiltinType::ULongAccum:
+case BuiltinType::SatULongAccum:
+  return "0.0ulk";
+case BuiltinType::ShortFract:
+case BuiltinType::SatShortFract:
+  return "0.0hr";
+case BuiltinType::Fract:
+case BuiltinType::SatFract:
+  return "0.0r";
+case BuiltinType::LongFract:
+case BuiltinType::SatLongFract:
+  return "0.0lr";
+case BuiltinType::UShortFract:
+case BuiltinType::SatUShortFract:
+  return "0.0uhr";
+case BuiltinType::UFract:
+case BuiltinType::SatUFract:
+  return "0.0ur";
+case BuiltinType::ULongFract:
+case BuiltinType::SatULongFract:
+  return "0.0ulr";
+default:
+  llvm_unreachable("Unhandled fixed point BuiltinType");
+}
   }
   llvm_unreachable("Invalid scalar type kind");
 }


Index: clang-tools-extra/clang-tidy/modernize/UseDefaultMemberInitCheck.cpp
===
--- clang-tools-extra/clang-tidy/modernize/UseDefaultMemberInitCheck.cpp
+++ clang-tools-extra/clang-tidy/modernize/UseDefaultMemberInitCheck.cpp
@@ -60,6 +60,48 @@
   case Type::STK_IntegralComplex:
 return getValueOfValueInit(
 InitType->getAs()->getElementType());
+
+  case Type::STK_FixedPoint:
+switch (InitType->getAs()->getKind()) {
+case BuiltinType::ShortAccum:
+case BuiltinType::SatShortAccum:
+  return "0.0hk";
+case BuiltinType::Accum:
+case BuiltinType::SatAccum:
+  return "0.0k";
+case BuiltinType::LongAccum:
+case BuiltinType::SatLongAccum:
+  return "0.0lk";
+case BuiltinType::UShortAccum:
+case BuiltinType::SatUShortAccum:
+  return "0.0uhk";
+case BuiltinType::UAccum:
+case BuiltinType::SatUAccum:
+  return "0.0uk";
+case BuiltinType::ULongAccum:
+case BuiltinType::SatULongAccum:
+  return "0.0ulk";
+case BuiltinType::ShortFract:
+case BuiltinType::SatShortFract:
+  return "0.0hr";
+case BuiltinType::Fract:
+case BuiltinType::SatFract:
+  return "0.0r";
+case BuiltinType::LongFract:
+case BuiltinType::SatLongFract:
+  return "0.0lr";
+case BuiltinType::UShortFract:
+case BuiltinType::SatUShortFract:
+  return "0.0uhr";
+case BuiltinType::UFract:
+case BuiltinType::SatUFract:
+  return "0.0ur";
+case BuiltinType::ULongFract:
+case BuiltinType::SatULongFract:
+  return "0.0ulr";
+default:
+  llvm_unreachable("Unhandled fixed point BuiltinType");
+}
   }
   llvm_unreachable("Invalid scalar type kind");
 }
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D53299: [Fixed Point Arithmetic] Fix for clang-tools-extra warning

2018-10-15 Thread Bjorn Pettersson via Phabricator via cfe-commits 
bjope accepted this revision.
bjope added a comment.
This revision is now accepted and ready to land.

Just some inline nit:s about whitespace.

LGTM, apart from that!




Comment at: 
clang-tools-extra/clang-tidy/modernize/UseDefaultMemberInitCheck.cpp:63
 InitType->getAs()->getElementType());
+  case Type::STK_FixedPoint:
+switch (InitType->getAs()->getKind()) {

nit: I'd add an extra line break before this line (just to follow the earlier 
style where it seems like cases are put in different groups in this switch).



Comment at: 
clang-tools-extra/clang-tidy/modernize/UseDefaultMemberInitCheck.cpp:65
+switch (InitType->getAs()->getKind()) {
+  case BuiltinType::ShortAccum:
+  case BuiltinType::SatShortAccum:

Indents: I think case should be aligned with the switch.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D53299



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits