[PATCH] D61675: [WIP] Update IRBuilder::CreateFNeg(...) to return a UnaryOperator

[Cameron McInally via Phabricator via cfe-commits]

cameron.mcinally added a comment.

Both the ASan build:

  http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/35926 

and the OCaml build:

  http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/19255 

have completed successfully with the latest patches. Will continue to monitor 
the bots for further problems.

I apologize again for the noise...

@pcc @gribozavr


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61675/new/

https://reviews.llvm.org/D61675



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D61675: [WIP] Update IRBuilder::CreateFNeg(...) to return a UnaryOperator

[Cameron McInally via Phabricator via cfe-commits]

cameron.mcinally added a comment.

Fix incoming. Sorry for not running the ASan tests...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61675/new/

https://reviews.llvm.org/D61675



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D61675: [WIP] Update IRBuilder::CreateFNeg(...) to return a UnaryOperator

[Cameron McInally via Phabricator via cfe-commits]

cameron.mcinally added a comment.

Apologies, @pcc. Looking now. Will revert if it's not obvious...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61675/new/

https://reviews.llvm.org/D61675



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D61675: [WIP] Update IRBuilder::CreateFNeg(...) to return a UnaryOperator

[Peter Collingbourne via Phabricator via cfe-commits]

pcc added a comment.

Hi, it looks like this patch has caused a test failure under asan:
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/35922/steps/check-llvm%20asan/logs/stdio
Can you please take a look?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61675/new/

https://reviews.llvm.org/D61675



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D61675: [WIP] Update IRBuilder::CreateFNeg(...) to return a UnaryOperator

[Cameron McInally via Phabricator via cfe-commits]

cameron.mcinally added a comment.

Recommitted this patch with Ocaml test fix. I was not able to find quick-start 
documentation for the Ocaml bindings, so the Ocaml failure has not been tested. 
That said, the failure mode seems extremely low risk. Will monitor the 
buildbots for problems...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61675/new/

https://reviews.llvm.org/D61675



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D61675: [WIP] Update IRBuilder::CreateFNeg(...) to return a UnaryOperator

[Cameron McInally via Phabricator via cfe-commits]

cameron.mcinally added a subscriber: RKSimon.
cameron.mcinally added a comment.

@gribozavr I see that you also reverted @RKSimon's commit for the OCaml/core.ml 
failure:

  Author: gribozavr
  Date: Thu Oct 10 07:16:58 2019
  New Revision: 374357
  
  URL: http://llvm.org/viewvc/llvm-project?rev=374357=rev
  Log:
  Revert "Fix OCaml/core.ml fneg check"
  
  This reverts commit r374346. It attempted to fix OCaml tests, but is
  does not actually fix them.
  
  Modified:
  llvm/trunk/test/Bindings/OCaml/core.ml

That appears to be the proper fix. Do you see something wrong with it that I'm 
missing?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61675/new/

https://reviews.llvm.org/D61675



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D61675: [WIP] Update IRBuilder::CreateFNeg(...) to return a UnaryOperator

[Cameron McInally via Phabricator via cfe-commits]

cameron.mcinally added a comment.

In D61675#1703749 , @cameron.mcinally 
wrote:

> > I reverted it in r374354. Please test before re-landing.
>
> Hmm, how do I run those tests? I did not see that failure with check-all.
>
> That's a pretty straightforward failure. It's just a one-line IR change:
>
> `fsub float {{.*}}0{{.*}}, %F1` -> `fneg float %F1`


@gribozavr in case not subscribed...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61675/new/

https://reviews.llvm.org/D61675



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D61675: [WIP] Update IRBuilder::CreateFNeg(...) to return a UnaryOperator

[Cameron McInally via Phabricator via cfe-commits]

cameron.mcinally added a comment.

> I reverted it in r374354. Please test before re-landing.

Hmm, how do I run those tests? I did not see that failure with check-all.

That's a pretty straightforward failure. It's just a one-line IR change:

`fsub float {{.*}}0{{.*}}, %F1` -> `fneg float %F1`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61675/new/

https://reviews.llvm.org/D61675



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D61675: [WIP] Update IRBuilder::CreateFNeg(...) to return a UnaryOperator

[Dmitri Gribenko via Phabricator via cfe-commits]

gribozavr added a comment.

Sorry, but this commit broke OCaml tests: 
http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/19014

I reverted it in r374354. Please test before re-landing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61675/new/

https://reviews.llvm.org/D61675



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits