[PATCH] D66490: [NewPM] Enable the New Pass Manager by Default in Clang

[Leonard Chan via Phabricator via cfe-commits]

leonardchan added a comment.

> It seems that we can go ahead with this patch if there's no other objections. 
> I reran a `ninja check-clang` with this patch and all tests seem to pass (at 
> least when running on x64-linux).

Actually disregard this. It seems that there are some compiler-rt tests that 
don't pass with the NPM yet (see D77249 ).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66490/new/

https://reviews.llvm.org/D66490



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D66490: [NewPM] Enable the New Pass Manager by Default in Clang

[Leonard Chan via Phabricator via cfe-commits]

leonardchan added a comment.

In D66490#1958747 , @aeubanks wrote:

> In D66490#1638708 , @hfinkel wrote:
>
> > In D66490#1638162 , @rupprecht 
> > wrote:
> >
> > > We already know that we don't want this enabled for tsan builds due to 
> > > https://bugs.llvm.org/show_bug.cgi?id=42877, but I don't even know if 
> > > anyone else will hit it (it's only when building one particular library).
> >
> >
> > Under the circumstances, that seems like one particular library too many. 
> > PR42877 looks like a generic bug, so if we're hitting it here, I see no 
> > reason to suspect that others would not hit it elsewhere.
>
>
> https://bugs.llvm.org/show_bug.cgi?id=42877 is marked fixed, any update on 
> this? LLVM 10.0.0 has branched.


It seems that we can go ahead with this patch if there's no other objections. I 
reran a `ninja check-clang` with this patch and all tests seem to pass (at 
least when running on x64-linux).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66490/new/

https://reviews.llvm.org/D66490



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D66490: [NewPM] Enable the New Pass Manager by Default in Clang

[Arthur Eubanks via Phabricator via cfe-commits]

aeubanks added a comment.

In D66490#1638708 , @hfinkel wrote:

> In D66490#1638162 , @rupprecht wrote:
>
> > We already know that we don't want this enabled for tsan builds due to 
> > https://bugs.llvm.org/show_bug.cgi?id=42877, but I don't even know if 
> > anyone else will hit it (it's only when building one particular library).
>
>
> Under the circumstances, that seems like one particular library too many. 
> PR42877 looks like a generic bug, so if we're hitting it here, I see no 
> reason to suspect that others would not hit it elsewhere.


https://bugs.llvm.org/show_bug.cgi?id=42877 is marked fixed, any update on 
this? LLVM 10.0.0 has branched.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66490/new/

https://reviews.llvm.org/D66490



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D66490: [NewPM] Enable the New Pass Manager by Default in Clang

[Hal Finkel via Phabricator via cfe-commits]

hfinkel added a comment.

In D66490#1638162 , @rupprecht wrote:

> We already know that we don't want this enabled for tsan builds due to 
> https://bugs.llvm.org/show_bug.cgi?id=42877, but I don't even know if anyone 
> else will hit it (it's only when building one particular library).


Under the circumstances, that seems like one particular library too many. 
PR42877 looks like a generic bug, so if we're hitting it here, I see no reason 
to suspect that others would not hit it elsewhere.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66490/new/

https://reviews.llvm.org/D66490



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D66490: [NewPM] Enable the New Pass Manager by Default in Clang

[Jordan Rupprecht via Phabricator via cfe-commits]

rupprecht added a comment.

We already know that we don't want this enabled for tsan builds due to 
https://bugs.llvm.org/show_bug.cgi?id=42877, but I don't even know if anyone 
else will hit it (it's only when building one particular library).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66490/new/

https://reviews.llvm.org/D66490



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D66490: [NewPM] Enable the New Pass Manager by Default in Clang

[Leonard Chan via Phabricator via cfe-commits]

leonardchan added a comment.

As of now, from running `check-llvm` and `check-clang` there's 2 failing tests, 
but I'm trying to get those addressed.

- `Clang :: CodeGen/split-lto-unit.c` which should be resolved by D66488 

- `Clang :: CodeGenCXX/ubsan-coroutines.cpp` which was introduced by D44672 
 but I think should be fixed by just disabling 
the test under the new PM since coroutines haven't been ported yet.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66490/new/

https://reviews.llvm.org/D66490



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D66490: [NewPM] Enable the New Pass Manager by Default in Clang

[Leonard Chan via Phabricator via cfe-commits]

leonardchan created this revision.
leonardchan added reviewers: chandlerc, echristo, hfinkel, lattner, rupprecht.
leonardchan added a project: clang.
Herald added subscribers: dexonsmith, mehdi_amini, mgorny.

The new PM serves as a replacement for the legacy PM, and promises better 
codegen, better inlining, faster build times, and better PGO and LTO.  Now that 
LLVM 9.0.0 has branched, we have some time before the next release to work out 
any kinks that may arise from the switch.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D66490

Files:
  clang/CMakeLists.txt


Index: clang/CMakeLists.txt
===
--- clang/CMakeLists.txt
+++ clang/CMakeLists.txt
@@ -233,7 +233,7 @@
 set(ENABLE_X86_RELAX_RELOCATIONS OFF CACHE BOOL
 "enable x86 relax relocations by default")
 
-set(ENABLE_EXPERIMENTAL_NEW_PASS_MANAGER FALSE CACHE BOOL
+set(ENABLE_EXPERIMENTAL_NEW_PASS_MANAGER TRUE CACHE BOOL
   "Enable the experimental new pass manager by default.")
 
 # TODO: verify the values against LangStandards.def?


Index: clang/CMakeLists.txt
===
--- clang/CMakeLists.txt
+++ clang/CMakeLists.txt
@@ -233,7 +233,7 @@
 set(ENABLE_X86_RELAX_RELOCATIONS OFF CACHE BOOL
 "enable x86 relax relocations by default")
 
-set(ENABLE_EXPERIMENTAL_NEW_PASS_MANAGER FALSE CACHE BOOL
+set(ENABLE_EXPERIMENTAL_NEW_PASS_MANAGER TRUE CACHE BOOL
   "Enable the experimental new pass manager by default.")
 
 # TODO: verify the values against LangStandards.def?
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits