[PATCH] D70355: [clang-format] [NFC] add recent changes to release notes

2019-11-19 Thread MyDeveloperDay via Phabricator via cfe-commits 
This revision was automatically updated to reflect the committed changes.
Closed by commit rG8b5f6c16476c: [clang-format] [NFC] add recent changes to 
release notes (authored by MyDeveloperDay).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70355/new/

https://reviews.llvm.org/D70355

Files:
  clang/docs/ReleaseNotes.rst


Index: clang/docs/ReleaseNotes.rst
===
--- clang/docs/ReleaseNotes.rst
+++ clang/docs/ReleaseNotes.rst
@@ -58,7 +58,7 @@
   access to determine if two operand expressions are the same.
 - -Wtautological-bitwise-compare is a new warning group.  This group has the
   current warning which diagnoses the tautological comparison of a bitwise
-  operation and a constant.  The group also has the new warning which diagnoses
+  operation and a constant. The group also has the new warning which diagnoses
   when a bitwise-or with a non-negative value is converted to a bool, since
   that bool will always be true.
 - -Wbitwise-conditional-parentheses will warn on operator precedence issues
@@ -138,9 +138,6 @@
 
 error LNK2005: "bool const std::_Is_integral" 
(??$_Is_integral@H@std@@3_NB) already defined
 
-
-
-
 C Language Changes in Clang
 ---
 
@@ -296,13 +293,16 @@
   - ``Auto`` is the default and detects style from the code (this is 
unchanged).
 
   The previous values of ``Cpp03`` and ``Cpp11`` are deprecated. Note that
-  ``Cpp11`` is treated as ``Latest``, as this was always clang-format's 
behavior.
-  (One motivation for this change is the new name describes the behavior 
better).
+  ``Cpp11`` is treated as ``Latest``, as this was always clang-format's
+  behavior. (One motivation for this change is the new name describes the
+  behavior better).
 
-- clang-format gets a new option called ``--dry-run`` or ``-n`` to emit a
-  warning.
+- Clang-format has a new option called ``--dry-run`` or ``-n`` to emit a
+  warning for clang-format violations. This can be used together
+  with --ferror-limit=N to limit the number of warnings per file and --Werror
+  to make warnings into errors.
 
-- Option *IncludeIsMainSourceRegex* added to allow for additional
+- Option *IncludeIsMainSourceRegex* has been added to allow for additional
   suffixes and file extensions to be considered as a source file
   for execution of logic that looks for "main *include* file" to put
   it on top.
@@ -311,7 +311,7 @@
   they end with: ``.c``, ``.cc``, ``.cpp``, ``.c++``, ``.cxx``,
   ``.m`` or ``.mm`` extensions. This config option allows to
   extend this set of source files considered as "main".
-
+
   For example, if this option is configured to ``(Impl\.hpp)$``,
   then a file ``ClassImpl.hpp`` is considered "main" (in addition to
   ``Class.c``, ``Class.cc``, ``Class.cpp`` and so on) and "main
@@ -320,12 +320,31 @@
   ``ClassImpl.hpp`` would not have the main include file put on top
   before any other include.
 
+- Options ``DeriveLineEnding`` and  ``UseCRLF`` have been added to allow
+  clang-format to control the newlines. ``DeriveLineEnding`` is by default
+  ``true`` and reflects is the existing mechanism, which based is on majority
+  rule. The new options allows this to be turned off and ``UseCRLF`` to control
+  the decision as to which sort of line ending to use.
+
+- Option ``SpaceBeforeSquareBrackets`` has been added to insert a space before
+  array declarations.
+
+  .. code-block:: c++
+
+int a [5];vsint a[5];
+
+- Clang-format now supports JavaScript null operators.
+
+  .. code-block:: c++
+
+const x = foo ?? default;
+const z = foo?.bar?.baz;
+
 libclang
 
 
 - ...
 
-
 Static Analyzer
 ---
 
@@ -373,7 +392,6 @@
 return getelementpointer_inbounds(base, offset);
   }
 
-
 Core Analysis Improvements
 ==
 


Index: clang/docs/ReleaseNotes.rst
===
--- clang/docs/ReleaseNotes.rst
+++ clang/docs/ReleaseNotes.rst
@@ -58,7 +58,7 @@
   access to determine if two operand expressions are the same.
 - -Wtautological-bitwise-compare is a new warning group.  This group has the
   current warning which diagnoses the tautological comparison of a bitwise
-  operation and a constant.  The group also has the new warning which diagnoses
+  operation and a constant. The group also has the new warning which diagnoses
   when a bitwise-or with a non-negative value is converted to a bool, since
   that bool will always be true.
 - -Wbitwise-conditional-parentheses will warn on operator precedence issues
@@ -138,9 +138,6 @@
 
 error LNK2005: "bool const std::_Is_integral" (??$_Is_integral@H@std@@3_NB) already defined
 
-
-
-
 C Language Changes in Clang
 ---
 
@@ -296,13 +293,16 @@
   - ``Auto`` is the default and detects style from the code (this is unchanged).
 
   The previous values of ``Cpp03`` and `

[PATCH] D70355: [clang-format] [NFC] add recent changes to release notes

2019-11-18 Thread Mitchell via Phabricator via cfe-commits 
mitchell-stellar accepted this revision.
mitchell-stellar added a comment.
This revision is now accepted and ready to land.

LGTM


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70355/new/

https://reviews.llvm.org/D70355



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D70355: [clang-format] [NFC] add recent changes to release notes

2019-11-16 Thread MyDeveloperDay via Phabricator via cfe-commits 
MyDeveloperDay created this revision.
MyDeveloperDay added reviewers: klimek, mitchell-stellar, sylvestre.ledru, 
sammccall.
MyDeveloperDay added projects: clang-format, clang.
MyDeveloperDay added a subscriber: Eugene.Zelenko.
MyDeveloperDay added a comment.

@Eugene.Zelenko I've noticed you are always giving excellent review feedback in 
clang-tidy especially around the documentation, I'd appreciate your eyes on 
finding the right level of documentation here.


clang-tidy keeps nice release notes of what is added, have clang-format didn't 
do the same.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D70355

Files:
  clang/docs/ReleaseNotes.rst


Index: clang/docs/ReleaseNotes.rst
===
--- clang/docs/ReleaseNotes.rst
+++ clang/docs/ReleaseNotes.rst
@@ -319,6 +319,28 @@
   ``ClassImpl.hpp`` would not have the main include file put on top
   before any other include.
 
+- Options and ``DeriveLineEnding`` and  ``UseCRLF`` added to allow 
+  clang-format to control the newlines, ``DeriveLineEnding`` is by default 
+  ``true`` and reflects is the existing mechanism, which based is on majority
+  rule. The new options allows this to be turned off and UseCRLF to control 
+  the decision as to which sort of line ending to use.
+
+- Option ``SpaceBeforeSquareBrackets`` added to allow for a space before
+  array declarations.
+
+  .. code-block:: c++
+
+int a [5];vsint a[5];
+
+
+- Clang-format now supports JavaScript null operators.
+
+  .. code-block:: c++
+
+const x = foo ?? default;
+const z = foo?.bar?.baz;
+
+
 libclang
 
 


Index: clang/docs/ReleaseNotes.rst
===
--- clang/docs/ReleaseNotes.rst
+++ clang/docs/ReleaseNotes.rst
@@ -319,6 +319,28 @@
   ``ClassImpl.hpp`` would not have the main include file put on top
   before any other include.
 
+- Options and ``DeriveLineEnding`` and  ``UseCRLF`` added to allow 
+  clang-format to control the newlines, ``DeriveLineEnding`` is by default 
+  ``true`` and reflects is the existing mechanism, which based is on majority
+  rule. The new options allows this to be turned off and UseCRLF to control 
+  the decision as to which sort of line ending to use.
+
+- Option ``SpaceBeforeSquareBrackets`` added to allow for a space before
+  array declarations.
+
+  .. code-block:: c++
+
+int a [5];vsint a[5];
+
+
+- Clang-format now supports JavaScript null operators.
+
+  .. code-block:: c++
+
+const x = foo ?? default;
+const z = foo?.bar?.baz;
+
+
 libclang
 
 
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D70355: [clang-format] [NFC] add recent changes to release notes

2019-11-16 Thread Eugene Zelenko via Phabricator via cfe-commits 
Eugene.Zelenko added a comment.

General comments:

- Isn't //Option(s) ... was/were added// or //Option(s) ... had been added// 
are more correct from from point of view of English grammar? Same for older 
entries.
- It'll be great to nag developers to expand Release Notes when relevant code 
changes are made.




Comment at: clang/docs/ReleaseNotes.rst:322
 
+- Options and ``DeriveLineEnding`` and  ``UseCRLF`` added to allow 
+  clang-format to control the newlines, ``DeriveLineEnding`` is by default 

and between Options and DeriveLineEnding are not necessary.



Comment at: clang/docs/ReleaseNotes.rst:323
+- Options and ``DeriveLineEnding`` and  ``UseCRLF`` added to allow 
+  clang-format to control the newlines, ``DeriveLineEnding`` is by default 
+  ``true`` and reflects is the existing mechanism, which based is on majority

I would suggest to use dot after newlines.



Comment at: clang/docs/ReleaseNotes.rst:325
+  ``true`` and reflects is the existing mechanism, which based is on majority
+  rule. The new options allows this to be turned off and UseCRLF to control 
+  the decision as to which sort of line ending to use.

UseCRLF should be enclosed in double back-ticks.



Comment at: clang/docs/ReleaseNotes.rst:328
+
+- Option ``SpaceBeforeSquareBrackets`` added to allow for a space before
+  array declarations.

to //insert//?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70355/new/

https://reviews.llvm.org/D70355



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D70355: [clang-format] [NFC] add recent changes to release notes

2019-11-16 Thread MyDeveloperDay via Phabricator via cfe-commits 
MyDeveloperDay added a subscriber: Eugene.Zelenko.
MyDeveloperDay added a comment.

@Eugene.Zelenko I've noticed you are always giving excellent review feedback in 
clang-tidy especially around the documentation, I'd appreciate your eyes on 
finding the right level of documentation here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70355/new/

https://reviews.llvm.org/D70355



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D70355: [clang-format] [NFC] add recent changes to release notes

2019-11-16 Thread pre-merge checks [bot] via Phabricator via cfe-commits 
merge_guards_bot added a comment.

Build result: pass - 60143 tests passed, 0 failed and 729 were skipped.
Log files: console-log.txt 
,
 CMakeCache.txt 



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70355/new/

https://reviews.llvm.org/D70355



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D70355: [clang-format] [NFC] add recent changes to release notes

2019-11-16 Thread MyDeveloperDay via Phabricator via cfe-commits 
MyDeveloperDay updated this revision to Diff 229690.
MyDeveloperDay added a comment.

Address review comments
Remove excessive newlines
Remove trailing whitespace


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70355/new/

https://reviews.llvm.org/D70355

Files:
  clang/docs/ReleaseNotes.rst


Index: clang/docs/ReleaseNotes.rst
===
--- clang/docs/ReleaseNotes.rst
+++ clang/docs/ReleaseNotes.rst
@@ -58,7 +58,7 @@
   access to determine if two operand expressions are the same.
 - -Wtautological-bitwise-compare is a new warning group.  This group has the
   current warning which diagnoses the tautological comparison of a bitwise
-  operation and a constant.  The group also has the new warning which diagnoses
+  operation and a constant. The group also has the new warning which diagnoses
   when a bitwise-or with a non-negative value is converted to a bool, since
   that bool will always be true.
 - -Wbitwise-conditional-parentheses will warn on operator precedence issues
@@ -137,9 +137,6 @@
 
 error LNK2005: "bool const std::_Is_integral" 
(??$_Is_integral@H@std@@3_NB) already defined
 
-
-
-
 C Language Changes in Clang
 ---
 
@@ -295,13 +292,16 @@
   - ``Auto`` is the default and detects style from the code (this is 
unchanged).
 
   The previous values of ``Cpp03`` and ``Cpp11`` are deprecated. Note that
-  ``Cpp11`` is treated as ``Latest``, as this was always clang-format's 
behavior.
-  (One motivation for this change is the new name describes the behavior 
better).
+  ``Cpp11`` is treated as ``Latest``, as this was always clang-format's
+  behavior. (One motivation for this change is the new name describes the
+  behavior better).
 
-- clang-format gets a new option called ``--dry-run`` or ``-n`` to emit a
-  warning.
+- Clang-format has a new option called ``--dry-run`` or ``-n`` to emit a
+  warning for clang-format violations. This can be used together
+  with --ferror-limit=N to limit the number of warnings per file and --Werror
+  to make warnings into errors.
 
-- Option *IncludeIsMainSourceRegex* added to allow for additional
+- Option *IncludeIsMainSourceRegex* has been added to allow for additional
   suffixes and file extensions to be considered as a source file
   for execution of logic that looks for "main *include* file" to put
   it on top.
@@ -310,7 +310,7 @@
   they end with: ``.c``, ``.cc``, ``.cpp``, ``.c++``, ``.cxx``,
   ``.m`` or ``.mm`` extensions. This config option allows to
   extend this set of source files considered as "main".
-
+
   For example, if this option is configured to ``(Impl\.hpp)$``,
   then a file ``ClassImpl.hpp`` is considered "main" (in addition to
   ``Class.c``, ``Class.cc``, ``Class.cpp`` and so on) and "main
@@ -319,12 +319,31 @@
   ``ClassImpl.hpp`` would not have the main include file put on top
   before any other include.
 
+- Options ``DeriveLineEnding`` and  ``UseCRLF`` have been added to allow
+  clang-format to control the newlines. ``DeriveLineEnding`` is by default
+  ``true`` and reflects is the existing mechanism, which based is on majority
+  rule. The new options allows this to be turned off and ``UseCRLF`` to control
+  the decision as to which sort of line ending to use.
+
+- Option ``SpaceBeforeSquareBrackets`` has been added to insert a space before
+  array declarations.
+
+  .. code-block:: c++
+
+int a [5];vsint a[5];
+
+- Clang-format now supports JavaScript null operators.
+
+  .. code-block:: c++
+
+const x = foo ?? default;
+const z = foo?.bar?.baz;
+
 libclang
 
 
 - ...
 
-
 Static Analyzer
 ---
 
@@ -372,7 +391,6 @@
 return getelementpointer_inbounds(base, offset);
   }
 
-
 Core Analysis Improvements
 ==
 


Index: clang/docs/ReleaseNotes.rst
===
--- clang/docs/ReleaseNotes.rst
+++ clang/docs/ReleaseNotes.rst
@@ -58,7 +58,7 @@
   access to determine if two operand expressions are the same.
 - -Wtautological-bitwise-compare is a new warning group.  This group has the
   current warning which diagnoses the tautological comparison of a bitwise
-  operation and a constant.  The group also has the new warning which diagnoses
+  operation and a constant. The group also has the new warning which diagnoses
   when a bitwise-or with a non-negative value is converted to a bool, since
   that bool will always be true.
 - -Wbitwise-conditional-parentheses will warn on operator precedence issues
@@ -137,9 +137,6 @@
 
 error LNK2005: "bool const std::_Is_integral" (??$_Is_integral@H@std@@3_NB) already defined
 
-
-
-
 C Language Changes in Clang
 ---
 
@@ -295,13 +292,16 @@
   - ``Auto`` is the default and detects style from the code (this is unchanged).
 
   The previous values of ``Cpp03`` and ``Cpp11`` are deprecated. Note that
-  ``Cpp11`` is treated as ``Latest