[PATCH] D72560: Add -Wrange-loop-analysis changes to ReleaseNotes
Mordante closed this revision. Mordante added a comment. Committed as https://reviews.llvm.org/rGdc422e968e73790178e500f506e8fb7cfa1e62ea I accidentally forgot to add the revision id. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72560/new/ https://reviews.llvm.org/D72560 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D72560: Add -Wrange-loop-analysis changes to ReleaseNotes
Mordante marked 2 inline comments as done. Mordante added a comment. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72560/new/ https://reviews.llvm.org/D72560 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D72560: Add -Wrange-loop-analysis changes to ReleaseNotes
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with some suggestions. Comment at: clang/docs/ReleaseNotes.rst:69 + copy being made when the result is bound to an rvalue reference. It no longer + warns when an object of a small trivially copyable type is copied. The + warning now offers fixits. small trivially copyable -> small, trivially copyable Comment at: clang/docs/ReleaseNotes.rst:71 + warning now offers fixits. +- -Wrange-loop-analysis is now part of -Wall. I'd fold this in to the previous bullet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72560/new/ https://reviews.llvm.org/D72560 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D72560: Add -Wrange-loop-analysis changes to ReleaseNotes
merge_guards_bot added a comment.
{icon check-circle color=green} Unit tests: pass. 61772 tests passed, 0 failed
and 780 were skipped.
{icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings
.
{icon check-circle color=green} clang-format: pass.
Build artifacts
:
diff.json
,
clang-tidy.txt
,
clang-format.patch
,
CMakeCache.txt
,
console-log.txt
,
test-results.xml
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72560/new/
https://reviews.llvm.org/D72560
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D72560: Add -Wrange-loop-analysis changes to ReleaseNotes
Mordante created this revision. Mordante added reviewers: aaron.ballman, xbolva00. Mordante added a project: clang. This reflects the recent changes done. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D72560 Files: clang/docs/ReleaseNotes.rst Index: clang/docs/ReleaseNotes.rst === --- clang/docs/ReleaseNotes.rst +++ clang/docs/ReleaseNotes.rst @@ -64,6 +64,11 @@ - -Wbitwise-conditional-parentheses will warn on operator precedence issues when mixing bitwise-and (&) and bitwise-or (|) operator with the conditional operator (?:). +- -Wrange-loop-analysis got several improvements. It no longer warns about a + copy being made when the result is bound to an rvalue reference. It no longer + warns when an object of a small trivially copyable type is copied. The + warning now offers fixits. +- -Wrange-loop-analysis is now part of -Wall. Non-comprehensive list of changes in this release - Index: clang/docs/ReleaseNotes.rst === --- clang/docs/ReleaseNotes.rst +++ clang/docs/ReleaseNotes.rst @@ -64,6 +64,11 @@ - -Wbitwise-conditional-parentheses will warn on operator precedence issues when mixing bitwise-and (&) and bitwise-or (|) operator with the conditional operator (?:). +- -Wrange-loop-analysis got several improvements. It no longer warns about a + copy being made when the result is bound to an rvalue reference. It no longer + warns when an object of a small trivially copyable type is copied. The + warning now offers fixits. +- -Wrange-loop-analysis is now part of -Wall. Non-comprehensive list of changes in this release - ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
