[PATCH] D72825: [NFC] Fix options name typo

[Fangrui Song via Phabricator via cfe-commits]

MaskRay added a comment.

> These three options may be used in other projects compiled by gcc.

We can add them on demand. I don't see a rationale to add them preemptively.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72825/new/

https://reviews.llvm.org/D72825



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D72825: [NFC] Fix options name typo

[Jim Lin via Phabricator via cfe-commits]

Jim added a comment.

It should be kept for compatibility. These three options may be used in other 
projects compiled by gcc.
Clang should ignore it.
https://gcc.gnu.org/onlinedocs/gcc/Optimize-Options.html


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72825/new/

https://reviews.llvm.org/D72825



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D72825: [NFC] Fix options name typo

[Fangrui Song via Phabricator via cfe-commits]

MaskRay added a comment.

Can we just delete the options?

The misspelled options were added in rC214906 
 to work around 
https://clang.debian.net/status.php?version=3.4.2=UNKNOWN_ARG . Actually 
the `-ftree*` options were not used. Apparently our option names has been wrong 
for 5 years and nobody complains.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72825/new/

https://reviews.llvm.org/D72825



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D72825: [NFC] Fix options name typo

[Jim Lin via Phabricator via cfe-commits]

Jim created this revision.
Jim added reviewers: efriedma, MaskRay.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Jim edited the summary of this revision.

1. -ftree_loop_im -> -ftree-loop-im
2. -ftree_loop_ivcanon -> -ftree-loop-ivcanon
3. -ftree_loop_linear -> -ftree-loop-linear


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D72825

Files:
  clang/include/clang/Driver/Options.td
  clang/test/Driver/clang_f_opts.c


Index: clang/test/Driver/clang_f_opts.c
===
--- clang/test/Driver/clang_f_opts.c
+++ clang/test/Driver/clang_f_opts.c
@@ -292,9 +292,9 @@
 // RUN: -frename-registers\
 // RUN: -fschedule-insns2 \
 // RUN: -fsingle-precision-constant   \
-// RUN: -ftree_loop_im\
-// RUN: -ftree_loop_ivcanon   \
-// RUN: -ftree_loop_linear\
+// RUN: -ftree-loop-im\
+// RUN: -ftree-loop-ivcanon   \
+// RUN: -ftree-loop-linear\
 // RUN: -funsafe-loop-optimizations   \
 // RUN: -fuse-linker-plugin   \
 // RUN: -fvect-cost-model \
@@ -432,9 +432,9 @@
 // CHECK-WARNING-DAG: optimization flag '-frename-registers' is not supported
 // CHECK-WARNING-DAG: optimization flag '-fschedule-insns2' is not supported
 // CHECK-WARNING-DAG: optimization flag '-fsingle-precision-constant' is not 
supported
-// CHECK-WARNING-DAG: optimization flag '-ftree_loop_im' is not supported
-// CHECK-WARNING-DAG: optimization flag '-ftree_loop_ivcanon' is not supported
-// CHECK-WARNING-DAG: optimization flag '-ftree_loop_linear' is not supported
+// CHECK-WARNING-DAG: optimization flag '-ftree-loop-im' is not supported
+// CHECK-WARNING-DAG: optimization flag '-ftree-loop-ivcanon' is not supported
+// CHECK-WARNING-DAG: optimization flag '-ftree-loop-linear' is not supported
 // CHECK-WARNING-DAG: optimization flag '-funsafe-loop-optimizations' is not 
supported
 // CHECK-WARNING-DAG: optimization flag '-fuse-linker-plugin' is not supported
 // CHECK-WARNING-DAG: optimization flag '-fvect-cost-model' is not supported
Index: clang/include/clang/Driver/Options.td
===
--- clang/include/clang/Driver/Options.td
+++ clang/include/clang/Driver/Options.td
@@ -3297,9 +3297,9 @@
 defm tls_model : BooleanFFlag<"tls-model">, Group;
 defm tracer : BooleanFFlag<"tracer">, 
Group;
 defm tree_dce : BooleanFFlag<"tree-dce">, 
Group;
-defm tree_loop_im : BooleanFFlag<"tree_loop_im">,  
Group;
-defm tree_loop_ivcanon : BooleanFFlag<"tree_loop_ivcanon">,  
Group;
-defm tree_loop_linear : BooleanFFlag<"tree_loop_linear">,  
Group;
+defm tree_loop_im : BooleanFFlag<"tree-loop-im">,  
Group;
+defm tree_loop_ivcanon : BooleanFFlag<"tree-loop-ivcanon">,  
Group;
+defm tree_loop_linear : BooleanFFlag<"tree-loop-linear">,  
Group;
 defm tree_salias : BooleanFFlag<"tree-salias">, Group;
 defm tree_ter : BooleanFFlag<"tree-ter">, 
Group;
 defm tree_vectorizer_verbose : BooleanFFlag<"tree-vectorizer-verbose">, 
Group;


Index: clang/test/Driver/clang_f_opts.c
===
--- clang/test/Driver/clang_f_opts.c
+++ clang/test/Driver/clang_f_opts.c
@@ -292,9 +292,9 @@
 // RUN: -frename-registers\
 // RUN: -fschedule-insns2 \
 // RUN: -fsingle-precision-constant   \
-// RUN: -ftree_loop_im\
-// RUN: -ftree_loop_ivcanon   \
-// RUN: -ftree_loop_linear\
+// RUN: -ftree-loop-im\
+// RUN: -ftree-loop-ivcanon   \
+// RUN: -ftree-loop-linear\
 // RUN: -funsafe-loop-optimizations   \
 // RUN: -fuse-linker-plugin   \
 // RUN: -fvect-cost-model \
@@ -432,9 +432,9 @@
 // CHECK-WARNING-DAG: optimization flag '-frename-registers' is not supported
 // CHECK-WARNING-DAG: optimization flag '-fschedule-insns2' is not supported
 // CHECK-WARNING-DAG: optimization flag '-fsingle-precision-constant' is