[PATCH] D74025: [clangd] Add the missing elaborated types in FindTarget.

[Haojian Wu via Phabricator via cfe-commits]

hokein added a comment.

These changes look reasonable to me, thanks!
Here is a list of commits that we plan to cherrypick, see 
https://github.com/clangd/clangd/issues/417.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74025/new/

https://reviews.llvm.org/D74025



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D74025: [clangd] Add the missing elaborated types in FindTarget.

[Sam McCall via Phabricator via cfe-commits]

sammccall added a comment.

@jaafar Thanks for the list, this is really useful for us. These all look 
reasonable to me, I've filed bugs to track them and if they look good to 
Haojian too we'll get them merged. See 
https://github.com/clangd/clangd/issues?q=is%3Aissue+label%3Acherrypick

I've added an issue template to the clangd bugtracker, in case you find more 
such things in the future: https://github.com/clangd/clangd/issues/new/choose.

Regarding the stalled D74731 , I'll try to get 
some version of that committed so we can cherrypick it too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74025/new/

https://reviews.llvm.org/D74025



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D74025: [clangd] Add the missing elaborated types in FindTarget.

[Jeff Trull via Phabricator via cfe-commits]

jaafar added a comment.

Thnaks very much @hokein . The ones I need are:
9a5c448a31bacc08e73fcae4636094f9b6e2be6a 

eaf0c89ec5f866b6cef296c542c030bb2cf8481d 

d66afd6dde542dc373f87e07fe764c071fe20d76 

as well as this patch, under review but dormant since February: 
https://reviews.llvm.org/D74731

With these fixes I have a pleasant experience on my large codebases. Thanks for 
your help.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74025/new/

https://reviews.llvm.org/D74025



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D74025: [clangd] Add the missing elaborated types in FindTarget.

[Haojian Wu via Phabricator via cfe-commits]

hokein added a comment.

In D74025#2076704 , @jaafar wrote:

> Thank you. I'm trying to balance stability with getting the fixes I need and 
> so have been avoiding the "bleeding edge". I find that unfortunately the 
> newest code tends to be "unstable", as those releases are rightfully named, 
> and I need clangd for my daily work.


Understood.

> There are three commits, including this one, without which clangd cannot run 
> for more than 10 or 20 seconds. They have all been in the codebase for 
> several months now.  I would be happy to provide a list. Thanks again.

I will come up with a list, it would be nice if you can provide a list of 
commits, to make sure nothing left out.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74025/new/

https://reviews.llvm.org/D74025



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D74025: [clangd] Add the missing elaborated types in FindTarget.

[Jeff Trull via Phabricator via cfe-commits]

jaafar added a comment.

Thank you. I'm trying to balance stability with getting the fixes I need and so 
have been avoiding the "bleeding edge". I find that unfortunately the newest 
code tends to be "unstable", as those releases are rightfully named, and I need 
clangd for my daily work.

There are three commits, including this one, without which clangd cannot run 
for more than 10 or 20 seconds. They have all been in the codebase for several 
months now.  I would be happy to provide a list. Thanks again.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74025/new/

https://reviews.llvm.org/D74025



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D74025: [clangd] Add the missing elaborated types in FindTarget.

[Haojian Wu via Phabricator via cfe-commits]

hokein added a comment.

In D74025#2073946 , @jaafar wrote:

> I'm very happy this fix exists. I see it's in master, but not in 10.0.0 or 
> 10.0.1-rc1 either. Is there any chance it can be released?


unfortunately, it is not picked up in 10.0.0 release, but it is possible to get 
it in 10.0.1-rc1. We also have a few other crash fixes.
btw, we have weekly snapshot for clangd, 
https://github.com/clangd/clangd/releases, it contains latest fixes and 
features.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74025/new/

https://reviews.llvm.org/D74025



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D74025: [clangd] Add the missing elaborated types in FindTarget.

[Jeff Trull via Phabricator via cfe-commits]

jaafar added a comment.

I'm very happy this fix exists. I see it's in master, but not in 10.0.0 or 
10.0.1-rc1 either. Is there any chance it can be released?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74025/new/

https://reviews.llvm.org/D74025



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D74025: [clangd] Add the missing elaborated types in FindTarget.

[Haojian Wu via Phabricator via cfe-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rGeaf0c89ec5f8: [clangd] Add the missing elaborated types in 
FindTarget. (authored by hokein).

Changed prior to commit:
  https://reviews.llvm.org/D74025?vs=242524=242566#toc

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74025/new/

https://reviews.llvm.org/D74025

Files:
  clang-tools-extra/clangd/FindTarget.cpp
  clang-tools-extra/clangd/unittests/FindTargetTests.cpp


Index: clang-tools-extra/clangd/unittests/FindTargetTests.cpp
===
--- clang-tools-extra/clangd/unittests/FindTargetTests.cpp
+++ clang-tools-extra/clangd/unittests/FindTargetTests.cpp
@@ -241,6 +241,13 @@
   )cpp";
   EXPECT_DECLS("TypedefTypeLoc", {"typedef S X", Rel::Alias},
{"struct S", Rel::Underlying});
+  Code = R"cpp(
+namespace ns { struct S{}; }
+typedef ns::S X;
+[[X]] x;
+  )cpp";
+  EXPECT_DECLS("TypedefTypeLoc", {"typedef ns::S X", Rel::Alias},
+   {"struct S", Rel::Underlying});
 
   // FIXME: Auto-completion in a template requires disabling delayed template
   // parsing.
Index: clang-tools-extra/clangd/FindTarget.cpp
===
--- clang-tools-extra/clangd/FindTarget.cpp
+++ clang-tools-extra/clangd/FindTarget.cpp
@@ -379,6 +379,10 @@
 Outer.add(TT->getAsTagDecl(), Flags);
   }
 
+  void VisitElaboratedType(const ElaboratedType *ET) {
+Outer.add(ET->desugar(), Flags);
+  }
+
   void VisitInjectedClassNameType(const InjectedClassNameType *ICNT) {
 Outer.add(ICNT->getDecl(), Flags);
   }


Index: clang-tools-extra/clangd/unittests/FindTargetTests.cpp
===
--- clang-tools-extra/clangd/unittests/FindTargetTests.cpp
+++ clang-tools-extra/clangd/unittests/FindTargetTests.cpp
@@ -241,6 +241,13 @@
   )cpp";
   EXPECT_DECLS("TypedefTypeLoc", {"typedef S X", Rel::Alias},
{"struct S", Rel::Underlying});
+  Code = R"cpp(
+namespace ns { struct S{}; }
+typedef ns::S X;
+[[X]] x;
+  )cpp";
+  EXPECT_DECLS("TypedefTypeLoc", {"typedef ns::S X", Rel::Alias},
+   {"struct S", Rel::Underlying});
 
   // FIXME: Auto-completion in a template requires disabling delayed template
   // parsing.
Index: clang-tools-extra/clangd/FindTarget.cpp
===
--- clang-tools-extra/clangd/FindTarget.cpp
+++ clang-tools-extra/clangd/FindTarget.cpp
@@ -379,6 +379,10 @@
 Outer.add(TT->getAsTagDecl(), Flags);
   }
 
+  void VisitElaboratedType(const ElaboratedType *ET) {
+Outer.add(ET->desugar(), Flags);
+  }
+
   void VisitInjectedClassNameType(const InjectedClassNameType *ICNT) {
 Outer.add(ICNT->getDecl(), Flags);
   }
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D74025: [clangd] Add the missing elaborated types in FindTarget.

[pre-merge checks [bot] via Phabricator via cfe-commits]

merge_guards_bot added a comment.

{icon check-circle color=green} Unit tests: pass. 62441 tests passed, 0 failed 
and 845 were skipped.

{icon check-circle color=green} clang-tidy: pass.

{icon times-circle color=red} clang-format: fail. Please format your changes 
with clang-format by running `git-clang-format HEAD^` or applying this patch 
.

Build artifacts 
: 
diff.json 
,
 clang-tidy.txt 
,
 clang-format.patch 
,
 CMakeCache.txt 
,
 console-log.txt 
,
 test-results.xml 


//Pre-merge checks is in beta. Report issue 
.
 Please join beta  or enable 
it for your project 
.//


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74025/new/

https://reviews.llvm.org/D74025



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D74025: [clangd] Add the missing elaborated types in FindTarget.

[Haojian Wu via Phabricator via cfe-commits]

hokein created this revision.
hokein added a reviewer: sammccall.
Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay, 
ilya-biryukov.
Herald added a project: clang.

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D74025

Files:
  clang-tools-extra/clangd/FindTarget.cpp
  clang-tools-extra/clangd/unittests/FindTargetTests.cpp


Index: clang-tools-extra/clangd/unittests/FindTargetTests.cpp
===
--- clang-tools-extra/clangd/unittests/FindTargetTests.cpp
+++ clang-tools-extra/clangd/unittests/FindTargetTests.cpp
@@ -241,6 +241,13 @@
   )cpp";
   EXPECT_DECLS("TypedefTypeLoc", {"typedef S X", Rel::Alias},
{"struct S", Rel::Underlying});
+  Code = R"cpp(
+namespace ns { struct S{}; }
+typedef ns::S X;
+[[X]] x;
+  )cpp";
+  EXPECT_DECLS("TypedefTypeLoc", {"typedef ns::S X", Rel::Alias},
+   {"struct S", Rel::Underlying});
 
   // FIXME: Auto-completion in a template requires disabling delayed template
   // parsing.
Index: clang-tools-extra/clangd/FindTarget.cpp
===
--- clang-tools-extra/clangd/FindTarget.cpp
+++ clang-tools-extra/clangd/FindTarget.cpp
@@ -379,6 +379,10 @@
 Outer.add(TT->getAsTagDecl(), Flags);
   }
 
+  void VisitElaboratedType(const ElaboratedType* ET) {
+Outer.add(ET->desugar(), Flags);
+  }
+
   void VisitInjectedClassNameType(const InjectedClassNameType *ICNT) {
 Outer.add(ICNT->getDecl(), Flags);
   }


Index: clang-tools-extra/clangd/unittests/FindTargetTests.cpp
===
--- clang-tools-extra/clangd/unittests/FindTargetTests.cpp
+++ clang-tools-extra/clangd/unittests/FindTargetTests.cpp
@@ -241,6 +241,13 @@
   )cpp";
   EXPECT_DECLS("TypedefTypeLoc", {"typedef S X", Rel::Alias},
{"struct S", Rel::Underlying});
+  Code = R"cpp(
+namespace ns { struct S{}; }
+typedef ns::S X;
+[[X]] x;
+  )cpp";
+  EXPECT_DECLS("TypedefTypeLoc", {"typedef ns::S X", Rel::Alias},
+   {"struct S", Rel::Underlying});
 
   // FIXME: Auto-completion in a template requires disabling delayed template
   // parsing.
Index: clang-tools-extra/clangd/FindTarget.cpp
===
--- clang-tools-extra/clangd/FindTarget.cpp
+++ clang-tools-extra/clangd/FindTarget.cpp
@@ -379,6 +379,10 @@
 Outer.add(TT->getAsTagDecl(), Flags);
   }
 
+  void VisitElaboratedType(const ElaboratedType* ET) {
+Outer.add(ET->desugar(), Flags);
+  }
+
   void VisitInjectedClassNameType(const InjectedClassNameType *ICNT) {
 Outer.add(ICNT->getDecl(), Flags);
   }
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits