[PATCH] D76690: [AST][SVE] Treat built-in SVE types as POD
This revision was automatically updated to reflect the committed changes. Closed by commit rG9dcb20a7d008: [AST][SVE] Treat built-in SVE types as POD (authored by rsandifo-arm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76690/new/ https://reviews.llvm.org/D76690 Files: clang/lib/AST/Type.cpp clang/test/SemaCXX/sizeless-1.cpp Index: clang/test/SemaCXX/sizeless-1.cpp === --- clang/test/SemaCXX/sizeless-1.cpp +++ clang/test/SemaCXX/sizeless-1.cpp @@ -266,6 +266,7 @@ __builtin_va_list va; __builtin_va_start(va, first); + __builtin_va_arg(va, svint8_t); __builtin_va_end(va); return count; } @@ -491,6 +492,16 @@ _Static_assert(!__is_assignable(svint8_t, svint8_t), ""); _Static_assert(__is_assignable(svint8_t &, svint8_t), ""); _Static_assert(!__is_assignable(svint8_t &, svint16_t), ""); + _Static_assert(__has_nothrow_assign(svint8_t), ""); + _Static_assert(__has_nothrow_move_assign(svint8_t), ""); + _Static_assert(__has_nothrow_copy(svint8_t), ""); + _Static_assert(__has_nothrow_constructor(svint8_t), ""); + _Static_assert(__has_trivial_assign(svint8_t), ""); + _Static_assert(__has_trivial_move_assign(svint8_t), ""); + _Static_assert(__has_trivial_copy(svint8_t), ""); + _Static_assert(__has_trivial_constructor(svint8_t), ""); + _Static_assert(__has_trivial_move_constructor(svint8_t), ""); + _Static_assert(__has_trivial_destructor(svint8_t), ""); _Static_assert(!__has_virtual_destructor(svint8_t), ""); _Static_assert(!__is_abstract(svint8_t), ""); _Static_assert(!__is_aggregate(svint8_t), ""); @@ -502,6 +513,7 @@ _Static_assert(!__is_enum(svint8_t), ""); _Static_assert(!__is_final(svint8_t), ""); _Static_assert(!__is_literal(svint8_t), ""); + _Static_assert(__is_pod(svint8_t), ""); _Static_assert(!__is_polymorphic(svint8_t), ""); _Static_assert(__is_object(svint8_t), ""); _Static_assert(!__is_arithmetic(svint8_t), ""); Index: clang/lib/AST/Type.cpp === --- clang/lib/AST/Type.cpp +++ clang/lib/AST/Type.cpp @@ -2496,6 +2496,9 @@ const Type *BaseTy = ty->getBaseElementTypeUnsafe(); assert(BaseTy && "NULL element type"); + if (BaseTy->isSizelessBuiltinType()) +return true; + // Return false for incomplete types after skipping any incomplete array // types which are expressly allowed by the standard and thus our API. if (BaseTy->isIncompleteType()) Index: clang/test/SemaCXX/sizeless-1.cpp === --- clang/test/SemaCXX/sizeless-1.cpp +++ clang/test/SemaCXX/sizeless-1.cpp @@ -266,6 +266,7 @@ __builtin_va_list va; __builtin_va_start(va, first); + __builtin_va_arg(va, svint8_t); __builtin_va_end(va); return count; } @@ -491,6 +492,16 @@ _Static_assert(!__is_assignable(svint8_t, svint8_t), ""); _Static_assert(__is_assignable(svint8_t &, svint8_t), ""); _Static_assert(!__is_assignable(svint8_t &, svint16_t), ""); + _Static_assert(__has_nothrow_assign(svint8_t), ""); + _Static_assert(__has_nothrow_move_assign(svint8_t), ""); + _Static_assert(__has_nothrow_copy(svint8_t), ""); + _Static_assert(__has_nothrow_constructor(svint8_t), ""); + _Static_assert(__has_trivial_assign(svint8_t), ""); + _Static_assert(__has_trivial_move_assign(svint8_t), ""); + _Static_assert(__has_trivial_copy(svint8_t), ""); + _Static_assert(__has_trivial_constructor(svint8_t), ""); + _Static_assert(__has_trivial_move_constructor(svint8_t), ""); + _Static_assert(__has_trivial_destructor(svint8_t), ""); _Static_assert(!__has_virtual_destructor(svint8_t), ""); _Static_assert(!__is_abstract(svint8_t), ""); _Static_assert(!__is_aggregate(svint8_t), ""); @@ -502,6 +513,7 @@ _Static_assert(!__is_enum(svint8_t), ""); _Static_assert(!__is_final(svint8_t), ""); _Static_assert(!__is_literal(svint8_t), ""); + _Static_assert(__is_pod(svint8_t), ""); _Static_assert(!__is_polymorphic(svint8_t), ""); _Static_assert(__is_object(svint8_t), ""); _Static_assert(!__is_arithmetic(svint8_t), ""); Index: clang/lib/AST/Type.cpp === --- clang/lib/AST/Type.cpp +++ clang/lib/AST/Type.cpp @@ -2496,6 +2496,9 @@ const Type *BaseTy = ty->getBaseElementTypeUnsafe(); assert(BaseTy && "NULL element type"); + if (BaseTy->isSizelessBuiltinType()) +return true; + // Return false for incomplete types after skipping any incomplete array // types which are expressly allowed by the standard and thus our API. if (BaseTy->isIncompleteType()) ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D76690: [AST][SVE] Treat built-in SVE types as POD
efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. Okay, then LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76690/new/ https://reviews.llvm.org/D76690 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D76690: [AST][SVE] Treat built-in SVE types as POD
rsandifo-arm marked an inline comment as done. rsandifo-arm added inline comments. Comment at: clang/lib/AST/Type.cpp:2515 + if (BaseTy->isSizelessBuiltinType()) +return true; + efriedma wrote: > Can you rearrange this so isSizelessBuiltinType() is at the bottom? It > should be rare. (Assuming it doesn't need to be before the > isIncompleteType() check.) I should have mentioned that, but yeah: the call is placed here so that it continues to work when/if IsCompleteType returns true for these types. (I have a patch for that, similar to D76221, but I don't know whether it will be acceptable.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76690/new/ https://reviews.llvm.org/D76690 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D76690: [AST][SVE] Treat built-in SVE types as POD
efriedma added inline comments. Comment at: clang/lib/AST/Type.cpp:2515 + if (BaseTy->isSizelessBuiltinType()) +return true; + Can you rearrange this so isSizelessBuiltinType() is at the bottom? It should be rare. (Assuming it doesn't need to be before the isIncompleteType() check.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76690/new/ https://reviews.llvm.org/D76690 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D76690: [AST][SVE] Treat built-in SVE types as POD
rsandifo-arm created this revision. rsandifo-arm added reviewers: sdesmalen, efriedma, rovka, rjmccall. Herald added subscribers: cfe-commits, psnobl, rkruppe, tschuett. Herald added a reviewer: rengolin. Herald added a project: clang. Built-in SVE types are POD in much the same that scalars and fixed-length vectors are. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D76690 Files: clang/lib/AST/Type.cpp clang/test/SemaCXX/sizeless-1.cpp Index: clang/test/SemaCXX/sizeless-1.cpp === --- clang/test/SemaCXX/sizeless-1.cpp +++ clang/test/SemaCXX/sizeless-1.cpp @@ -272,6 +272,7 @@ __builtin_va_list va; __builtin_va_start(va, first); + __builtin_va_arg(va, svint8_t); __builtin_va_end(va); return count; } @@ -502,6 +503,16 @@ _Static_assert(!__is_assignable(svint8_t, svint8_t), ""); _Static_assert(__is_assignable(svint8_t &, svint8_t), ""); _Static_assert(!__is_assignable(svint8_t &, svint16_t), ""); + _Static_assert(__has_nothrow_assign(svint8_t), ""); + _Static_assert(__has_nothrow_move_assign(svint8_t), ""); + _Static_assert(__has_nothrow_copy(svint8_t), ""); + _Static_assert(__has_nothrow_constructor(svint8_t), ""); + _Static_assert(__has_trivial_assign(svint8_t), ""); + _Static_assert(__has_trivial_move_assign(svint8_t), ""); + _Static_assert(__has_trivial_copy(svint8_t), ""); + _Static_assert(__has_trivial_constructor(svint8_t), ""); + _Static_assert(__has_trivial_move_constructor(svint8_t), ""); + _Static_assert(__has_trivial_destructor(svint8_t), ""); _Static_assert(!__has_virtual_destructor(svint8_t), ""); _Static_assert(!__is_abstract(svint8_t), ""); _Static_assert(!__is_aggregate(svint8_t), ""); @@ -513,6 +524,7 @@ _Static_assert(!__is_enum(svint8_t), ""); _Static_assert(!__is_final(svint8_t), ""); _Static_assert(!__is_literal(svint8_t), ""); + _Static_assert(__is_pod(svint8_t), ""); _Static_assert(!__is_polymorphic(svint8_t), ""); _Static_assert(__is_object(svint8_t), ""); _Static_assert(!__is_arithmetic(svint8_t), ""); Index: clang/lib/AST/Type.cpp === --- clang/lib/AST/Type.cpp +++ clang/lib/AST/Type.cpp @@ -2511,6 +2511,9 @@ const Type *BaseTy = ty->getBaseElementTypeUnsafe(); assert(BaseTy && "NULL element type"); + if (BaseTy->isSizelessBuiltinType()) +return true; + // Return false for incomplete types after skipping any incomplete array // types which are expressly allowed by the standard and thus our API. if (BaseTy->isIncompleteType()) Index: clang/test/SemaCXX/sizeless-1.cpp === --- clang/test/SemaCXX/sizeless-1.cpp +++ clang/test/SemaCXX/sizeless-1.cpp @@ -272,6 +272,7 @@ __builtin_va_list va; __builtin_va_start(va, first); + __builtin_va_arg(va, svint8_t); __builtin_va_end(va); return count; } @@ -502,6 +503,16 @@ _Static_assert(!__is_assignable(svint8_t, svint8_t), ""); _Static_assert(__is_assignable(svint8_t &, svint8_t), ""); _Static_assert(!__is_assignable(svint8_t &, svint16_t), ""); + _Static_assert(__has_nothrow_assign(svint8_t), ""); + _Static_assert(__has_nothrow_move_assign(svint8_t), ""); + _Static_assert(__has_nothrow_copy(svint8_t), ""); + _Static_assert(__has_nothrow_constructor(svint8_t), ""); + _Static_assert(__has_trivial_assign(svint8_t), ""); + _Static_assert(__has_trivial_move_assign(svint8_t), ""); + _Static_assert(__has_trivial_copy(svint8_t), ""); + _Static_assert(__has_trivial_constructor(svint8_t), ""); + _Static_assert(__has_trivial_move_constructor(svint8_t), ""); + _Static_assert(__has_trivial_destructor(svint8_t), ""); _Static_assert(!__has_virtual_destructor(svint8_t), ""); _Static_assert(!__is_abstract(svint8_t), ""); _Static_assert(!__is_aggregate(svint8_t), ""); @@ -513,6 +524,7 @@ _Static_assert(!__is_enum(svint8_t), ""); _Static_assert(!__is_final(svint8_t), ""); _Static_assert(!__is_literal(svint8_t), ""); + _Static_assert(__is_pod(svint8_t), ""); _Static_assert(!__is_polymorphic(svint8_t), ""); _Static_assert(__is_object(svint8_t), ""); _Static_assert(!__is_arithmetic(svint8_t), ""); Index: clang/lib/AST/Type.cpp === --- clang/lib/AST/Type.cpp +++ clang/lib/AST/Type.cpp @@ -2511,6 +2511,9 @@ const Type *BaseTy = ty->getBaseElementTypeUnsafe(); assert(BaseTy && "NULL element type"); + if (BaseTy->isSizelessBuiltinType()) +return true; + // Return false for incomplete types after skipping any incomplete array // types which are expressly allowed by the standard and thus our API. if (BaseTy->isIncompleteType()) ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
