[PATCH] D78487: Explicitly move from llvm::json Array/Object to Value
This revision was automatically updated to reflect the committed changes. Closed by commit rGb36b889a3b81: Explicitly move from llvm::json Array/Object to Value (authored by MForster, committed by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78487/new/ https://reviews.llvm.org/D78487 Files: clang-tools-extra/clangd/Protocol.cpp Index: clang-tools-extra/clangd/Protocol.cpp === --- clang-tools-extra/clangd/Protocol.cpp +++ clang-tools-extra/clangd/Protocol.cpp @@ -1002,7 +1002,7 @@ Result.push_back(Tok.tokenModifiers); } assert(Result.size() == SemanticTokenEncodingSize * Toks.size()); - return Result; + return std::move(Result); } bool operator==(const SemanticToken &L, const SemanticToken &R) { @@ -1030,7 +1030,7 @@ Result["edits"] = *TE.edits; if (TE.tokens) Result["data"] = encodeTokens(*TE.tokens); - return Result; + return std::move(Result); } bool fromJSON(const llvm::json::Value &Params, SemanticTokensParams &R) { Index: clang-tools-extra/clangd/Protocol.cpp === --- clang-tools-extra/clangd/Protocol.cpp +++ clang-tools-extra/clangd/Protocol.cpp @@ -1002,7 +1002,7 @@ Result.push_back(Tok.tokenModifiers); } assert(Result.size() == SemanticTokenEncodingSize * Toks.size()); - return Result; + return std::move(Result); } bool operator==(const SemanticToken &L, const SemanticToken &R) { @@ -1030,7 +1030,7 @@ Result["edits"] = *TE.edits; if (TE.tokens) Result["data"] = encodeTokens(*TE.tokens); - return Result; + return std::move(Result); } bool fromJSON(const llvm::json::Value &Params, SemanticTokensParams &R) { ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D78487: Explicitly move from llvm::json Array/Object to Value
sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78487/new/ https://reviews.llvm.org/D78487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D78487: Explicitly move from llvm::json Array/Object to Value
MForster created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. MForster retitled this revision from "Explicitly move from llvm::json Array to Value" to "Explicitly move from llvm::json Array/Object to Value". MForster added a reviewer: sammccall. The implicit conversion fails under Clang 3.8. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D78487 Files: clang-tools-extra/clangd/Protocol.cpp Index: clang-tools-extra/clangd/Protocol.cpp === --- clang-tools-extra/clangd/Protocol.cpp +++ clang-tools-extra/clangd/Protocol.cpp @@ -1002,7 +1002,7 @@ Result.push_back(Tok.tokenModifiers); } assert(Result.size() == SemanticTokenEncodingSize * Toks.size()); - return Result; + return std::move(Result); } bool operator==(const SemanticToken &L, const SemanticToken &R) { @@ -1030,7 +1030,7 @@ Result["edits"] = *TE.edits; if (TE.tokens) Result["data"] = encodeTokens(*TE.tokens); - return Result; + return std::move(Result); } bool fromJSON(const llvm::json::Value &Params, SemanticTokensParams &R) { Index: clang-tools-extra/clangd/Protocol.cpp === --- clang-tools-extra/clangd/Protocol.cpp +++ clang-tools-extra/clangd/Protocol.cpp @@ -1002,7 +1002,7 @@ Result.push_back(Tok.tokenModifiers); } assert(Result.size() == SemanticTokenEncodingSize * Toks.size()); - return Result; + return std::move(Result); } bool operator==(const SemanticToken &L, const SemanticToken &R) { @@ -1030,7 +1030,7 @@ Result["edits"] = *TE.edits; if (TE.tokens) Result["data"] = encodeTokens(*TE.tokens); - return Result; + return std::move(Result); } bool fromJSON(const llvm::json::Value &Params, SemanticTokensParams &R) { ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits