[PATCH] D78807: Fix gendered documentation
keryell added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/google-objc-global-variable-declaration.rst:47 The check will give a warning message but will not be able to suggest a fix. The -user need to fix it on his own. +user needs to fix it on their own. I wonder whether it would not be more coherent to have more than 1 user here. But this is just a French point-of-view. :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78807/new/ https://reviews.llvm.org/D78807 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D78807: Fix gendered documentation
This revision was automatically updated to reflect the committed changes. Closed by commit rG43e451f9f316: Fix gendered documentation (authored by pedro.gonnet, committed by sylvestre.ledru). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78807/new/ https://reviews.llvm.org/D78807 Files: clang-tools-extra/docs/clang-tidy/checks/google-objc-global-variable-declaration.rst lldb/docs/use/variable.rst Index: lldb/docs/use/variable.rst === --- lldb/docs/use/variable.rst +++ lldb/docs/use/variable.rst @@ -993,7 +993,7 @@ user to see. A filter will solve this issue by only letting the user see those member -variables he cares about. Of course, the equivalent of a filter can be +variables they care about. Of course, the equivalent of a filter can be implemented easily using synthetic children, but a filter lets you get the job done without having to write Python code. Index: clang-tools-extra/docs/clang-tidy/checks/google-objc-global-variable-declaration.rst === --- clang-tools-extra/docs/clang-tidy/checks/google-objc-global-variable-declaration.rst +++ clang-tools-extra/docs/clang-tidy/checks/google-objc-global-variable-declaration.rst @@ -44,4 +44,4 @@ static NSString* __anotherString = @"world"; The check will give a warning message but will not be able to suggest a fix. The -user need to fix it on his own. +user needs to fix it on their own. Index: lldb/docs/use/variable.rst === --- lldb/docs/use/variable.rst +++ lldb/docs/use/variable.rst @@ -993,7 +993,7 @@ user to see. A filter will solve this issue by only letting the user see those member -variables he cares about. Of course, the equivalent of a filter can be +variables they care about. Of course, the equivalent of a filter can be implemented easily using synthetic children, but a filter lets you get the job done without having to write Python code. Index: clang-tools-extra/docs/clang-tidy/checks/google-objc-global-variable-declaration.rst === --- clang-tools-extra/docs/clang-tidy/checks/google-objc-global-variable-declaration.rst +++ clang-tools-extra/docs/clang-tidy/checks/google-objc-global-variable-declaration.rst @@ -44,4 +44,4 @@ static NSString* __anotherString = @"world"; The check will give a warning message but will not be able to suggest a fix. The -user need to fix it on his own. +user needs to fix it on their own. ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [Lldb-commits] [PATCH] D78807: Fix gendered documentation
A lot of our comments and documentation was written a while ago when the “good” practice was to be careful to use “he” and “she” in equal measure when referring to our users. The consensus has shifted to using “they” instead, so there are probably a bunch of other places using he and she. Please feel free to fix this wherever you see it! Thanks! Jim > On Apr 24, 2020, at 9:43 AM, Jonas Devlieghere via Phabricator via > lldb-commits wrote: > > JDevlieghere accepted this revision. > JDevlieghere added a comment. > > Thank you! > > > Repository: > rG LLVM Github Monorepo > > CHANGES SINCE LAST ACTION > https://reviews.llvm.org/D78807/new/ > > https://reviews.llvm.org/D78807 > > > > ___ > lldb-commits mailing list > lldb-comm...@lists.llvm.org > https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D78807: Fix gendered documentation
JDevlieghere accepted this revision. JDevlieghere added a comment. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78807/new/ https://reviews.llvm.org/D78807 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D78807: Fix gendered documentation
sylvestre.ledru accepted this revision. sylvestre.ledru added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78807/new/ https://reviews.llvm.org/D78807 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D78807: Fix gendered documentation
pedro.gonnet created this revision. pedro.gonnet added reviewers: JDevlieghere, hokein. Herald added projects: clang, LLDB. Herald added subscribers: lldb-commits, cfe-commits. Changed two references to developers as "he" or "him" to the more neutral "they". Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D78807 Files: clang-tools-extra/docs/clang-tidy/checks/google-objc-global-variable-declaration.rst lldb/docs/use/variable.rst Index: lldb/docs/use/variable.rst === --- lldb/docs/use/variable.rst +++ lldb/docs/use/variable.rst @@ -993,7 +993,7 @@ user to see. A filter will solve this issue by only letting the user see those member -variables he cares about. Of course, the equivalent of a filter can be +variables they care about. Of course, the equivalent of a filter can be implemented easily using synthetic children, but a filter lets you get the job done without having to write Python code. Index: clang-tools-extra/docs/clang-tidy/checks/google-objc-global-variable-declaration.rst === --- clang-tools-extra/docs/clang-tidy/checks/google-objc-global-variable-declaration.rst +++ clang-tools-extra/docs/clang-tidy/checks/google-objc-global-variable-declaration.rst @@ -44,4 +44,4 @@ static NSString* __anotherString = @"world"; The check will give a warning message but will not be able to suggest a fix. The -user need to fix it on his own. +user needs to fix it on their own. Index: lldb/docs/use/variable.rst === --- lldb/docs/use/variable.rst +++ lldb/docs/use/variable.rst @@ -993,7 +993,7 @@ user to see. A filter will solve this issue by only letting the user see those member -variables he cares about. Of course, the equivalent of a filter can be +variables they care about. Of course, the equivalent of a filter can be implemented easily using synthetic children, but a filter lets you get the job done without having to write Python code. Index: clang-tools-extra/docs/clang-tidy/checks/google-objc-global-variable-declaration.rst === --- clang-tools-extra/docs/clang-tidy/checks/google-objc-global-variable-declaration.rst +++ clang-tools-extra/docs/clang-tidy/checks/google-objc-global-variable-declaration.rst @@ -44,4 +44,4 @@ static NSString* __anotherString = @"world"; The check will give a warning message but will not be able to suggest a fix. The -user need to fix it on his own. +user needs to fix it on their own. ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
