[PATCH] D78944: [libc++][test] Disable test for extension that's unsupportable in C++20

2020-04-27 Thread Casey Carter via Phabricator via cfe-commits 
This revision was automatically updated to reflect the committed changes.
Closed by commit rGb4437992ecce: [libc++][test] Disable test for extension 
thats unsupportable in C++20 (authored by CaseyCarter).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78944/new/

https://reviews.llvm.org/D78944

Files:
  libcxx/test/std/containers/associative/map/map.cons/default_recursive.pass.cpp
  
libcxx/test/std/containers/associative/multimap/multimap.cons/default_recursive.pass.cpp


Index: 
libcxx/test/std/containers/associative/multimap/multimap.cons/default_recursive.pass.cpp
===
--- 
libcxx/test/std/containers/associative/multimap/multimap.cons/default_recursive.pass.cpp
+++ 
libcxx/test/std/containers/associative/multimap/multimap.cons/default_recursive.pass.cpp
@@ -21,12 +21,11 @@
 std::multimap m;
 std::multimap::iterator i;
 std::multimap::const_iterator ci;
+#if TEST_STD_VER <= 17
+// These reverse_iterator specializations require X to be complete in 
C++20.
 std::multimap::reverse_iterator ri;
 std::multimap::const_reverse_iterator cri;
+#endif // TEST_STD_VER <= 17
 };
 
-int main(int, char**)
-{
-
-  return 0;
-}
+int main(int, char**) { return 0; }
Index: 
libcxx/test/std/containers/associative/map/map.cons/default_recursive.pass.cpp
===
--- 
libcxx/test/std/containers/associative/map/map.cons/default_recursive.pass.cpp
+++ 
libcxx/test/std/containers/associative/map/map.cons/default_recursive.pass.cpp
@@ -21,12 +21,11 @@
 std::map m;
 std::map::iterator i;
 std::map::const_iterator ci;
+#if TEST_STD_VER <= 17
+// These reverse_iterator specializations require X to be complete in 
C++20.
 std::map::reverse_iterator ri;
 std::map::const_reverse_iterator cri;
+#endif // TEST_STD_VER <= 17
 };
 
-int main(int, char**)
-{
-
-  return 0;
-}
+int main(int, char**) { return 0; }


Index: libcxx/test/std/containers/associative/multimap/multimap.cons/default_recursive.pass.cpp
===
--- libcxx/test/std/containers/associative/multimap/multimap.cons/default_recursive.pass.cpp
+++ libcxx/test/std/containers/associative/multimap/multimap.cons/default_recursive.pass.cpp
@@ -21,12 +21,11 @@
 std::multimap m;
 std::multimap::iterator i;
 std::multimap::const_iterator ci;
+#if TEST_STD_VER <= 17
+// These reverse_iterator specializations require X to be complete in C++20.
 std::multimap::reverse_iterator ri;
 std::multimap::const_reverse_iterator cri;
+#endif // TEST_STD_VER <= 17
 };
 
-int main(int, char**)
-{
-
-  return 0;
-}
+int main(int, char**) { return 0; }
Index: libcxx/test/std/containers/associative/map/map.cons/default_recursive.pass.cpp
===
--- libcxx/test/std/containers/associative/map/map.cons/default_recursive.pass.cpp
+++ libcxx/test/std/containers/associative/map/map.cons/default_recursive.pass.cpp
@@ -21,12 +21,11 @@
 std::map m;
 std::map::iterator i;
 std::map::const_iterator ci;
+#if TEST_STD_VER <= 17
+// These reverse_iterator specializations require X to be complete in C++20.
 std::map::reverse_iterator ri;
 std::map::const_reverse_iterator cri;
+#endif // TEST_STD_VER <= 17
 };
 
-int main(int, char**)
-{
-
-  return 0;
-}
+int main(int, char**) { return 0; }
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D78944: [libc++][test] Disable test for extension that's unsupportable in C++20

2020-04-27 Thread Casey Carter via Phabricator via cfe-commits 
CaseyCarter updated this revision to Diff 260391.
CaseyCarter added a comment.

Review comments.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78944/new/

https://reviews.llvm.org/D78944

Files:
  libcxx/test/std/containers/associative/map/map.cons/default_recursive.pass.cpp
  
libcxx/test/std/containers/associative/multimap/multimap.cons/default_recursive.pass.cpp


Index: 
libcxx/test/std/containers/associative/multimap/multimap.cons/default_recursive.pass.cpp
===
--- 
libcxx/test/std/containers/associative/multimap/multimap.cons/default_recursive.pass.cpp
+++ 
libcxx/test/std/containers/associative/multimap/multimap.cons/default_recursive.pass.cpp
@@ -21,12 +21,11 @@
 std::multimap m;
 std::multimap::iterator i;
 std::multimap::const_iterator ci;
+#if TEST_STD_VER <= 17
+// These reverse_iterator specializations require X to be complete in 
C++20.
 std::multimap::reverse_iterator ri;
 std::multimap::const_reverse_iterator cri;
+#endif // TEST_STD_VER <= 17
 };
 
-int main(int, char**)
-{
-
-  return 0;
-}
+int main(int, char**) { return 0; }
Index: 
libcxx/test/std/containers/associative/map/map.cons/default_recursive.pass.cpp
===
--- 
libcxx/test/std/containers/associative/map/map.cons/default_recursive.pass.cpp
+++ 
libcxx/test/std/containers/associative/map/map.cons/default_recursive.pass.cpp
@@ -21,12 +21,11 @@
 std::map m;
 std::map::iterator i;
 std::map::const_iterator ci;
+#if TEST_STD_VER <= 17
+// These reverse_iterator specializations require X to be complete in 
C++20.
 std::map::reverse_iterator ri;
 std::map::const_reverse_iterator cri;
+#endif // TEST_STD_VER <= 17
 };
 
-int main(int, char**)
-{
-
-  return 0;
-}
+int main(int, char**) { return 0; }


Index: libcxx/test/std/containers/associative/multimap/multimap.cons/default_recursive.pass.cpp
===
--- libcxx/test/std/containers/associative/multimap/multimap.cons/default_recursive.pass.cpp
+++ libcxx/test/std/containers/associative/multimap/multimap.cons/default_recursive.pass.cpp
@@ -21,12 +21,11 @@
 std::multimap m;
 std::multimap::iterator i;
 std::multimap::const_iterator ci;
+#if TEST_STD_VER <= 17
+// These reverse_iterator specializations require X to be complete in C++20.
 std::multimap::reverse_iterator ri;
 std::multimap::const_reverse_iterator cri;
+#endif // TEST_STD_VER <= 17
 };
 
-int main(int, char**)
-{
-
-  return 0;
-}
+int main(int, char**) { return 0; }
Index: libcxx/test/std/containers/associative/map/map.cons/default_recursive.pass.cpp
===
--- libcxx/test/std/containers/associative/map/map.cons/default_recursive.pass.cpp
+++ libcxx/test/std/containers/associative/map/map.cons/default_recursive.pass.cpp
@@ -21,12 +21,11 @@
 std::map m;
 std::map::iterator i;
 std::map::const_iterator ci;
+#if TEST_STD_VER <= 17
+// These reverse_iterator specializations require X to be complete in C++20.
 std::map::reverse_iterator ri;
 std::map::const_reverse_iterator cri;
+#endif // TEST_STD_VER <= 17
 };
 
-int main(int, char**)
-{
-
-  return 0;
-}
+int main(int, char**) { return 0; }
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D78944: [libc++][test] Disable test for extension that's unsupportable in C++20

2020-04-27 Thread Louis Dionne via Phabricator via cfe-commits 
ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

Could you add a short comment explaining the `#if`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78944/new/

https://reviews.llvm.org/D78944



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D78944: [libc++][test] Disable test for extension that's unsupportable in C++20

2020-04-27 Thread Casey Carter via Phabricator via cfe-commits 
CaseyCarter created this revision.
CaseyCarter added reviewers: ldionne, EricWF, mclow.lists.
Herald added subscribers: libcxx-commits, broadwaylamb, dexonsmith.
Herald added a project: libc++.
Herald added a reviewer: libc++.

Defining the nested types `reference` and `iterator_concept` of 
`reverse_iterator` necessarily requires `I` to be complete in C++20. These 
tests that verify that `std::map::reverse_iterator` can be instantiated 
when `X` is incomplete are going to have a bad time.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D78944

Files:
  libcxx/test/std/containers/associative/map/map.cons/default_recursive.pass.cpp
  
libcxx/test/std/containers/associative/multimap/multimap.cons/default_recursive.pass.cpp


Index: 
libcxx/test/std/containers/associative/multimap/multimap.cons/default_recursive.pass.cpp
===
--- 
libcxx/test/std/containers/associative/multimap/multimap.cons/default_recursive.pass.cpp
+++ 
libcxx/test/std/containers/associative/multimap/multimap.cons/default_recursive.pass.cpp
@@ -21,12 +21,13 @@
 std::multimap m;
 std::multimap::iterator i;
 std::multimap::const_iterator ci;
+#if TEST_STD_VER <= 17
 std::multimap::reverse_iterator ri;
 std::multimap::const_reverse_iterator cri;
+#endif // TEST_STD_VER <= 17
 };
 
 int main(int, char**)
 {
-
-  return 0;
+return 0;
 }
Index: 
libcxx/test/std/containers/associative/map/map.cons/default_recursive.pass.cpp
===
--- 
libcxx/test/std/containers/associative/map/map.cons/default_recursive.pass.cpp
+++ 
libcxx/test/std/containers/associative/map/map.cons/default_recursive.pass.cpp
@@ -21,12 +21,13 @@
 std::map m;
 std::map::iterator i;
 std::map::const_iterator ci;
+#if TEST_STD_VER <= 17
 std::map::reverse_iterator ri;
 std::map::const_reverse_iterator cri;
+#endif // TEST_STD_VER <= 17
 };
 
 int main(int, char**)
 {
-
-  return 0;
+return 0;
 }


Index: libcxx/test/std/containers/associative/multimap/multimap.cons/default_recursive.pass.cpp
===
--- libcxx/test/std/containers/associative/multimap/multimap.cons/default_recursive.pass.cpp
+++ libcxx/test/std/containers/associative/multimap/multimap.cons/default_recursive.pass.cpp
@@ -21,12 +21,13 @@
 std::multimap m;
 std::multimap::iterator i;
 std::multimap::const_iterator ci;
+#if TEST_STD_VER <= 17
 std::multimap::reverse_iterator ri;
 std::multimap::const_reverse_iterator cri;
+#endif // TEST_STD_VER <= 17
 };
 
 int main(int, char**)
 {
-
-  return 0;
+return 0;
 }
Index: libcxx/test/std/containers/associative/map/map.cons/default_recursive.pass.cpp
===
--- libcxx/test/std/containers/associative/map/map.cons/default_recursive.pass.cpp
+++ libcxx/test/std/containers/associative/map/map.cons/default_recursive.pass.cpp
@@ -21,12 +21,13 @@
 std::map m;
 std::map::iterator i;
 std::map::const_iterator ci;
+#if TEST_STD_VER <= 17
 std::map::reverse_iterator ri;
 std::map::const_reverse_iterator cri;
+#endif // TEST_STD_VER <= 17
 };
 
 int main(int, char**)
 {
-
-  return 0;
+return 0;
 }
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits