[PATCH] D82661: [clang-tidy][NFC] Remove unnecessary includes throughout clang-tidy header files
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG860aefd0784e: [clang-tidy][NFC] Remove unnecessary includes throughout clang-tidy header files (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82661/new/ https://reviews.llvm.org/D82661 Files: clang-tools-extra/clang-tidy/ClangTidy.cpp clang-tools-extra/clang-tidy/ClangTidy.h clang-tools-extra/clang-tidy/ClangTidyCheck.h clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h clang-tools-extra/clang-tidy/ClangTidyModule.cpp clang-tools-extra/clang-tidy/ClangTidyModule.h clang-tools-extra/clang-tidy/ClangTidyProfiling.h clang-tools-extra/clang-tidy/abseil/DurationAdditionCheck.h clang-tools-extra/clang-tidy/abseil/DurationComparisonCheck.h clang-tools-extra/clang-tidy/abseil/DurationConversionCastCheck.h clang-tools-extra/clang-tidy/abseil/DurationDivisionCheck.cpp clang-tools-extra/clang-tidy/abseil/DurationDivisionCheck.h clang-tools-extra/clang-tidy/abseil/DurationFactoryFloatCheck.cpp clang-tools-extra/clang-tidy/abseil/DurationFactoryFloatCheck.h clang-tools-extra/clang-tidy/abseil/DurationFactoryScaleCheck.h clang-tools-extra/clang-tidy/abseil/DurationSubtractionCheck.h clang-tools-extra/clang-tidy/abseil/DurationUnnecessaryConversionCheck.h clang-tools-extra/clang-tidy/abseil/FasterStrsplitDelimiterCheck.h clang-tools-extra/clang-tidy/abseil/NoInternalDependenciesCheck.h clang-tools-extra/clang-tidy/abseil/NoNamespaceCheck.h clang-tools-extra/clang-tidy/abseil/RedundantStrcatCallsCheck.h clang-tools-extra/clang-tidy/abseil/StrCatAppendCheck.h clang-tools-extra/clang-tidy/abseil/StringFindStartswithCheck.cpp clang-tools-extra/clang-tidy/abseil/StringFindStartswithCheck.h clang-tools-extra/clang-tidy/abseil/StringFindStrContainsCheck.h clang-tools-extra/clang-tidy/abseil/TimeComparisonCheck.h clang-tools-extra/clang-tidy/abseil/TimeSubtractionCheck.cpp clang-tools-extra/clang-tidy/abseil/TimeSubtractionCheck.h clang-tools-extra/clang-tidy/abseil/UpgradeDurationConversionsCheck.cpp clang-tools-extra/clang-tidy/abseil/UpgradeDurationConversionsCheck.h clang-tools-extra/clang-tidy/bugprone/BadSignalToKillThreadCheck.cpp clang-tools-extra/clang-tidy/bugprone/BranchCloneCheck.cpp clang-tools-extra/clang-tidy/bugprone/BranchCloneCheck.h clang-tools-extra/clang-tidy/bugprone/MisplacedOperatorInStrlenInAllocCheck.cpp clang-tools-extra/clang-tidy/bugprone/MisplacedPointerArithmeticInAllocCheck.cpp clang-tools-extra/clang-tidy/bugprone/NotNullTerminatedResultCheck.cpp clang-tools-extra/clang-tidy/bugprone/NotNullTerminatedResultCheck.h clang-tools-extra/clang-tidy/bugprone/PosixReturnCheck.cpp clang-tools-extra/clang-tidy/bugprone/ReservedIdentifierCheck.cpp clang-tools-extra/clang-tidy/bugprone/SuspiciousIncludeCheck.cpp clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidGotoCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/InitVariablesCheck.cpp clang-tools-extra/clang-tidy/cppcoreguidelines/InterfacesGlobalInitCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/MacroUsageCheck.cpp clang-tools-extra/clang-tidy/cppcoreguidelines/MacroUsageCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/NoMallocCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/OwningMemoryCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/ProBoundsArrayToPointerDecayCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/ProBoundsConstantArrayIndexCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/ProBoundsPointerArithmeticCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeConstCastCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeCstyleCastCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeReinterpretCastCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeStaticCastDowncastCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeUnionAccessCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeVarargCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/SlicingCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.h clang-tools-extra/clang-tidy/fuchsia/DefaultArgumentsDeclarationsCheck.cpp clang-tools-extra/clang-tidy/google/AvoidNSObjectNewCheck.cpp clang-tools-extra/clang-tidy/google/AvoidUnderscoreInGoogletestNameCheck.cpp clang-tools-extra/clang-tidy/google/UpgradeGoogletestCaseCheck.cpp clang-tools-extra/clang-tidy/hicpp/ExceptionBaseclassCheck.h clang-tools-extra/clang-tidy/hicpp/MultiwayPathsCoveredCheck.h
[PATCH] D82661: [clang-tidy][NFC] Remove unnecessary includes throughout clang-tidy header files
njames93 updated this revision to Diff 274129. njames93 added a comment. Remove unnecessary test changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82661/new/ https://reviews.llvm.org/D82661 Files: clang-tools-extra/clang-tidy/ClangTidy.cpp clang-tools-extra/clang-tidy/ClangTidy.h clang-tools-extra/clang-tidy/ClangTidyCheck.h clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h clang-tools-extra/clang-tidy/ClangTidyModule.cpp clang-tools-extra/clang-tidy/ClangTidyModule.h clang-tools-extra/clang-tidy/ClangTidyProfiling.h clang-tools-extra/clang-tidy/abseil/DurationAdditionCheck.h clang-tools-extra/clang-tidy/abseil/DurationComparisonCheck.h clang-tools-extra/clang-tidy/abseil/DurationConversionCastCheck.h clang-tools-extra/clang-tidy/abseil/DurationDivisionCheck.cpp clang-tools-extra/clang-tidy/abseil/DurationDivisionCheck.h clang-tools-extra/clang-tidy/abseil/DurationFactoryFloatCheck.cpp clang-tools-extra/clang-tidy/abseil/DurationFactoryFloatCheck.h clang-tools-extra/clang-tidy/abseil/DurationFactoryScaleCheck.h clang-tools-extra/clang-tidy/abseil/DurationSubtractionCheck.h clang-tools-extra/clang-tidy/abseil/DurationUnnecessaryConversionCheck.h clang-tools-extra/clang-tidy/abseil/FasterStrsplitDelimiterCheck.h clang-tools-extra/clang-tidy/abseil/NoInternalDependenciesCheck.h clang-tools-extra/clang-tidy/abseil/NoNamespaceCheck.h clang-tools-extra/clang-tidy/abseil/RedundantStrcatCallsCheck.h clang-tools-extra/clang-tidy/abseil/StrCatAppendCheck.h clang-tools-extra/clang-tidy/abseil/StringFindStartswithCheck.cpp clang-tools-extra/clang-tidy/abseil/StringFindStartswithCheck.h clang-tools-extra/clang-tidy/abseil/StringFindStrContainsCheck.h clang-tools-extra/clang-tidy/abseil/TimeComparisonCheck.h clang-tools-extra/clang-tidy/abseil/TimeSubtractionCheck.cpp clang-tools-extra/clang-tidy/abseil/TimeSubtractionCheck.h clang-tools-extra/clang-tidy/abseil/UpgradeDurationConversionsCheck.cpp clang-tools-extra/clang-tidy/abseil/UpgradeDurationConversionsCheck.h clang-tools-extra/clang-tidy/bugprone/BadSignalToKillThreadCheck.cpp clang-tools-extra/clang-tidy/bugprone/BranchCloneCheck.cpp clang-tools-extra/clang-tidy/bugprone/BranchCloneCheck.h clang-tools-extra/clang-tidy/bugprone/MisplacedOperatorInStrlenInAllocCheck.cpp clang-tools-extra/clang-tidy/bugprone/MisplacedPointerArithmeticInAllocCheck.cpp clang-tools-extra/clang-tidy/bugprone/NotNullTerminatedResultCheck.cpp clang-tools-extra/clang-tidy/bugprone/NotNullTerminatedResultCheck.h clang-tools-extra/clang-tidy/bugprone/PosixReturnCheck.cpp clang-tools-extra/clang-tidy/bugprone/ReservedIdentifierCheck.cpp clang-tools-extra/clang-tidy/bugprone/SuspiciousIncludeCheck.cpp clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidGotoCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/InitVariablesCheck.cpp clang-tools-extra/clang-tidy/cppcoreguidelines/InterfacesGlobalInitCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/MacroUsageCheck.cpp clang-tools-extra/clang-tidy/cppcoreguidelines/MacroUsageCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/NoMallocCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/OwningMemoryCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/ProBoundsArrayToPointerDecayCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/ProBoundsConstantArrayIndexCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/ProBoundsPointerArithmeticCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeConstCastCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeCstyleCastCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeReinterpretCastCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeStaticCastDowncastCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeUnionAccessCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeVarargCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/SlicingCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.h clang-tools-extra/clang-tidy/fuchsia/DefaultArgumentsDeclarationsCheck.cpp clang-tools-extra/clang-tidy/google/AvoidNSObjectNewCheck.cpp clang-tools-extra/clang-tidy/google/AvoidUnderscoreInGoogletestNameCheck.cpp clang-tools-extra/clang-tidy/google/UpgradeGoogletestCaseCheck.cpp clang-tools-extra/clang-tidy/hicpp/ExceptionBaseclassCheck.h clang-tools-extra/clang-tidy/hicpp/MultiwayPathsCoveredCheck.h clang-tools-extra/clang-tidy/hicpp/NoAssemblerCheck.h clang-tools-extra/clang-tidy/hicpp/SignedBitwiseCheck.h clang-tools-extra/clang-tidy/llvm/HeaderGuardCheck.cpp
[PATCH] D82661: [clang-tidy][NFC] Remove unnecessary includes throughout clang-tidy header files
njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/google-module.cpp:4 +// CHECK-DAG: {{- key: *google-readability-braces-around-statements.ShortStatementLines[[:space:]] value: *'1'}} +// CHECK-DAG: {{- key: *google-readability-function-size.StatementThreshold[[:space:]] value: *'800'}} +// CHECK-DAG: {{- key: *google-readability-namespace-comments.ShortNamespaceLines[[:space:]] value: *'10'}} aaron.ballman wrote: > I feel like these testing changes, while NFC, should be landed in a separate > patch as they don't have anything to do with the header file changes, right? You're absolutely right I must've forgot to remove them when I removed the other change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82661/new/ https://reviews.llvm.org/D82661 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D82661: [clang-tidy][NFC] Remove unnecessary includes throughout clang-tidy header files
aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, though I think this should be landed in two commits (one for the headers, one for the tests). Comment at: clang-tools-extra/test/clang-tidy/checkers/google-module.cpp:4 +// CHECK-DAG: {{- key: *google-readability-braces-around-statements.ShortStatementLines[[:space:]] value: *'1'}} +// CHECK-DAG: {{- key: *google-readability-function-size.StatementThreshold[[:space:]] value: *'800'}} +// CHECK-DAG: {{- key: *google-readability-namespace-comments.ShortNamespaceLines[[:space:]] value: *'10'}} I feel like these testing changes, while NFC, should be landed in a separate patch as they don't have anything to do with the header file changes, right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82661/new/ https://reviews.llvm.org/D82661 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D82661: [clang-tidy][NFC} Remove unnecessary includes throughout clang-tidy header files
njames93 updated this revision to Diff 273894. njames93 retitled this revision from "[clang-tidy][NFC] Remove unnecessary includes throughout clang-tidy header files" to "[clang-tidy][NFC} Remove unnecessary includes throughout clang-tidy header files". njames93 edited the summary of this revision. njames93 added a comment. Remove the changes to `std::map` -> `llvm::StringMap<...>` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82661/new/ https://reviews.llvm.org/D82661 Files: clang-tools-extra/clang-tidy/ClangTidy.cpp clang-tools-extra/clang-tidy/ClangTidy.h clang-tools-extra/clang-tidy/ClangTidyCheck.h clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h clang-tools-extra/clang-tidy/ClangTidyModule.cpp clang-tools-extra/clang-tidy/ClangTidyModule.h clang-tools-extra/clang-tidy/ClangTidyProfiling.h clang-tools-extra/clang-tidy/abseil/DurationAdditionCheck.h clang-tools-extra/clang-tidy/abseil/DurationComparisonCheck.h clang-tools-extra/clang-tidy/abseil/DurationConversionCastCheck.h clang-tools-extra/clang-tidy/abseil/DurationDivisionCheck.cpp clang-tools-extra/clang-tidy/abseil/DurationDivisionCheck.h clang-tools-extra/clang-tidy/abseil/DurationFactoryFloatCheck.cpp clang-tools-extra/clang-tidy/abseil/DurationFactoryFloatCheck.h clang-tools-extra/clang-tidy/abseil/DurationFactoryScaleCheck.h clang-tools-extra/clang-tidy/abseil/DurationSubtractionCheck.h clang-tools-extra/clang-tidy/abseil/DurationUnnecessaryConversionCheck.h clang-tools-extra/clang-tidy/abseil/FasterStrsplitDelimiterCheck.h clang-tools-extra/clang-tidy/abseil/NoInternalDependenciesCheck.h clang-tools-extra/clang-tidy/abseil/NoNamespaceCheck.h clang-tools-extra/clang-tidy/abseil/RedundantStrcatCallsCheck.h clang-tools-extra/clang-tidy/abseil/StrCatAppendCheck.h clang-tools-extra/clang-tidy/abseil/StringFindStartswithCheck.cpp clang-tools-extra/clang-tidy/abseil/StringFindStartswithCheck.h clang-tools-extra/clang-tidy/abseil/StringFindStrContainsCheck.h clang-tools-extra/clang-tidy/abseil/TimeComparisonCheck.h clang-tools-extra/clang-tidy/abseil/TimeSubtractionCheck.cpp clang-tools-extra/clang-tidy/abseil/TimeSubtractionCheck.h clang-tools-extra/clang-tidy/abseil/UpgradeDurationConversionsCheck.cpp clang-tools-extra/clang-tidy/abseil/UpgradeDurationConversionsCheck.h clang-tools-extra/clang-tidy/bugprone/BadSignalToKillThreadCheck.cpp clang-tools-extra/clang-tidy/bugprone/BranchCloneCheck.cpp clang-tools-extra/clang-tidy/bugprone/BranchCloneCheck.h clang-tools-extra/clang-tidy/bugprone/MisplacedOperatorInStrlenInAllocCheck.cpp clang-tools-extra/clang-tidy/bugprone/MisplacedPointerArithmeticInAllocCheck.cpp clang-tools-extra/clang-tidy/bugprone/NotNullTerminatedResultCheck.cpp clang-tools-extra/clang-tidy/bugprone/NotNullTerminatedResultCheck.h clang-tools-extra/clang-tidy/bugprone/PosixReturnCheck.cpp clang-tools-extra/clang-tidy/bugprone/ReservedIdentifierCheck.cpp clang-tools-extra/clang-tidy/bugprone/SuspiciousIncludeCheck.cpp clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidGotoCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/InitVariablesCheck.cpp clang-tools-extra/clang-tidy/cppcoreguidelines/InterfacesGlobalInitCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/MacroUsageCheck.cpp clang-tools-extra/clang-tidy/cppcoreguidelines/MacroUsageCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/NoMallocCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/OwningMemoryCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/ProBoundsArrayToPointerDecayCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/ProBoundsConstantArrayIndexCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/ProBoundsPointerArithmeticCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeConstCastCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeCstyleCastCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeReinterpretCastCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeStaticCastDowncastCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeUnionAccessCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeVarargCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/SlicingCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.h clang-tools-extra/clang-tidy/fuchsia/DefaultArgumentsDeclarationsCheck.cpp clang-tools-extra/clang-tidy/google/AvoidNSObjectNewCheck.cpp clang-tools-extra/clang-tidy/google/AvoidUnderscoreInGoogletestNameCheck.cpp clang-tools-extra/clang-tidy/google/UpgradeGoogletestCaseCheck.cpp clang-tools-extra/clang-tidy/hicpp/ExceptionBaseclassCheck.h
[PATCH] D82661: [clang-tidy][NFC} Remove unnecessary includes throughout clang-tidy header files
dexonsmith requested changes to this revision. dexonsmith added a comment. This revision now requires changes to proceed. > Plus replacing a few std::map with llvm::StringMap That doesn't sound NFC since it changes ordering semantics. It seems to me like it should be done separately from the rest of the patch. It would be nice to split up the rest of the patch too; besides simplifying review, if you leave the `#include` removals for a final commit it'll be easier to revert if/where necessary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82661/new/ https://reviews.llvm.org/D82661 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D82661: [clang-tidy][NFC} Remove unnecessary includes throughout clang-tidy header files
njames93 updated this revision to Diff 273792. njames93 added a comment. Herald added subscribers: usaxena95, kadircet, jkorous. Fix some issues with tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82661/new/ https://reviews.llvm.org/D82661 Files: clang-tools-extra/clang-tidy/ClangTidy.cpp clang-tools-extra/clang-tidy/ClangTidy.h clang-tools-extra/clang-tidy/ClangTidyCheck.cpp clang-tools-extra/clang-tidy/ClangTidyCheck.h clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h clang-tools-extra/clang-tidy/ClangTidyModule.cpp clang-tools-extra/clang-tidy/ClangTidyModule.h clang-tools-extra/clang-tidy/ClangTidyOptions.cpp clang-tools-extra/clang-tidy/ClangTidyOptions.h clang-tools-extra/clang-tidy/ClangTidyProfiling.h clang-tools-extra/clang-tidy/abseil/DurationAdditionCheck.h clang-tools-extra/clang-tidy/abseil/DurationComparisonCheck.h clang-tools-extra/clang-tidy/abseil/DurationConversionCastCheck.h clang-tools-extra/clang-tidy/abseil/DurationDivisionCheck.cpp clang-tools-extra/clang-tidy/abseil/DurationDivisionCheck.h clang-tools-extra/clang-tidy/abseil/DurationFactoryFloatCheck.cpp clang-tools-extra/clang-tidy/abseil/DurationFactoryFloatCheck.h clang-tools-extra/clang-tidy/abseil/DurationFactoryScaleCheck.h clang-tools-extra/clang-tidy/abseil/DurationSubtractionCheck.h clang-tools-extra/clang-tidy/abseil/DurationUnnecessaryConversionCheck.h clang-tools-extra/clang-tidy/abseil/FasterStrsplitDelimiterCheck.h clang-tools-extra/clang-tidy/abseil/NoInternalDependenciesCheck.h clang-tools-extra/clang-tidy/abseil/NoNamespaceCheck.h clang-tools-extra/clang-tidy/abseil/RedundantStrcatCallsCheck.h clang-tools-extra/clang-tidy/abseil/StrCatAppendCheck.h clang-tools-extra/clang-tidy/abseil/StringFindStartswithCheck.cpp clang-tools-extra/clang-tidy/abseil/StringFindStartswithCheck.h clang-tools-extra/clang-tidy/abseil/StringFindStrContainsCheck.h clang-tools-extra/clang-tidy/abseil/TimeComparisonCheck.h clang-tools-extra/clang-tidy/abseil/TimeSubtractionCheck.cpp clang-tools-extra/clang-tidy/abseil/TimeSubtractionCheck.h clang-tools-extra/clang-tidy/abseil/UpgradeDurationConversionsCheck.cpp clang-tools-extra/clang-tidy/abseil/UpgradeDurationConversionsCheck.h clang-tools-extra/clang-tidy/bugprone/BadSignalToKillThreadCheck.cpp clang-tools-extra/clang-tidy/bugprone/BranchCloneCheck.cpp clang-tools-extra/clang-tidy/bugprone/BranchCloneCheck.h clang-tools-extra/clang-tidy/bugprone/MisplacedOperatorInStrlenInAllocCheck.cpp clang-tools-extra/clang-tidy/bugprone/MisplacedPointerArithmeticInAllocCheck.cpp clang-tools-extra/clang-tidy/bugprone/NotNullTerminatedResultCheck.cpp clang-tools-extra/clang-tidy/bugprone/NotNullTerminatedResultCheck.h clang-tools-extra/clang-tidy/bugprone/PosixReturnCheck.cpp clang-tools-extra/clang-tidy/bugprone/ReservedIdentifierCheck.cpp clang-tools-extra/clang-tidy/bugprone/SuspiciousIncludeCheck.cpp clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidGotoCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/InitVariablesCheck.cpp clang-tools-extra/clang-tidy/cppcoreguidelines/InterfacesGlobalInitCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/MacroUsageCheck.cpp clang-tools-extra/clang-tidy/cppcoreguidelines/MacroUsageCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/NoMallocCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/OwningMemoryCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/ProBoundsArrayToPointerDecayCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/ProBoundsConstantArrayIndexCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/ProBoundsPointerArithmeticCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeConstCastCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeCstyleCastCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeReinterpretCastCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeStaticCastDowncastCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeUnionAccessCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeVarargCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/SlicingCheck.h clang-tools-extra/clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.h clang-tools-extra/clang-tidy/fuchsia/DefaultArgumentsDeclarationsCheck.cpp clang-tools-extra/clang-tidy/google/AvoidNSObjectNewCheck.cpp clang-tools-extra/clang-tidy/google/AvoidUnderscoreInGoogletestNameCheck.cpp clang-tools-extra/clang-tidy/google/UpgradeGoogletestCaseCheck.cpp clang-tools-extra/clang-tidy/hicpp/ExceptionBaseclassCheck.h clang-tools-extra/clang-tidy/hicpp/MultiwayPathsCoveredCheck.h
[PATCH] D82661: [clang-tidy][NFC} Remove unnecessary includes throughout clang-tidy header files
Eugene.Zelenko added a comment. I think will be good idea to run Include What You Use. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82661/new/ https://reviews.llvm.org/D82661 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits