[PATCH] D84599: [Index/USRGeneration] Use NamedDecl::getDeclName() instead of NamedDecl::printName in USRGenerator::EmitDeclName

[Bruno Ricci via Phabricator via cfe-commits]

riccibruno added a comment.

To make this patch more acceptable I could also add a `Visit` function for 
`DecompositionDecl` and `MSGuidDecl` such that the current behaviour is 
preserved (I won't be able to test it though since these implicit AST nodes are 
not visited).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84599/new/

https://reviews.llvm.org/D84599

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D84599: [Index/USRGeneration] Use NamedDecl::getDeclName() instead of NamedDecl::printName in USRGenerator::EmitDeclName

[Bruno Ricci via Phabricator via cfe-commits]

riccibruno added a comment.

Friendly ping on this patch; the patches depending on this patch (D84658 
 and D85033  
on Phab + others not uploaded yet) significantly improve the handling of 
unnamed entities in diagnostics.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84599/new/

https://reviews.llvm.org/D84599

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D84599: [Index/USRGeneration] Use NamedDecl::getDeclName() instead of NamedDecl::printName in USRGenerator::EmitDeclName

[Bruno Ricci via Phabricator via cfe-commits]

riccibruno added a comment.

... or if a string such as `(unnamed struct at /path/to/input.cc:1:3)` is 
suitable in an USR then `printName` can be used.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84599/new/

https://reviews.llvm.org/D84599

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits