This revision was automatically updated to reflect the committed changes. Closed by commit rG442a80292d50: [clang] Don't make synthesized accessor stub functions visible twice (authored by teemperor). Herald added a project: clang. Herald added a subscriber: cfe-commits.
Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84828/new/ https://reviews.llvm.org/D84828 Files: clang/lib/Sema/SemaDeclObjC.cpp Index: clang/lib/Sema/SemaDeclObjC.cpp =================================================================== --- clang/lib/Sema/SemaDeclObjC.cpp +++ clang/lib/Sema/SemaDeclObjC.cpp @@ -3922,15 +3922,11 @@ if (auto *OID = dyn_cast<ObjCImplementationDecl>(CurContext)) { for (auto PropImpl : OID->property_impls()) { if (auto *Getter = PropImpl->getGetterMethodDecl()) - if (Getter->isSynthesizedAccessorStub()) { - OID->makeDeclVisibleInContext(Getter); + if (Getter->isSynthesizedAccessorStub()) OID->addDecl(Getter); - } if (auto *Setter = PropImpl->getSetterMethodDecl()) - if (Setter->isSynthesizedAccessorStub()) { - OID->makeDeclVisibleInContext(Setter); + if (Setter->isSynthesizedAccessorStub()) OID->addDecl(Setter); - } } }
Index: clang/lib/Sema/SemaDeclObjC.cpp =================================================================== --- clang/lib/Sema/SemaDeclObjC.cpp +++ clang/lib/Sema/SemaDeclObjC.cpp @@ -3922,15 +3922,11 @@ if (auto *OID = dyn_cast<ObjCImplementationDecl>(CurContext)) { for (auto PropImpl : OID->property_impls()) { if (auto *Getter = PropImpl->getGetterMethodDecl()) - if (Getter->isSynthesizedAccessorStub()) { - OID->makeDeclVisibleInContext(Getter); + if (Getter->isSynthesizedAccessorStub()) OID->addDecl(Getter); - } if (auto *Setter = PropImpl->getSetterMethodDecl()) - if (Setter->isSynthesizedAccessorStub()) { - OID->makeDeclVisibleInContext(Setter); + if (Setter->isSynthesizedAccessorStub()) OID->addDecl(Setter); - } } }
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits