[PATCH] D86877: [Clang][Driver] Use full path to builtins in bare-metal toolchain

[Raul Tambre via Phabricator via cfe-commits]

tambre abandoned this revision.
tambre added a comment.

In D86877#2262448 , @phosek wrote:

> It's not clear why couldn't we support per-target runtime directory? It uses 
> the standard multiarch layout, so in you'd end up using a directory like 
> `[path/to/resource-dir]/lib/armv6m-unknown-eabi/libclang_rt.builtins.a`. I'd 
> find this more preferable for consistency with other targets, it'd also 
> enable the use of runtimes build for baremetal.

Agreed. Unfortunately I'm unable to actually get the builtins built for 
baremetal and I originally encountered this issue under circumstances I can no 
longer reproduce.
Abandoning this as a result. Hopefully someone else will be able to take it up.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86877/new/

https://reviews.llvm.org/D86877

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D86877: [Clang][Driver] Use full path to builtins in bare-metal toolchain

[Petr Hosek via Phabricator via cfe-commits]

phosek added a comment.

It's not clear why couldn't we support per-target runtime directory? It uses 
the standard multiarch layout, so in you'd end up using a directory like 
`[path/to/resource-dir]/lib/armv6m-unknown-eabi/libclang_rt.builtins.a`. I'd 
find this more preferable for consistency with other targets, it'd also enable 
the use of runtimes build for baremetal.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86877/new/

https://reviews.llvm.org/D86877

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D86877: [Clang][Driver] Use full path to builtins in bare-metal toolchain

[Raul Tambre via Phabricator via cfe-commits]

tambre added a comment.

phosek: ping


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86877/new/

https://reviews.llvm.org/D86877

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D86877: [Clang][Driver] Use full path to builtins in bare-metal toolchain

[Raul Tambre via Phabricator via cfe-commits]

tambre added a comment.

@phosek Please review again.
I've overhauled the patch as I realized that per-target runtime directories 
don't make sense for the bare-metal target, since the runtime is only 
distinguished by the //specific// architecture and nothing else.
As a result I've simply changed this into a cleanup doing the same thing as 
D59425 , which seems to have languished.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86877/new/

https://reviews.llvm.org/D86877

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits