subject:"\[PATCH\] D91109\: \[OMPIRBuilder\] Start 'Create' methods with lower case. NFC."

[PATCH] D91109: [OMPIRBuilder] Start 'Create' methods with lower case. NFC.

2020-11-10 Thread Michael Kruse via Phabricator via cfe-commits

This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGe5dba2d7e5a6: [OMPIRBuilder] Start 'Create' 
methods with lower case. NFC. (authored by Meinersbur).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91109/new/

https://reviews.llvm.org/D91109

Files:
  clang/lib/CodeGen/CGOpenMPRuntime.cpp
  clang/lib/CodeGen/CGStmtOpenMP.cpp
  llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h
  llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp
  llvm/lib/Transforms/IPO/OpenMPOpt.cpp
  llvm/unittests/Frontend/OpenMPIRBuilderTest.cpp
  mlir/lib/Target/LLVMIR/ModuleTranslation.cpp

Index: mlir/lib/Target/LLVMIR/ModuleTranslation.cpp
===
--- mlir/lib/Target/LLVMIR/ModuleTranslation.cpp
+++ mlir/lib/Target/LLVMIR/ModuleTranslation.cpp
@@ -459,7 +459,7 @@
   // above.
   llvm::OpenMPIRBuilder::InsertPointTy allocaIP(builder.saveIP());
   builder.restoreIP(
-  ompBuilder->CreateParallel(builder, allocaIP, bodyGenCB, privCB, finiCB,
+  ompBuilder->createParallel(builder, allocaIP, bodyGenCB, privCB, finiCB,
  ifCond, numThreads, pbKind, isCancellable));
   return success();
 }
@@ -475,15 +475,15 @@
   }
   return llvm::TypeSwitch(&opInst)
   .Case([&](omp::BarrierOp) {
-ompBuilder->CreateBarrier(builder.saveIP(), llvm::omp::OMPD_barrier);
+ompBuilder->createBarrier(builder.saveIP(), llvm::omp::OMPD_barrier);
 return success();
   })
   .Case([&](omp::TaskwaitOp) {
-ompBuilder->CreateTaskwait(builder.saveIP());
+ompBuilder->createTaskwait(builder.saveIP());
 return success();
   })
   .Case([&](omp::TaskyieldOp) {
-ompBuilder->CreateTaskyield(builder.saveIP());
+ompBuilder->createTaskyield(builder.saveIP());
 return success();
   })
   .Case([&](omp::FlushOp) {
@@ -495,7 +495,7 @@
 //
 // The argument list is discarded so that, flush with a list is treated
 // same as a flush without a list.
-ompBuilder->CreateFlush(builder.saveIP());
+ompBuilder->createFlush(builder.saveIP());
 return success();
   })
   .Case([&](omp::TerminatorOp) {
Index: llvm/unittests/Frontend/OpenMPIRBuilderTest.cpp
===
--- llvm/unittests/Frontend/OpenMPIRBuilderTest.cpp
+++ llvm/unittests/Frontend/OpenMPIRBuilderTest.cpp
@@ -66,14 +66,14 @@
 
   IRBuilder<> Builder(BB);
 
-  OMPBuilder.CreateBarrier({IRBuilder<>::InsertPoint()}, OMPD_for);
+  OMPBuilder.createBarrier({IRBuilder<>::InsertPoint()}, OMPD_for);
   EXPECT_TRUE(M->global_empty());
   EXPECT_EQ(M->size(), 1U);
   EXPECT_EQ(F->size(), 1U);
   EXPECT_EQ(BB->size(), 0U);
 
   OpenMPIRBuilder::LocationDescription Loc({Builder.saveIP()});
-  OMPBuilder.CreateBarrier(Loc, OMPD_for);
+  OMPBuilder.createBarrier(Loc, OMPD_for);
   EXPECT_FALSE(M->global_empty());
   EXPECT_EQ(M->size(), 3U);
   EXPECT_EQ(F->size(), 1U);
@@ -116,7 +116,7 @@
   IRBuilder<> Builder(BB);
 
   OpenMPIRBuilder::LocationDescription Loc({Builder.saveIP()});
-  auto NewIP = OMPBuilder.CreateCancel(Loc, nullptr, OMPD_parallel);
+  auto NewIP = OMPBuilder.createCancel(Loc, nullptr, OMPD_parallel);
   Builder.restoreIP(NewIP);
   EXPECT_FALSE(M->global_empty());
   EXPECT_EQ(M->size(), 3U);
@@ -171,7 +171,7 @@
   IRBuilder<> Builder(BB);
 
   OpenMPIRBuilder::LocationDescription Loc({Builder.saveIP()});
-  auto NewIP = OMPBuilder.CreateCancel(Loc, Builder.getTrue(), OMPD_parallel);
+  auto NewIP = OMPBuilder.createCancel(Loc, Builder.getTrue(), OMPD_parallel);
   Builder.restoreIP(NewIP);
   EXPECT_FALSE(M->global_empty());
   EXPECT_EQ(M->size(), 3U);
@@ -232,7 +232,7 @@
   IRBuilder<> Builder(BB);
 
   OpenMPIRBuilder::LocationDescription Loc({Builder.saveIP()});
-  auto NewIP = OMPBuilder.CreateBarrier(Loc, OMPD_for);
+  auto NewIP = OMPBuilder.createBarrier(Loc, OMPD_for);
   Builder.restoreIP(NewIP);
   EXPECT_FALSE(M->global_empty());
   EXPECT_EQ(M->size(), 3U);
@@ -278,7 +278,7 @@
   IRBuilder<> Builder(BB);
 
   OpenMPIRBuilder::LocationDescription Loc({Builder.saveIP(), DL});
-  OMPBuilder.CreateBarrier(Loc, OMPD_for);
+  OMPBuilder.createBarrier(Loc, OMPD_for);
   CallInst *GTID = dyn_cast(&BB->front());
   CallInst *Barrier = dyn_cast(GTID->getNextNode());
   EXPECT_EQ(GTID->getDebugLoc(), DL);
@@ -365,7 +365,7 @@
   IRBuilder<>::InsertPoint AllocaIP(&F->getEntryBlock(),
 F->getEntryBlock().getFirstInsertionPt());
   IRBuilder<>::InsertPoint AfterIP =
-  OMPBuilder.CreateParallel(Loc, AllocaIP, BodyGenCB, PrivCB, FiniCB,
+  OMPBuilder.createParallel(Loc, AllocaIP, BodyGenCB, PrivCB, FiniCB,
 nullptr, nullptr, OMP_PROC_BIND_default, false);
   EXPECT_EQ(NumBodiesGenerated, 1U);
   EXPECT_EQ(NumPr

[PATCH] D91109: [OMPIRBuilder] Start 'Create' methods with lower case. NFC.

2020-11-10 Thread Michael Kruse via Phabricator via cfe-commits

Meinersbur created this revision.
Meinersbur added a reviewer: jdoerfert.
Meinersbur added a project: OpenMP.
Herald added subscribers: cfe-commits, rdzhabarov, tatianashp, msifontes, 
jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, 
arpith-jacob, antiagainst, shauheen, rriddle, mehdi_amini, hiraditya.
Herald added a reviewer: ftynse.
Herald added projects: clang, MLIR, LLVM.
Meinersbur requested review of this revision.
Herald added subscribers: sstefan1, stephenneuendorffer, nicolasvasilache.

For consistency with the IRBuilder, OpenMPIRBuilder has method names starting 
with 'Create'. However, the LLVM coding style has methods names starting with 
lower case letters, as all other OpenMPIRBuilder already methods do. The 
clang-tidy configuration used by Phabricator also warns about the naming 
violation, adding noise to the reviews.

This patch renames all `OpenMPIRBuilder::CreateXYZ` methods to 
`OpenMPIRBuilder::createXYZ`, and updates all in-tree callers.

I tested check-llvm, check-clang, check-mlir and check-flang to ensure that I 
did not miss a caller.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D91109

Files:
  clang/lib/CodeGen/CGOpenMPRuntime.cpp
  clang/lib/CodeGen/CGStmtOpenMP.cpp
  llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h
  llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp
  llvm/lib/Transforms/IPO/OpenMPOpt.cpp
  llvm/unittests/Frontend/OpenMPIRBuilderTest.cpp
  mlir/lib/Target/LLVMIR/ModuleTranslation.cpp

Index: mlir/lib/Target/LLVMIR/ModuleTranslation.cpp
===
--- mlir/lib/Target/LLVMIR/ModuleTranslation.cpp
+++ mlir/lib/Target/LLVMIR/ModuleTranslation.cpp
@@ -459,7 +459,7 @@
   // above.
   llvm::OpenMPIRBuilder::InsertPointTy allocaIP(builder.saveIP());
   builder.restoreIP(
-  ompBuilder->CreateParallel(builder, allocaIP, bodyGenCB, privCB, finiCB,
+  ompBuilder->createParallel(builder, allocaIP, bodyGenCB, privCB, finiCB,
  ifCond, numThreads, pbKind, isCancellable));
   return success();
 }
@@ -475,15 +475,15 @@
   }
   return llvm::TypeSwitch(&opInst)
   .Case([&](omp::BarrierOp) {
-ompBuilder->CreateBarrier(builder.saveIP(), llvm::omp::OMPD_barrier);
+ompBuilder->createBarrier(builder.saveIP(), llvm::omp::OMPD_barrier);
 return success();
   })
   .Case([&](omp::TaskwaitOp) {
-ompBuilder->CreateTaskwait(builder.saveIP());
+ompBuilder->createTaskwait(builder.saveIP());
 return success();
   })
   .Case([&](omp::TaskyieldOp) {
-ompBuilder->CreateTaskyield(builder.saveIP());
+ompBuilder->createTaskyield(builder.saveIP());
 return success();
   })
   .Case([&](omp::FlushOp) {
@@ -495,7 +495,7 @@
 //
 // The argument list is discarded so that, flush with a list is treated
 // same as a flush without a list.
-ompBuilder->CreateFlush(builder.saveIP());
+ompBuilder->createFlush(builder.saveIP());
 return success();
   })
   .Case([&](omp::TerminatorOp) {
Index: llvm/unittests/Frontend/OpenMPIRBuilderTest.cpp
===
--- llvm/unittests/Frontend/OpenMPIRBuilderTest.cpp
+++ llvm/unittests/Frontend/OpenMPIRBuilderTest.cpp
@@ -66,14 +66,14 @@
 
   IRBuilder<> Builder(BB);
 
-  OMPBuilder.CreateBarrier({IRBuilder<>::InsertPoint()}, OMPD_for);
+  OMPBuilder.createBarrier({IRBuilder<>::InsertPoint()}, OMPD_for);
   EXPECT_TRUE(M->global_empty());
   EXPECT_EQ(M->size(), 1U);
   EXPECT_EQ(F->size(), 1U);
   EXPECT_EQ(BB->size(), 0U);
 
   OpenMPIRBuilder::LocationDescription Loc({Builder.saveIP()});
-  OMPBuilder.CreateBarrier(Loc, OMPD_for);
+  OMPBuilder.createBarrier(Loc, OMPD_for);
   EXPECT_FALSE(M->global_empty());
   EXPECT_EQ(M->size(), 3U);
   EXPECT_EQ(F->size(), 1U);
@@ -116,7 +116,7 @@
   IRBuilder<> Builder(BB);
 
   OpenMPIRBuilder::LocationDescription Loc({Builder.saveIP()});
-  auto NewIP = OMPBuilder.CreateCancel(Loc, nullptr, OMPD_parallel);
+  auto NewIP = OMPBuilder.createCancel(Loc, nullptr, OMPD_parallel);
   Builder.restoreIP(NewIP);
   EXPECT_FALSE(M->global_empty());
   EXPECT_EQ(M->size(), 3U);
@@ -171,7 +171,7 @@
   IRBuilder<> Builder(BB);
 
   OpenMPIRBuilder::LocationDescription Loc({Builder.saveIP()});
-  auto NewIP = OMPBuilder.CreateCancel(Loc, Builder.getTrue(), OMPD_parallel);
+  auto NewIP = OMPBuilder.createCancel(Loc, Builder.getTrue(), OMPD_parallel);
   Builder.restoreIP(NewIP);
   EXPECT_FALSE(M->global_empty());
   EXPECT_EQ(M->size(), 3U);
@@ -232,7 +232,7 @@
   IRBuilder<> Builder(BB);
 
   OpenMPIRBuilder::LocationDescription Loc({Builder.saveIP()});
-  auto NewIP = OMPBuilder.CreateBarrier(Loc, OMPD_for);
+  auto NewIP = OMPBuilder.createBarrier(Loc, OMPD_for);
   Builder.restoreIP(NewIP);
   EXPECT_FALSE(M->global_empty());
   EXPECT_EQ(M->size(), 3U);
@@ -278,7 +278,7 @@
   IRBuilder<> Bui

[PATCH] D91109: [OMPIRBuilder] Start 'Create' methods with lower case. NFC.

2020-11-10 Thread Michael Kruse via Phabricator via cfe-commits

Meinersbur updated this revision to Diff 304013.
Meinersbur added a comment.

Last update pushed only the change


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91109/new/

https://reviews.llvm.org/D91109

Files:
  clang/lib/CodeGen/CGOpenMPRuntime.cpp
  clang/lib/CodeGen/CGStmtOpenMP.cpp
  llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h
  llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp
  llvm/lib/Transforms/IPO/OpenMPOpt.cpp
  llvm/unittests/Frontend/OpenMPIRBuilderTest.cpp
  mlir/lib/Target/LLVMIR/ModuleTranslation.cpp

Index: mlir/lib/Target/LLVMIR/ModuleTranslation.cpp
===
--- mlir/lib/Target/LLVMIR/ModuleTranslation.cpp
+++ mlir/lib/Target/LLVMIR/ModuleTranslation.cpp
@@ -459,7 +459,7 @@
   // above.
   llvm::OpenMPIRBuilder::InsertPointTy allocaIP(builder.saveIP());
   builder.restoreIP(
-  ompBuilder->CreateParallel(builder, allocaIP, bodyGenCB, privCB, finiCB,
+  ompBuilder->createParallel(builder, allocaIP, bodyGenCB, privCB, finiCB,
  ifCond, numThreads, pbKind, isCancellable));
   return success();
 }
@@ -475,15 +475,15 @@
   }
   return llvm::TypeSwitch(&opInst)
   .Case([&](omp::BarrierOp) {
-ompBuilder->CreateBarrier(builder.saveIP(), llvm::omp::OMPD_barrier);
+ompBuilder->createBarrier(builder.saveIP(), llvm::omp::OMPD_barrier);
 return success();
   })
   .Case([&](omp::TaskwaitOp) {
-ompBuilder->CreateTaskwait(builder.saveIP());
+ompBuilder->createTaskwait(builder.saveIP());
 return success();
   })
   .Case([&](omp::TaskyieldOp) {
-ompBuilder->CreateTaskyield(builder.saveIP());
+ompBuilder->createTaskyield(builder.saveIP());
 return success();
   })
   .Case([&](omp::FlushOp) {
@@ -495,7 +495,7 @@
 //
 // The argument list is discarded so that, flush with a list is treated
 // same as a flush without a list.
-ompBuilder->CreateFlush(builder.saveIP());
+ompBuilder->createFlush(builder.saveIP());
 return success();
   })
   .Case([&](omp::TerminatorOp) {
Index: llvm/unittests/Frontend/OpenMPIRBuilderTest.cpp
===
--- llvm/unittests/Frontend/OpenMPIRBuilderTest.cpp
+++ llvm/unittests/Frontend/OpenMPIRBuilderTest.cpp
@@ -66,14 +66,14 @@
 
   IRBuilder<> Builder(BB);
 
-  OMPBuilder.CreateBarrier({IRBuilder<>::InsertPoint()}, OMPD_for);
+  OMPBuilder.createBarrier({IRBuilder<>::InsertPoint()}, OMPD_for);
   EXPECT_TRUE(M->global_empty());
   EXPECT_EQ(M->size(), 1U);
   EXPECT_EQ(F->size(), 1U);
   EXPECT_EQ(BB->size(), 0U);
 
   OpenMPIRBuilder::LocationDescription Loc({Builder.saveIP()});
-  OMPBuilder.CreateBarrier(Loc, OMPD_for);
+  OMPBuilder.createBarrier(Loc, OMPD_for);
   EXPECT_FALSE(M->global_empty());
   EXPECT_EQ(M->size(), 3U);
   EXPECT_EQ(F->size(), 1U);
@@ -116,7 +116,7 @@
   IRBuilder<> Builder(BB);
 
   OpenMPIRBuilder::LocationDescription Loc({Builder.saveIP()});
-  auto NewIP = OMPBuilder.CreateCancel(Loc, nullptr, OMPD_parallel);
+  auto NewIP = OMPBuilder.createCancel(Loc, nullptr, OMPD_parallel);
   Builder.restoreIP(NewIP);
   EXPECT_FALSE(M->global_empty());
   EXPECT_EQ(M->size(), 3U);
@@ -171,7 +171,7 @@
   IRBuilder<> Builder(BB);
 
   OpenMPIRBuilder::LocationDescription Loc({Builder.saveIP()});
-  auto NewIP = OMPBuilder.CreateCancel(Loc, Builder.getTrue(), OMPD_parallel);
+  auto NewIP = OMPBuilder.createCancel(Loc, Builder.getTrue(), OMPD_parallel);
   Builder.restoreIP(NewIP);
   EXPECT_FALSE(M->global_empty());
   EXPECT_EQ(M->size(), 3U);
@@ -232,7 +232,7 @@
   IRBuilder<> Builder(BB);
 
   OpenMPIRBuilder::LocationDescription Loc({Builder.saveIP()});
-  auto NewIP = OMPBuilder.CreateBarrier(Loc, OMPD_for);
+  auto NewIP = OMPBuilder.createBarrier(Loc, OMPD_for);
   Builder.restoreIP(NewIP);
   EXPECT_FALSE(M->global_empty());
   EXPECT_EQ(M->size(), 3U);
@@ -278,7 +278,7 @@
   IRBuilder<> Builder(BB);
 
   OpenMPIRBuilder::LocationDescription Loc({Builder.saveIP(), DL});
-  OMPBuilder.CreateBarrier(Loc, OMPD_for);
+  OMPBuilder.createBarrier(Loc, OMPD_for);
   CallInst *GTID = dyn_cast(&BB->front());
   CallInst *Barrier = dyn_cast(GTID->getNextNode());
   EXPECT_EQ(GTID->getDebugLoc(), DL);
@@ -365,7 +365,7 @@
   IRBuilder<>::InsertPoint AllocaIP(&F->getEntryBlock(),
 F->getEntryBlock().getFirstInsertionPt());
   IRBuilder<>::InsertPoint AfterIP =
-  OMPBuilder.CreateParallel(Loc, AllocaIP, BodyGenCB, PrivCB, FiniCB,
+  OMPBuilder.createParallel(Loc, AllocaIP, BodyGenCB, PrivCB, FiniCB,
 nullptr, nullptr, OMP_PROC_BIND_default, false);
   EXPECT_EQ(NumBodiesGenerated, 1U);
   EXPECT_EQ(NumPrivatizedVars, 1U);
@@ -445,7 +445,7 @@
 CGBB->getTerminator()->eraseFromParent();
 ;
 
-IRBuilder<>::InsertPoint AfterIP = O

[PATCH] D91109: [OMPIRBuilder] Start 'Create' methods with lower case. NFC.

2020-11-09 Thread Fady Ghanim via Phabricator via cfe-commits

fghanim accepted this revision.
fghanim added a comment.

LGTM


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91109/new/

https://reviews.llvm.org/D91109

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D91109: [OMPIRBuilder] Start 'Create' methods with lower case. NFC.

2020-11-09 Thread Michael Kruse via Phabricator via cfe-commits

Meinersbur updated this revision to Diff 304011.
Meinersbur added a comment.

Missed reference of Create in comments


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91109/new/

https://reviews.llvm.org/D91109

Files:
  llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h


Index: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h
===
--- llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h
+++ llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h
@@ -58,7 +58,7 @@
 
   struct FinalizationInfo {
 /// The finalization callback provided by the last in-flight invocation of
-/// Create for the directive of kind DK.
+/// create for the directive of kind DK.
 FinalizeCallbackTy FiniCB;
 
 /// The directive kind of the innermost directive that has an associated


Index: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h
===
--- llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h
+++ llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h
@@ -58,7 +58,7 @@
 
   struct FinalizationInfo {
 /// The finalization callback provided by the last in-flight invocation of
-/// Create for the directive of kind DK.
+/// create for the directive of kind DK.
 FinalizeCallbackTy FiniCB;
 
 /// The directive kind of the innermost directive that has an associated
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D91109: [OMPIRBuilder] Start 'Create' methods with lower case. NFC.

[PATCH] D91109: [OMPIRBuilder] Start 'Create' methods with lower case. NFC.

[PATCH] D91109: [OMPIRBuilder] Start 'Create' methods with lower case. NFC.

[PATCH] D91109: [OMPIRBuilder] Start 'Create' methods with lower case. NFC.

[PATCH] D91109: [OMPIRBuilder] Start 'Create' methods with lower case. NFC.

5 matches

Site Navigation

Mail list logo

Footer information