[PATCH] D96971: Allow but ignore `-Wreturn-std-move-in-c++11`
amccarth abandoned this revision. amccarth added a comment. Fair enough. I'm continuing the whack-a-mole game for the Chromium third-parties. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96971/new/ https://reviews.llvm.org/D96971 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D96971: Allow but ignore `-Wreturn-std-move-in-c++11`
Quuxplusone accepted this revision. Quuxplusone added a comment. This revision is now accepted and ready to land. FWIW, no particular comment from me. I agree with everything @thakis said. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96971/new/ https://reviews.llvm.org/D96971 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D96971: Allow but ignore `-Wreturn-std-move-in-c++11`
thakis added a comment. Since the fix for this seems to be "just remove the flag", and since the flag can be removed while on the old clang version without problems, it's possible to migrate to the new way without having to do this at the same time as a compiler update already. So I'm not sure we need this. The situation we're trying to avoid is where old clang has one way of doing things, new clang a new way, and you need to switch ways at the same time as updating compilers. It's better to add the new way while keeping old way working for a while so that you can update clang and then switch to the new way, and then we can remove support for the old way. But in this case it looks like current clang supports old and new way already (?) so I'm not sure we need this. If others think this is useful, there's little harm in accepting this for a while either though. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96971/new/ https://reviews.llvm.org/D96971 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D96971: Allow but ignore `-Wreturn-std-move-in-c++11`
amccarth created this revision. amccarth added reviewers: thakis, nullptr.cpp. amccarth requested review of this revision. This warning is no longer needed, but at least a few open source projects still build with this option (and `-Werror`). Accepting but ignoring the option keeps these projects building. https://reviews.llvm.org/D96971 Files: clang/include/clang/Basic/DiagnosticGroups.td Index: clang/include/clang/Basic/DiagnosticGroups.td === --- clang/include/clang/Basic/DiagnosticGroups.td +++ clang/include/clang/Basic/DiagnosticGroups.td @@ -499,6 +499,7 @@ def Padded : DiagGroup<"padded">; def PessimizingMove : DiagGroup<"pessimizing-move">; +def : DiagGroup<"return-std-move-in-c++11">; def ReturnStdMove : DiagGroup<"return-std-move">; def PointerArith : DiagGroup<"pointer-arith">; Index: clang/include/clang/Basic/DiagnosticGroups.td === --- clang/include/clang/Basic/DiagnosticGroups.td +++ clang/include/clang/Basic/DiagnosticGroups.td @@ -499,6 +499,7 @@ def Padded : DiagGroup<"padded">; def PessimizingMove : DiagGroup<"pessimizing-move">; +def : DiagGroup<"return-std-move-in-c++11">; def ReturnStdMove : DiagGroup<"return-std-move">; def PointerArith : DiagGroup<"pointer-arith">; ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
