[PATCH] D97510: [AArch64][Docs] Release notes 12.x on outline atomics

[Pavel Iliin via Phabricator via cfe-commits]

ilinpv closed this revision.
ilinpv added a comment.

Tim, thank you for review, noticed typos and overall support to outline atomics 
patches!
Notes pushed rG98f06b16a313ece593f5711778d7da9037f3a2ef 



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97510/new/

https://reviews.llvm.org/D97510

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D97510: [AArch64][Docs] Release notes 12.x on outline atomics

[Tim Northover via Phabricator via cfe-commits]

t.p.northover accepted this revision.
t.p.northover added a comment.
This revision is now accepted and ready to land.

I think this is fine.




Comment at: clang/docs/ReleaseNotes.rst:82
+  if compilation target supports LSE. Atomic instructions are used directly in
+  that case. The options behaviour mirrors GCC, the helpers are implemented
+  both in compiler-rt and libgcc.

Feel free to ignore since they're so minor, but if you're looking for more 
typos to fix:

  * The comma after "do not apply" is unnecessary.
  * "the compilation target" would be a bit more natural.
  * Missing apostrophe in "option's behaviour".

No need to reupload to Phab as far as I'm concerned either way.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97510/new/

https://reviews.llvm.org/D97510

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D97510: [AArch64][Docs] Release notes 12.x on outline atomics

[Pavel Iliin via Phabricator via cfe-commits]

ilinpv updated this revision to Diff 326550.
ilinpv added a comment.

Fixing typos


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97510/new/

https://reviews.llvm.org/D97510

Files:
  clang/docs/ReleaseNotes.rst


Index: clang/docs/ReleaseNotes.rst
===
--- clang/docs/ReleaseNotes.rst
+++ clang/docs/ReleaseNotes.rst
@@ -73,6 +73,15 @@
 
 - ...
 
+- AArch64 options ``-moutline-atomics``, ``-mno-outline-atomics`` to enable
+  and disable calls to helper functions implementing atomic operations. These
+  out-of-line helpers like '__aarch64_cas8_relax' will detect at runtime
+  AArch64 Large System Extensions (LSE) availability and either use their
+  atomic instructions, or fall back to LL/SC loop. These options do not apply,
+  if compilation target supports LSE. Atomic instructions are used directly in
+  that case. The options behaviour mirrors GCC, the helpers are implemented
+  both in compiler-rt and libgcc.
+
 - -fpch-codegen and -fpch-debuginfo generate shared code and/or debuginfo
   for contents of a precompiled header in a separate object file. This object
   file needs to be linked in, but its contents do not need to be generated


Index: clang/docs/ReleaseNotes.rst
===
--- clang/docs/ReleaseNotes.rst
+++ clang/docs/ReleaseNotes.rst
@@ -73,6 +73,15 @@
 
 - ...
 
+- AArch64 options ``-moutline-atomics``, ``-mno-outline-atomics`` to enable
+  and disable calls to helper functions implementing atomic operations. These
+  out-of-line helpers like '__aarch64_cas8_relax' will detect at runtime
+  AArch64 Large System Extensions (LSE) availability and either use their
+  atomic instructions, or fall back to LL/SC loop. These options do not apply,
+  if compilation target supports LSE. Atomic instructions are used directly in
+  that case. The options behaviour mirrors GCC, the helpers are implemented
+  both in compiler-rt and libgcc.
+
 - -fpch-codegen and -fpch-debuginfo generate shared code and/or debuginfo
   for contents of a precompiled header in a separate object file. This object
   file needs to be linked in, but its contents do not need to be generated
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D97510: [AArch64][Docs] Release notes 12.x on outline atomics

[Pavel Iliin via Phabricator via cfe-commits]

ilinpv created this revision.
ilinpv added reviewers: willlovett, ktkachov.
Herald added subscribers: danielkiss, jfb, kristof.beyls.
ilinpv requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

Description for AArch64 -moutline-atomics, -mno-outline-atomics
options added to release notes.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D97510

Files:
  clang/docs/ReleaseNotes.rst


Index: clang/docs/ReleaseNotes.rst
===
--- clang/docs/ReleaseNotes.rst
+++ clang/docs/ReleaseNotes.rst
@@ -73,6 +73,15 @@
 
 - ...
 
+- AArch64 options ``-moutline-atomics``, ``-mno-outline-atomics`` to enable
+  and disable calls to helper functions implementing atomic operations. These
+  out-of-line helpers like '__aarch64_cas8_relax' will detect at runtime
+  AArch64 Large System Extensions (LSE) availability and either use their
+  atomic instructions, or falls back to LL/SC loop. These options do not apply,
+  if compilation target supports LSE. Atomic instruction are used directly in
+  that case. The options behaviour mirrors GCC, the helpers are implemented
+  both in compiler-rt and libgcc.
+
 - -fpch-codegen and -fpch-debuginfo generate shared code and/or debuginfo
   for contents of a precompiled header in a separate object file. This object
   file needs to be linked in, but its contents do not need to be generated


Index: clang/docs/ReleaseNotes.rst
===
--- clang/docs/ReleaseNotes.rst
+++ clang/docs/ReleaseNotes.rst
@@ -73,6 +73,15 @@
 
 - ...
 
+- AArch64 options ``-moutline-atomics``, ``-mno-outline-atomics`` to enable
+  and disable calls to helper functions implementing atomic operations. These
+  out-of-line helpers like '__aarch64_cas8_relax' will detect at runtime
+  AArch64 Large System Extensions (LSE) availability and either use their
+  atomic instructions, or falls back to LL/SC loop. These options do not apply,
+  if compilation target supports LSE. Atomic instruction are used directly in
+  that case. The options behaviour mirrors GCC, the helpers are implemented
+  both in compiler-rt and libgcc.
+
 - -fpch-codegen and -fpch-debuginfo generate shared code and/or debuginfo
   for contents of a precompiled header in a separate object file. This object
   file needs to be linked in, but its contents do not need to be generated
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits