[PATCH] D97817: [CMake] Rename check-clang-tools to check-clang-tools-extra

[Shoaib Meenai via Phabricator via cfe-commits]

smeenai added inline comments.



Comment at: clang-tools-extra/test/CMakeLists.txt:81
 
-add_lit_testsuite(check-clang-tools "Running the Clang extra tools' regression 
tests"
+add_lit_testsuite(check-clang-tools-extra "Running the Clang tools extra' 
regression tests"
   ${CMAKE_CURRENT_BINARY_DIR}

Nit: You need an explicit "'s" now (as in "Clang tools extra's regression 
tests"), since "extra" doesn't end with an s.



Comment at: clang-tools-extra/test/CMakeLists.txt:87
 
-set_target_properties(check-clang-tools PROPERTIES FOLDER "Clang extra tools' 
tests")
+set_target_properties(check-clang-tools-extra PROPERTIES FOLDER "Clang tools 
extra' tests")
 

Same here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97817/new/

https://reviews.llvm.org/D97817

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D97817: [CMake] Rename check-clang-tools to check-clang-tools-extra

[Shoaib Meenai via Phabricator via cfe-commits]

smeenai accepted this revision.
smeenai added a comment.
This revision is now accepted and ready to land.

LGTM.

If you care about eventually getting rid of the old `check-clang-tools` alias, 
you'd want to have a mailing list announcement/deprecation notices/etc. (I 
don't think leaving it around does any harm though.)

Might want to add a release notes entry?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97817/new/

https://reviews.llvm.org/D97817

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D97817: [CMake] Rename check-clang-tools to check-clang-tools-extra

[Petr Hosek via Phabricator via cfe-commits]

phosek created this revision.
phosek added a reviewer: smeenai.
Herald added a subscriber: mgorny.
phosek requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

Match the top-level project name (that is the name developers would use
in LLVM_ENABLE_PROJECTS) with the name of the target, and provide alias
for backwards compatibility.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D97817

Files:
  clang-tools-extra/test/CMakeLists.txt


Index: clang-tools-extra/test/CMakeLists.txt
===
--- clang-tools-extra/test/CMakeLists.txt
+++ clang-tools-extra/test/CMakeLists.txt
@@ -78,14 +78,18 @@
   endif()
 endforeach()
 
-add_lit_testsuite(check-clang-tools "Running the Clang extra tools' regression 
tests"
+add_lit_testsuite(check-clang-tools-extra "Running the Clang tools extra' 
regression tests"
   ${CMAKE_CURRENT_BINARY_DIR}
   DEPENDS ${CLANG_TOOLS_TEST_DEPS}
   ARGS ${CLANG_TOOLS_TEST_EXTRA_ARGS}
   )
 
-set_target_properties(check-clang-tools PROPERTIES FOLDER "Clang extra tools' 
tests")
+set_target_properties(check-clang-tools-extra PROPERTIES FOLDER "Clang tools 
extra' tests")
 
-add_lit_testsuites(CLANG-EXTRA ${CMAKE_CURRENT_SOURCE_DIR}
+add_lit_testsuites(CLANG-TOOLS-EXTRA ${CMAKE_CURRENT_SOURCE_DIR}
   DEPENDS ${CLANG_TOOLS_TEST_DEPS}
   )
+
+# Provide `check-clang-tools` alias for backwards compatibility.
+add_custom_target(check-clang-tools)
+add_dependencies(check-clang-tools check-clang-tools-extra)


Index: clang-tools-extra/test/CMakeLists.txt
===
--- clang-tools-extra/test/CMakeLists.txt
+++ clang-tools-extra/test/CMakeLists.txt
@@ -78,14 +78,18 @@
   endif()
 endforeach()
 
-add_lit_testsuite(check-clang-tools "Running the Clang extra tools' regression tests"
+add_lit_testsuite(check-clang-tools-extra "Running the Clang tools extra' regression tests"
   ${CMAKE_CURRENT_BINARY_DIR}
   DEPENDS ${CLANG_TOOLS_TEST_DEPS}
   ARGS ${CLANG_TOOLS_TEST_EXTRA_ARGS}
   )
 
-set_target_properties(check-clang-tools PROPERTIES FOLDER "Clang extra tools' tests")
+set_target_properties(check-clang-tools-extra PROPERTIES FOLDER "Clang tools extra' tests")
 
-add_lit_testsuites(CLANG-EXTRA ${CMAKE_CURRENT_SOURCE_DIR}
+add_lit_testsuites(CLANG-TOOLS-EXTRA ${CMAKE_CURRENT_SOURCE_DIR}
   DEPENDS ${CLANG_TOOLS_TEST_DEPS}
   )
+
+# Provide `check-clang-tools` alias for backwards compatibility.
+add_custom_target(check-clang-tools)
+add_dependencies(check-clang-tools check-clang-tools-extra)
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits