Re: [PATCH] Fix stack overflow in MSVC unqualified type lookup logic
Thanks for the patch and report!
Can this check be defeated with mutually recursive class template
inheritance? I was thinking something like this:
...
template
struct FooWrapper : FooTemplated { };
// Full template spec
template
class FooTemplated : public FooWrapper {
...
Maybe we should use a set of visited RDs?
On Fri, May 27, 2016 at 9:56 PM, Will Wilson wrote:
> Hi Alexey,
>
> A customer encountered a stack overflow in the code from r229817. I've
> created a small repro for testing the issue and a fix. The fix should also
> better deal with lookup into partially specialized base templates.
>
> Test case included and tested against latest trunk.
>
> Let me know if it looks acceptable!
>
> Cheers,
> Will.
>
> --
> *Indefiant *: http://www.indefiant.com
> Home of Recode : Runtime C++ Editing for VS
>
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [PATCH] Fix stack overflow in MSVC unqualified type lookup logic
Hi Alexey, On 31 May 2016 at 12:25, Alexey Bataev wrote: > Hi Will, > Thanks for the report and sorry for a delay with answer. Generally, your > patch looks good with some small nits. I can fix some minor issues like > extra braces etc. and commit it if you don't mind. > Sure thing. Commit away! Thanks, Will. -- *Indefiant *: http://www.indefiant.com Home of Recode : Runtime C++ Editing for VS ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [PATCH] Fix stack overflow in MSVC unqualified type lookup logic
Hi Will, Thanks for the report and sorry for a delay with answer. Generally, your patch looks good with some small nits. I can fix some minor issues like extra braces etc. and commit it if you don't mind. Best regards, Alexey Bataev = Software Engineer Intel Compiler Team 28.05.2016 7:56, Will Wilson пишет: Hi Alexey, A customer encountered a stack overflow in the code from r229817. I've created a small repro for testing the issue and a fix. The fix should also better deal with lookup into partially specialized base templates. Test case included and tested against latest trunk. Let me know if it looks acceptable! Cheers, Will. -- Indefiant : http://www.indefiant.com Home of Recode : Runtime C++ Editing for VS ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] Fix stack overflow in MSVC unqualified type lookup logic
Hi Alexey, A customer encountered a stack overflow in the code from r229817. I've created a small repro for testing the issue and a fix. The fix should also better deal with lookup into partially specialized base templates. Test case included and tested against latest trunk. Let me know if it looks acceptable! Cheers, Will. -- *Indefiant *: http://www.indefiant.com Home of Recode : Runtime C++ Editing for VS msvc_partial_template_lookup.patch Description: Binary data ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
