[clang] [Clang] Pass -fseparate-named-sections from the driver (PR #91567)

2024-05-10 Thread Petr Hosek via cfe-commits 

https://github.com/petrhosek closed 
https://github.com/llvm/llvm-project/pull/91567
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Pass -fseparate-named-sections from the driver (PR #91567)

2024-05-10 Thread Petr Hosek via cfe-commits 

https://github.com/petrhosek updated 
https://github.com/llvm/llvm-project/pull/91567

>From ca2b9d52d31866a657e2eb19585cdcd11bcad7d3 Mon Sep 17 00:00:00 2001
From: Petr Hosek 
Date: Thu, 9 May 2024 00:28:33 -0700
Subject: [PATCH 1/2] [Clang] Pass -fseparate-named-sections from the driver

This is a follow up to #91028.
---
 clang/lib/Driver/ToolChains/Clang.cpp | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/clang/lib/Driver/ToolChains/Clang.cpp 
b/clang/lib/Driver/ToolChains/Clang.cpp
index 0a2ea96de7382..ceb5eb835ddce 100644
--- a/clang/lib/Driver/ToolChains/Clang.cpp
+++ b/clang/lib/Driver/ToolChains/Clang.cpp
@@ -6116,6 +6116,8 @@ void Clang::ConstructJob(Compilation &C, const JobAction 
&JA,
 
   Args.addOptOutFlag(CmdArgs, options::OPT_funique_section_names,
  options::OPT_fno_unique_section_names);
+  Args.addOptInFlag(CmdArgs, options::OPT_fseparate_named_sections,
+options::OPT_fno_separate_named_sections);
   Args.addOptInFlag(CmdArgs, options::OPT_funique_internal_linkage_names,
 options::OPT_fno_unique_internal_linkage_names);
   Args.addOptInFlag(CmdArgs, options::OPT_funique_basic_block_section_names,

>From 9a7a23e62fca9bb2c3257732d6dcc66a2240c042 Mon Sep 17 00:00:00 2001
From: Petr Hosek 
Date: Fri, 10 May 2024 00:29:28 -0700
Subject: [PATCH 2/2] Add test

---
 clang/test/Driver/fseparate-named-sections.c | 4 
 1 file changed, 4 insertions(+)
 create mode 100644 clang/test/Driver/fseparate-named-sections.c

diff --git a/clang/test/Driver/fseparate-named-sections.c 
b/clang/test/Driver/fseparate-named-sections.c
new file mode 100644
index 0..6264b8fcf0d84
--- /dev/null
+++ b/clang/test/Driver/fseparate-named-sections.c
@@ -0,0 +1,4 @@
+// RUN: %clang -### -fseparate-named-sections %s -c 2>&1 | FileCheck 
-check-prefix=CHECK-OPT %s
+// RUN: %clang -### -fseparate-named-sections -fno-separate-named-sections %s 
-c 2>&1 | FileCheck -check-prefix=CHECK-NOOPT %s
+// CHECK-OPT: "-fseparate-named-sections"
+// CHECK-NOOPT-NOT: "-fseparate-named-sections"

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Pass -fseparate-named-sections from the driver (PR #91567)

2024-05-09 Thread Peter Smith via cfe-commits 

https://github.com/smithp35 commented:

Code change LGTM.

Although currently trivial, would it be worth adding a Driver test for it. 
Something like 
https://github.com/llvm/llvm-project/blob/main/clang/test/Driver/funique-internal-linkage-names.c
  

https://github.com/llvm/llvm-project/pull/91567
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Pass -fseparate-named-sections from the driver (PR #91567)

2024-05-09 Thread via cfe-commits 

llvmbot wrote:




@llvm/pr-subscribers-clang-driver

Author: Petr Hosek (petrhosek)


Changes

This is a follow up to #91028.

---
Full diff: https://github.com/llvm/llvm-project/pull/91567.diff


1 Files Affected:

- (modified) clang/lib/Driver/ToolChains/Clang.cpp (+2) 


``diff
diff --git a/clang/lib/Driver/ToolChains/Clang.cpp 
b/clang/lib/Driver/ToolChains/Clang.cpp
index 0a2ea96de7382..ceb5eb835ddce 100644
--- a/clang/lib/Driver/ToolChains/Clang.cpp
+++ b/clang/lib/Driver/ToolChains/Clang.cpp
@@ -6116,6 +6116,8 @@ void Clang::ConstructJob(Compilation &C, const JobAction 
&JA,
 
   Args.addOptOutFlag(CmdArgs, options::OPT_funique_section_names,
  options::OPT_fno_unique_section_names);
+  Args.addOptInFlag(CmdArgs, options::OPT_fseparate_named_sections,
+options::OPT_fno_separate_named_sections);
   Args.addOptInFlag(CmdArgs, options::OPT_funique_internal_linkage_names,
 options::OPT_fno_unique_internal_linkage_names);
   Args.addOptInFlag(CmdArgs, options::OPT_funique_basic_block_section_names,

``




https://github.com/llvm/llvm-project/pull/91567
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Pass -fseparate-named-sections from the driver (PR #91567)

2024-05-09 Thread Petr Hosek via cfe-commits 

https://github.com/petrhosek created 
https://github.com/llvm/llvm-project/pull/91567

This is a follow up to #91028.

>From ca2b9d52d31866a657e2eb19585cdcd11bcad7d3 Mon Sep 17 00:00:00 2001
From: Petr Hosek 
Date: Thu, 9 May 2024 00:28:33 -0700
Subject: [PATCH] [Clang] Pass -fseparate-named-sections from the driver

This is a follow up to #91028.
---
 clang/lib/Driver/ToolChains/Clang.cpp | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/clang/lib/Driver/ToolChains/Clang.cpp 
b/clang/lib/Driver/ToolChains/Clang.cpp
index 0a2ea96de7382..ceb5eb835ddce 100644
--- a/clang/lib/Driver/ToolChains/Clang.cpp
+++ b/clang/lib/Driver/ToolChains/Clang.cpp
@@ -6116,6 +6116,8 @@ void Clang::ConstructJob(Compilation &C, const JobAction 
&JA,
 
   Args.addOptOutFlag(CmdArgs, options::OPT_funique_section_names,
  options::OPT_fno_unique_section_names);
+  Args.addOptInFlag(CmdArgs, options::OPT_fseparate_named_sections,
+options::OPT_fno_separate_named_sections);
   Args.addOptInFlag(CmdArgs, options::OPT_funique_internal_linkage_names,
 options::OPT_fno_unique_internal_linkage_names);
   Args.addOptInFlag(CmdArgs, options::OPT_funique_basic_block_section_names,

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits