[clang] [Clang] Remove NetBSD/i386 workaround for FP eval method with older versions (PR #74025)

[Brad Smith via cfe-commits]

https://github.com/brad0 closed https://github.com/llvm/llvm-project/pull/74025
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Remove NetBSD/i386 workaround for FP eval method with older versions (PR #74025)

[Brad Smith via cfe-commits]

https://github.com/brad0 updated https://github.com/llvm/llvm-project/pull/74025

>From efc4bab5c06cb9655912da9ca7e25e5fd73e2318 Mon Sep 17 00:00:00 2001
From: Brad Smith 
Date: Thu, 30 Nov 2023 20:50:01 -0500
Subject: [PATCH] [Clang] Remove NetBSD/i386 workaround for FP eval method with
 older versions

NetBSD 6.x is long EoL. Make 7.x the minimum and even that is EoL.
---
 clang/docs/ReleaseNotes.rst   | 5 +
 clang/lib/Basic/Targets/X86.h | 9 -
 2 files changed, 5 insertions(+), 9 deletions(-)

diff --git a/clang/docs/ReleaseNotes.rst b/clang/docs/ReleaseNotes.rst
index 4ab6bd9de8ea9..bc40f0719d4a5 100644
--- a/clang/docs/ReleaseNotes.rst
+++ b/clang/docs/ReleaseNotes.rst
@@ -1239,6 +1239,11 @@ AIX Support
   This access sequence is not used for TLS variables larger than 32KB, and is
   currently only supported on 64-bit mode.
 
+NetBSD Support
+^^
+
+- Removed support for building NetBSD/i386 6.x or older binaries.
+
 WebAssembly Support
 ^^^
 
diff --git a/clang/lib/Basic/Targets/X86.h b/clang/lib/Basic/Targets/X86.h
index cdec41afd1a4b..ba34ab2c7f336 100644
--- a/clang/lib/Basic/Targets/X86.h
+++ b/clang/lib/Basic/Targets/X86.h
@@ -513,15 +513,6 @@ class LLVM_LIBRARY_VISIBILITY NetBSDI386TargetInfo
 public:
   NetBSDI386TargetInfo(const llvm::Triple &Triple, const TargetOptions &Opts)
   : NetBSDTargetInfo(Triple, Opts) {}
-
-  LangOptions::FPEvalMethodKind getFPEvalMethod() const override {
-VersionTuple OsVersion = getTriple().getOSVersion();
-// New NetBSD uses the default rounding mode.
-if (OsVersion >= VersionTuple(6, 99, 26) || OsVersion.getMajor() == 0)
-  return X86_32TargetInfo::getFPEvalMethod();
-// NetBSD before 6.99.26 defaults to "double" rounding.
-return LangOptions::FPEvalMethodKind::FEM_Double;
-  }
 };
 
 class LLVM_LIBRARY_VISIBILITY OpenBSDI386TargetInfo

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Remove NetBSD/i386 workaround for FP eval method with older versions (PR #74025)

[Brad Smith via cfe-commits]

https://github.com/brad0 updated https://github.com/llvm/llvm-project/pull/74025

>From bfee80b825aeb5c99f23149a2c4317eda10c1cd4 Mon Sep 17 00:00:00 2001
From: Brad Smith 
Date: Thu, 30 Nov 2023 20:50:01 -0500
Subject: [PATCH] [Clang] Remove NetBSD/i386 workaround for FP eval method with
 older versions

NetBSD 6.x is long EoL. Make 7.x the minimum and even that is EoL.
---
 clang/docs/ReleaseNotes.rst   | 5 +
 clang/lib/Basic/Targets/X86.h | 9 -
 2 files changed, 5 insertions(+), 9 deletions(-)

diff --git a/clang/docs/ReleaseNotes.rst b/clang/docs/ReleaseNotes.rst
index 4ab6bd9de8ea9..54699453dcbc8 100644
--- a/clang/docs/ReleaseNotes.rst
+++ b/clang/docs/ReleaseNotes.rst
@@ -1239,6 +1239,11 @@ AIX Support
   This access sequence is not used for TLS variables larger than 32KB, and is
   currently only supported on 64-bit mode.
 
+NetBSD Support
+^^
+
+- Removed support for building binaries for NetBSD 6.x or older.
+
 WebAssembly Support
 ^^^
 
diff --git a/clang/lib/Basic/Targets/X86.h b/clang/lib/Basic/Targets/X86.h
index cdec41afd1a4b..ba34ab2c7f336 100644
--- a/clang/lib/Basic/Targets/X86.h
+++ b/clang/lib/Basic/Targets/X86.h
@@ -513,15 +513,6 @@ class LLVM_LIBRARY_VISIBILITY NetBSDI386TargetInfo
 public:
   NetBSDI386TargetInfo(const llvm::Triple &Triple, const TargetOptions &Opts)
   : NetBSDTargetInfo(Triple, Opts) {}
-
-  LangOptions::FPEvalMethodKind getFPEvalMethod() const override {
-VersionTuple OsVersion = getTriple().getOSVersion();
-// New NetBSD uses the default rounding mode.
-if (OsVersion >= VersionTuple(6, 99, 26) || OsVersion.getMajor() == 0)
-  return X86_32TargetInfo::getFPEvalMethod();
-// NetBSD before 6.99.26 defaults to "double" rounding.
-return LangOptions::FPEvalMethodKind::FEM_Double;
-  }
 };
 
 class LLVM_LIBRARY_VISIBILITY OpenBSDI386TargetInfo

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Remove NetBSD/i386 workaround for FP eval method with older versions (PR #74025)

[Michał Górny via cfe-commits]

https://github.com/mgorny approved this pull request.

Code LGTM but please add a note to the release notes, as was requested.

https://github.com/llvm/llvm-project/pull/74025
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Remove NetBSD/i386 workaround for FP eval method with older versions (PR #74025)

[Brad Smith via cfe-commits]

https://github.com/brad0 edited https://github.com/llvm/llvm-project/pull/74025
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Remove NetBSD/i386 workaround for FP eval method with older versions (PR #74025)

[Brad Smith via cfe-commits]

https://github.com/brad0 updated https://github.com/llvm/llvm-project/pull/74025

>From 68942fe871a37e59c686c177aa43e63f08d730aa Mon Sep 17 00:00:00 2001
From: Brad Smith 
Date: Thu, 30 Nov 2023 20:50:01 -0500
Subject: [PATCH] [Clang] Remove NetBSD/i386 workaround for FP eval method with
 older versions

NetBSD 7.x is long EoL. Make 8.x the minimum.
---
 clang/lib/Basic/Targets/X86.h | 9 -
 1 file changed, 9 deletions(-)

diff --git a/clang/lib/Basic/Targets/X86.h b/clang/lib/Basic/Targets/X86.h
index 99a64501d263ce4..f03edccf7a13c57 100644
--- a/clang/lib/Basic/Targets/X86.h
+++ b/clang/lib/Basic/Targets/X86.h
@@ -507,15 +507,6 @@ class LLVM_LIBRARY_VISIBILITY NetBSDI386TargetInfo
 public:
   NetBSDI386TargetInfo(const llvm::Triple &Triple, const TargetOptions &Opts)
   : NetBSDTargetInfo(Triple, Opts) {}
-
-  LangOptions::FPEvalMethodKind getFPEvalMethod() const override {
-VersionTuple OsVersion = getTriple().getOSVersion();
-// New NetBSD uses the default rounding mode.
-if (OsVersion >= VersionTuple(6, 99, 26) || OsVersion.getMajor() == 0)
-  return X86_32TargetInfo::getFPEvalMethod();
-// NetBSD before 6.99.26 defaults to "double" rounding.
-return LangOptions::FPEvalMethodKind::FEM_Double;
-  }
 };
 
 class LLVM_LIBRARY_VISIBILITY OpenBSDI386TargetInfo

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Remove NetBSD/i386 workaround for FP eval method with older versions (PR #74025)

[Simon Pilgrim via cfe-commits]

RKSimon wrote:

This should be documented in the release notes in case somebody was still 
building for such an old netbsd. Should we emit any compile warnings/errors 
when building for this triple?

https://github.com/llvm/llvm-project/pull/74025
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Remove NetBSD/i386 workaround for FP eval method with older versions (PR #74025)

[Brad Smith via cfe-commits]

https://github.com/brad0 edited https://github.com/llvm/llvm-project/pull/74025
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits