[clang] [clang] Use SmallString::str (NFC) (PR #92717)

2024-05-20 Thread Kazu Hirata via cfe-commits 

https://github.com/kazutakahirata closed 
https://github.com/llvm/llvm-project/pull/92717
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Use SmallString::str (NFC) (PR #92717)

2024-05-20 Thread Fangrui Song via cfe-commits 

https://github.com/MaskRay approved this pull request.


https://github.com/llvm/llvm-project/pull/92717
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Use SmallString::str (NFC) (PR #92717)

2024-05-20 Thread via cfe-commits 

llvmbot wrote:




@llvm/pr-subscribers-clang

Author: Kazu Hirata (kazutakahirata)


Changes



---
Full diff: https://github.com/llvm/llvm-project/pull/92717.diff


3 Files Affected:

- (modified) clang/lib/ARCMigrate/ARCMT.cpp (+1-2) 
- (modified) clang/lib/ARCMigrate/ObjCMT.cpp (+1-2) 
- (modified) clang/lib/Sema/SemaExpr.cpp (+1-3) 


``diff
diff --git a/clang/lib/ARCMigrate/ARCMT.cpp b/clang/lib/ARCMigrate/ARCMT.cpp
index b410d5f3b42a7..5835559bff6b7 100644
--- a/clang/lib/ARCMigrate/ARCMT.cpp
+++ b/clang/lib/ARCMigrate/ARCMT.cpp
@@ -606,8 +606,7 @@ bool MigrationProcess::applyTransform(TransformFn trans,
 llvm::raw_svector_ostream vecOS(newText);
 buf.write(vecOS);
 std::unique_ptr memBuf(
-llvm::MemoryBuffer::getMemBufferCopy(
-StringRef(newText.data(), newText.size()), newFname));
+llvm::MemoryBuffer::getMemBufferCopy(newText.str(), newFname));
 SmallString<64> filePath(file->getName());
 Unit->getFileManager().FixupRelativePath(filePath);
 Remapper.remap(filePath.str(), std::move(memBuf));
diff --git a/clang/lib/ARCMigrate/ObjCMT.cpp b/clang/lib/ARCMigrate/ObjCMT.cpp
index aaf41dc4039cd..4357c8e3f09a5 100644
--- a/clang/lib/ARCMigrate/ObjCMT.cpp
+++ b/clang/lib/ARCMigrate/ObjCMT.cpp
@@ -1963,8 +1963,7 @@ void 
ObjCMigrateASTConsumer::HandleTranslationUnit(ASTContext ) {
 llvm::raw_svector_ostream vecOS(newText);
 buf.write(vecOS);
 std::unique_ptr memBuf(
-llvm::MemoryBuffer::getMemBufferCopy(
-StringRef(newText.data(), newText.size()), file->getName()));
+llvm::MemoryBuffer::getMemBufferCopy(newText.str(), file->getName()));
 SmallString<64> filePath(file->getName());
 FileMgr.FixupRelativePath(filePath);
 Remapper.remap(filePath.str(), std::move(memBuf));
diff --git a/clang/lib/Sema/SemaExpr.cpp b/clang/lib/Sema/SemaExpr.cpp
index 5ecfdee21f09d..f2d0a93d9a1e7 100644
--- a/clang/lib/Sema/SemaExpr.cpp
+++ b/clang/lib/Sema/SemaExpr.cpp
@@ -3718,9 +3718,7 @@ static Expr *BuildFloatingLiteral(Sema , 
NumericLiteralParser ,
   APFloat::getSmallest(Format).toString(buffer);
 }
 
-S.Diag(Loc, diagnostic)
-  << Ty
-  << StringRef(buffer.data(), buffer.size());
+S.Diag(Loc, diagnostic) << Ty << buffer.str();
   }
 
   bool isExact = (result == APFloat::opOK);

``




https://github.com/llvm/llvm-project/pull/92717
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Use SmallString::str (NFC) (PR #92717)

2024-05-20 Thread Kazu Hirata via cfe-commits 

https://github.com/kazutakahirata created 
https://github.com/llvm/llvm-project/pull/92717

None

>From 46dc6749639faa9734028a61376d05bb38ebebad Mon Sep 17 00:00:00 2001
From: Kazu Hirata 
Date: Sun, 19 May 2024 22:50:49 -0700
Subject: [PATCH] [clang] Use SmallString::str (NFC)

---
 clang/lib/ARCMigrate/ARCMT.cpp  | 3 +--
 clang/lib/ARCMigrate/ObjCMT.cpp | 3 +--
 clang/lib/Sema/SemaExpr.cpp | 4 +---
 3 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/clang/lib/ARCMigrate/ARCMT.cpp b/clang/lib/ARCMigrate/ARCMT.cpp
index b410d5f3b42a7..5835559bff6b7 100644
--- a/clang/lib/ARCMigrate/ARCMT.cpp
+++ b/clang/lib/ARCMigrate/ARCMT.cpp
@@ -606,8 +606,7 @@ bool MigrationProcess::applyTransform(TransformFn trans,
 llvm::raw_svector_ostream vecOS(newText);
 buf.write(vecOS);
 std::unique_ptr memBuf(
-llvm::MemoryBuffer::getMemBufferCopy(
-StringRef(newText.data(), newText.size()), newFname));
+llvm::MemoryBuffer::getMemBufferCopy(newText.str(), newFname));
 SmallString<64> filePath(file->getName());
 Unit->getFileManager().FixupRelativePath(filePath);
 Remapper.remap(filePath.str(), std::move(memBuf));
diff --git a/clang/lib/ARCMigrate/ObjCMT.cpp b/clang/lib/ARCMigrate/ObjCMT.cpp
index aaf41dc4039cd..4357c8e3f09a5 100644
--- a/clang/lib/ARCMigrate/ObjCMT.cpp
+++ b/clang/lib/ARCMigrate/ObjCMT.cpp
@@ -1963,8 +1963,7 @@ void 
ObjCMigrateASTConsumer::HandleTranslationUnit(ASTContext ) {
 llvm::raw_svector_ostream vecOS(newText);
 buf.write(vecOS);
 std::unique_ptr memBuf(
-llvm::MemoryBuffer::getMemBufferCopy(
-StringRef(newText.data(), newText.size()), file->getName()));
+llvm::MemoryBuffer::getMemBufferCopy(newText.str(), file->getName()));
 SmallString<64> filePath(file->getName());
 FileMgr.FixupRelativePath(filePath);
 Remapper.remap(filePath.str(), std::move(memBuf));
diff --git a/clang/lib/Sema/SemaExpr.cpp b/clang/lib/Sema/SemaExpr.cpp
index 5ecfdee21f09d..f2d0a93d9a1e7 100644
--- a/clang/lib/Sema/SemaExpr.cpp
+++ b/clang/lib/Sema/SemaExpr.cpp
@@ -3718,9 +3718,7 @@ static Expr *BuildFloatingLiteral(Sema , 
NumericLiteralParser ,
   APFloat::getSmallest(Format).toString(buffer);
 }
 
-S.Diag(Loc, diagnostic)
-  << Ty
-  << StringRef(buffer.data(), buffer.size());
+S.Diag(Loc, diagnostic) << Ty << buffer.str();
   }
 
   bool isExact = (result == APFloat::opOK);

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits