[clang] [clang-format] Don't allow comma in front of structural enum (PR #91056)

[Emilia Kond via cfe-commits]

https://github.com/rymiel closed https://github.com/llvm/llvm-project/pull/91056
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Don't allow comma in front of structural enum (PR #91056)

[via cfe-commits]

https://github.com/mydeveloperday approved this pull request.


https://github.com/llvm/llvm-project/pull/91056
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Don't allow comma in front of structural enum (PR #91056)

[Owen Pan via cfe-commits]

https://github.com/owenca approved this pull request.


https://github.com/llvm/llvm-project/pull/91056
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Don't allow comma in front of structural enum (PR #91056)

[via cfe-commits]

llvmbot wrote:




@llvm/pr-subscribers-clang-format

Author: Emilia Kond (rymiel)


Changes

Assume that a comma in front of `enum` means it is actually a part of an 
elaborated type in a template parameter list.

Fixes https://github.com/llvm/llvm-project/issues/47782

---
Full diff: https://github.com/llvm/llvm-project/pull/91056.diff


2 Files Affected:

- (modified) clang/lib/Format/UnwrappedLineParser.cpp (+3-2) 
- (modified) clang/unittests/Format/TokenAnnotatorTest.cpp (+4) 


``diff
diff --git a/clang/lib/Format/UnwrappedLineParser.cpp 
b/clang/lib/Format/UnwrappedLineParser.cpp
index e8a8dd58d07eea..b5415fa9ecab55 100644
--- a/clang/lib/Format/UnwrappedLineParser.cpp
+++ b/clang/lib/Format/UnwrappedLineParser.cpp
@@ -1763,8 +1763,9 @@ void UnwrappedLineParser::parseStructuralElement(
   break;
 }
 case tok::kw_enum:
-  // Ignore if this is part of "template  enum".
-  if (Previous && Previous->isOneOf(tok::less, tok::arrow)) {
+  // Ignore if this is part of "template  enum" or
+  // "template <..., enum ...>".
+  if (Previous && Previous->isOneOf(tok::less, tok::arrow, tok::comma)) {
 nextToken();
 break;
   }
diff --git a/clang/unittests/Format/TokenAnnotatorTest.cpp 
b/clang/unittests/Format/TokenAnnotatorTest.cpp
index 01daf8dee505bc..b424424b85777b 100644
--- a/clang/unittests/Format/TokenAnnotatorTest.cpp
+++ b/clang/unittests/Format/TokenAnnotatorTest.cpp
@@ -489,6 +489,10 @@ TEST_F(TokenAnnotatorTest, UnderstandsStructs) {
   EXPECT_TOKEN(Tokens[24], tok::amp, TT_UnaryOperator);
   EXPECT_TOKEN(Tokens[27], tok::l_square, TT_ArraySubscriptLSquare);
   EXPECT_TOKEN(Tokens[32], tok::r_brace, TT_StructRBrace);
+
+  Tokens = annotate("template  struct S {};");
+  ASSERT_EQ(Tokens.size(), 15u) << Tokens;
+  EXPECT_TOKEN(Tokens[11], tok::l_brace, TT_StructLBrace);
 }
 
 TEST_F(TokenAnnotatorTest, UnderstandsUnions) {

``




https://github.com/llvm/llvm-project/pull/91056
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Don't allow comma in front of structural enum (PR #91056)

[Emilia Kond via cfe-commits]

https://github.com/rymiel created 
https://github.com/llvm/llvm-project/pull/91056

Assume that a comma in front of `enum` means it is actually a part of an 
elaborated type in a template parameter list.

Fixes https://github.com/llvm/llvm-project/issues/47782

>From f625311fe7259a07607cc2bb8c13e05715775c68 Mon Sep 17 00:00:00 2001
From: Emilia Kond 
Date: Sat, 4 May 2024 12:57:49 +0300
Subject: [PATCH] [clang-format] Don't allow comma in front of structural enum

Assume that a comma in front of `enum` means it is actually a part of
an elaborated type in a template parameter list.

Fixes https://github.com/llvm/llvm-project/issues/47782
---
 clang/lib/Format/UnwrappedLineParser.cpp  | 5 +++--
 clang/unittests/Format/TokenAnnotatorTest.cpp | 4 
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/clang/lib/Format/UnwrappedLineParser.cpp 
b/clang/lib/Format/UnwrappedLineParser.cpp
index e8a8dd58d07eea..b5415fa9ecab55 100644
--- a/clang/lib/Format/UnwrappedLineParser.cpp
+++ b/clang/lib/Format/UnwrappedLineParser.cpp
@@ -1763,8 +1763,9 @@ void UnwrappedLineParser::parseStructuralElement(
   break;
 }
 case tok::kw_enum:
-  // Ignore if this is part of "template  enum".
-  if (Previous && Previous->isOneOf(tok::less, tok::arrow)) {
+  // Ignore if this is part of "template  enum" or
+  // "template <..., enum ...>".
+  if (Previous && Previous->isOneOf(tok::less, tok::arrow, tok::comma)) {
 nextToken();
 break;
   }
diff --git a/clang/unittests/Format/TokenAnnotatorTest.cpp 
b/clang/unittests/Format/TokenAnnotatorTest.cpp
index 01daf8dee505bc..b424424b85777b 100644
--- a/clang/unittests/Format/TokenAnnotatorTest.cpp
+++ b/clang/unittests/Format/TokenAnnotatorTest.cpp
@@ -489,6 +489,10 @@ TEST_F(TokenAnnotatorTest, UnderstandsStructs) {
   EXPECT_TOKEN(Tokens[24], tok::amp, TT_UnaryOperator);
   EXPECT_TOKEN(Tokens[27], tok::l_square, TT_ArraySubscriptLSquare);
   EXPECT_TOKEN(Tokens[32], tok::r_brace, TT_StructRBrace);
+
+  Tokens = annotate("template  struct S {};");
+  ASSERT_EQ(Tokens.size(), 15u) << Tokens;
+  EXPECT_TOKEN(Tokens[11], tok::l_brace, TT_StructLBrace);
 }
 
 TEST_F(TokenAnnotatorTest, UnderstandsUnions) {

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits