Re: [clang] 12038be - [Concepts] Fix crash in D41910

2019-12-18 Thread Vedant Kumar via cfe-commits 
I've temporarily reverted the D41910 patchset in order to get the lldb bot 
unstuck (5094e6dad64).

vedant

> On Dec 18, 2019, at 1:34 PM, Vedant Kumar  wrote:
> 
> Hey Saar,
> Do you expect this to address this crash seen on the lldb bot after D41910 
> landed?
> 
> Assertion failed: (Idx < size() && "Out-of-bounds Bit access."), function 
> operator[], file 
> /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/include/llvm/ADT/SmallBitVector.h,
>  line 452.
> 
> Stack dump:
> 0.Program arguments: 
> /Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/bin/clang-10 -cc1 
> -triple x86_64-apple-macosx10.14.0 -Wdeprecated-objc-isa-usage 
> -Werror=deprecated-objc-isa-usage -emit-obj -mrelax-all -disable-free 
> -main-file-name main.cpp -mrelocation-model pic -pic-level 2 -mthread-model 
> posix -mframe-pointer=all -fno-rounding-math -masm-verbose -munwind-tables 
> -target-sdk-version=10.14 -target-cpu penryn -dwarf-column-info 
> -debug-info-kind=standalone -dwarf-version=4 -debugger-tuning=lldb 
> -target-linker-version 409.12 -resource-dir 
> /Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/lib/clang/10.0.99 
> -isysroot 
> /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk
>  -include 
> /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/lldb/packages/Python/lldbsuite/test/make/test_common.h
>  -I 
> /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/lldb/packages/Python/lldbsuite/test/make/../../../../../include
>  -I 
> /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/variant
>  -I 
> /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/lldb/packages/Python/lldbsuite/test/make
>  -D LLDB_USING_LIBCPP -stdlib=libc++ -internal-isystem 
> /Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/bin/../include/c++/v1
>  -internal-isystem 
> /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/usr/include/c++/v1
>  -internal-isystem 
> /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/usr/local/include
>  -internal-isystem 
> /Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/lib/clang/10.0.99/include
>  -internal-externc-isystem 
> /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/usr/include
>  -O0 -std=c++17 -fdeprecated-macro -fdebug-compilation-dir 
> /Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/lldb-test-build.noindex/functionalities/data-formatter/data-formatter-stl/libcxx/variant/TestDataFormatterLibcxxVariant.test_with_run_command_dsym
>  -ferror-limit 19 -fmessage-length 0 -stack-protector 1 -fno-builtin -fblocks 
> -fencode-extended-block-signature -fregister-global-dtors-with-atexit 
> -fgnuc-version=4.2.1 -fobjc-runtime=macosx-10.14.0 -fcxx-exceptions 
> -fexceptions -fmax-type-align=16 -fdiagnostics-show-option -o main.o -x c++ 
> /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/variant/main.cpp
>  
> 1.
> /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/variant/main.cpp:26:39:
>  current parser token ';'
> 2.
> /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/variant/main.cpp:20:1:
>  parsing function body 'main'
> 3.
> /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/variant/main.cpp:20:1:
>  in compound statement ('{}')
> 4.
> /Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/bin/../include/c++/v1/variant:1192:13:
>  instantiating function definition 'std::__1::variant char>::variant'
> 5.
> /Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/bin/../include/c++/v1/variant:684:22:
>  instantiating function definition 
> 'std::__1::__variant_detail::__base  int, double, char>::__base<0>'
> 0  clang-10 0x0001077ed1a5 
> llvm::sys::PrintStackTrace(llvm::raw_ostream&) + 37
> 1  clang-10 0x0001077ec0a8 llvm::sys::RunSignalHandlers() 
> + 248
> 2  clang-10 0x0001077ed796 SignalHandler(int) + 262
> 3  libsystem_platform.dylib 0x7fff66bc3b3d _sigtramp + 29
> 4  libsystem_platform.dylib 0x7ffeea2a2150 _sigtramp + 
> 18446744071619601968
> 5  libsystem_c.dylib0x7fff66a821c9 abort + 127
> 6  libsystem_c.dylib0x7fff66a4a868 basename_r + 0
> 7  clang-10 0x0001094b79d9 
> isAtLeastAsSpecializedAs(clang::Sema&, clang::SourceLocation, 
> clang::FunctionTemplateDecl*,

Re: [clang] 12038be - [Concepts] Fix crash in D41910

2019-12-18 Thread Vedant Kumar via cfe-commits 
Hey Saar,
Do you expect this to address this crash seen on the lldb bot after D41910 
landed?

Assertion failed: (Idx < size() && "Out-of-bounds Bit access."), function 
operator[], file 
/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/include/llvm/ADT/SmallBitVector.h,
 line 452.

Stack dump:
0.  Program arguments: 
/Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/bin/clang-10 -cc1 
-triple x86_64-apple-macosx10.14.0 -Wdeprecated-objc-isa-usage 
-Werror=deprecated-objc-isa-usage -emit-obj -mrelax-all -disable-free 
-main-file-name main.cpp -mrelocation-model pic -pic-level 2 -mthread-model 
posix -mframe-pointer=all -fno-rounding-math -masm-verbose -munwind-tables 
-target-sdk-version=10.14 -target-cpu penryn -dwarf-column-info 
-debug-info-kind=standalone -dwarf-version=4 -debugger-tuning=lldb 
-target-linker-version 409.12 -resource-dir 
/Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/lib/clang/10.0.99 
-isysroot 
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk
 -include 
/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/lldb/packages/Python/lldbsuite/test/make/test_common.h
 -I 
/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/lldb/packages/Python/lldbsuite/test/make/../../../../../include
 -I 
/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/variant
 -I 
/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/lldb/packages/Python/lldbsuite/test/make
 -D LLDB_USING_LIBCPP -stdlib=libc++ -internal-isystem 
/Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/bin/../include/c++/v1 
-internal-isystem 
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/usr/include/c++/v1
 -internal-isystem 
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/usr/local/include
 -internal-isystem 
/Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/lib/clang/10.0.99/include
 -internal-externc-isystem 
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/usr/include
 -O0 -std=c++17 -fdeprecated-macro -fdebug-compilation-dir 
/Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/lldb-test-build.noindex/functionalities/data-formatter/data-formatter-stl/libcxx/variant/TestDataFormatterLibcxxVariant.test_with_run_command_dsym
 -ferror-limit 19 -fmessage-length 0 -stack-protector 1 -fno-builtin -fblocks 
-fencode-extended-block-signature -fregister-global-dtors-with-atexit 
-fgnuc-version=4.2.1 -fobjc-runtime=macosx-10.14.0 -fcxx-exceptions 
-fexceptions -fmax-type-align=16 -fdiagnostics-show-option -o main.o -x c++ 
/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/variant/main.cpp
 
1.  
/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/variant/main.cpp:26:39:
 current parser token ';'
2.  
/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/variant/main.cpp:20:1:
 parsing function body 'main'
3.  
/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/variant/main.cpp:20:1:
 in compound statement ('{}')
4.  
/Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/bin/../include/c++/v1/variant:1192:13:
 instantiating function definition 'std::__1::variant::variant'
5.  
/Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/bin/../include/c++/v1/variant:684:22:
 instantiating function definition 
'std::__1::__variant_detail::__base::__base<0>'
0  clang-10 0x0001077ed1a5 
llvm::sys::PrintStackTrace(llvm::raw_ostream&) + 37
1  clang-10 0x0001077ec0a8 llvm::sys::RunSignalHandlers() + 
248
2  clang-10 0x0001077ed796 SignalHandler(int) + 262
3  libsystem_platform.dylib 0x7fff66bc3b3d _sigtramp + 29
4  libsystem_platform.dylib 0x7ffeea2a2150 _sigtramp + 18446744071619601968
5  libsystem_c.dylib0x7fff66a821c9 abort + 127
6  libsystem_c.dylib0x7fff66a4a868 basename_r + 0
7  clang-10 0x0001094b79d9 
isAtLeastAsSpecializedAs(clang::Sema&, clang::SourceLocation, 
clang::FunctionTemplateDecl*, clang::FunctionTemplateDecl*, 
clang::TemplatePartialOrderingContext, unsigned int) + 1865
8  clang-10 0x0001094b7111 
clang::Sema::getMoreSpecializedTemplate(clang::FunctionTemplateDecl*, 
clang::FunctionTemplateDecl*, clang::SourceLocation, 
clang::TemplatePartialOrderingContext, unsigned int, unsigned int) + 97
9  clang-10

[clang] 12038be - [Concepts] Fix crash in D41910

2019-12-18 Thread Saar Raz via cfe-commits 

Author: Saar Raz
Date: 2019-12-18T21:31:33+02:00
New Revision: 12038be20ee6a903cdbd3fddce65535ef683e31d

URL: 
https://github.com/llvm/llvm-project/commit/12038be20ee6a903cdbd3fddce65535ef683e31d
DIFF: 
https://github.com/llvm/llvm-project/commit/12038be20ee6a903cdbd3fddce65535ef683e31d.diff

LOG: [Concepts] Fix crash in D41910

Differential Revision: https://reviews.llvm.org/D41910

Added: 


Modified: 
clang/lib/Sema/SemaConcept.cpp

Removed: 




diff  --git a/clang/lib/Sema/SemaConcept.cpp b/clang/lib/Sema/SemaConcept.cpp
index cd41000fa023..f9d54a811469 100755
--- a/clang/lib/Sema/SemaConcept.cpp
+++ b/clang/lib/Sema/SemaConcept.cpp
@@ -558,7 +558,7 @@ static bool substituteParameterMappings(Sema , 
NormalizedConstraint ,
 Atomic.ParameterMapping.emplace();
 Atomic.ParameterMapping->reserve(OccurringIndices.size());
 for (unsigned I = 0, C = TemplateParams->size(); I != C; ++I)
-  if (OccurringIndices[I])
+  if (I < OccurringIndices.size() && OccurringIndices[I])
 Atomic.ParameterMapping->push_back(
 S.getIdentityTemplateArgumentLoc(TemplateParams->begin()[I],
 // Here we assume we do not support things like



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits