Author: Vitaly Buka Date: 2020-05-28T13:32:57-07:00 New Revision: 2f430f7a51693c9d5c648179f2341b541be44000
URL: https://github.com/llvm/llvm-project/commit/2f430f7a51693c9d5c648179f2341b541be44000 DIFF: https://github.com/llvm/llvm-project/commit/2f430f7a51693c9d5c648179f2341b541be44000.diff LOG: [StackSafety] Remove SetMetadata parameter Added: Modified: clang/lib/CodeGen/BackendUtil.cpp llvm/include/llvm/Analysis/StackSafetyAnalysis.h llvm/lib/Analysis/StackSafetyAnalysis.cpp Removed: ################################################################################ diff --git a/clang/lib/CodeGen/BackendUtil.cpp b/clang/lib/CodeGen/BackendUtil.cpp index 33627f3a6733..e746aef1a62f 100644 --- a/clang/lib/CodeGen/BackendUtil.cpp +++ b/clang/lib/CodeGen/BackendUtil.cpp @@ -353,7 +353,7 @@ static void addDataFlowSanitizerPass(const PassManagerBuilder &Builder, static void addMemTagOptimizationPasses(const PassManagerBuilder &Builder, legacy::PassManagerBase &PM) { - PM.add(createStackSafetyGlobalInfoWrapperPass(/*SetMetadata=*/true)); + PM.add(createStackSafetyGlobalInfoWrapperPass()); } static TargetLibraryInfoImpl *createTLII(llvm::Triple &TargetTriple, diff --git a/llvm/include/llvm/Analysis/StackSafetyAnalysis.h b/llvm/include/llvm/Analysis/StackSafetyAnalysis.h index df7ccac5b4b9..b5589611c8e2 100644 --- a/llvm/include/llvm/Analysis/StackSafetyAnalysis.h +++ b/llvm/include/llvm/Analysis/StackSafetyAnalysis.h @@ -126,12 +126,11 @@ class StackSafetyGlobalAnnotatorPass /// (legacy pass manager). class StackSafetyGlobalInfoWrapperPass : public ModulePass { StackSafetyGlobalInfo SSGI; - bool SetMetadata; public: static char ID; - StackSafetyGlobalInfoWrapperPass(bool SetMetadata = false); + StackSafetyGlobalInfoWrapperPass(); const StackSafetyGlobalInfo &getResult() const { return SSGI; } @@ -141,7 +140,7 @@ class StackSafetyGlobalInfoWrapperPass : public ModulePass { bool runOnModule(Module &M) override; }; -ModulePass *createStackSafetyGlobalInfoWrapperPass(bool SetMetadata); +ModulePass *createStackSafetyGlobalInfoWrapperPass(); } // end namespace llvm diff --git a/llvm/lib/Analysis/StackSafetyAnalysis.cpp b/llvm/lib/Analysis/StackSafetyAnalysis.cpp index 6eeffe6066df..e969639973a4 100644 --- a/llvm/lib/Analysis/StackSafetyAnalysis.cpp +++ b/llvm/lib/Analysis/StackSafetyAnalysis.cpp @@ -712,9 +712,8 @@ StackSafetyGlobalAnnotatorPass::run(Module &M, ModuleAnalysisManager &AM) { char StackSafetyGlobalInfoWrapperPass::ID = 0; -StackSafetyGlobalInfoWrapperPass::StackSafetyGlobalInfoWrapperPass( - bool SetMetadata) - : ModulePass(ID), SetMetadata(SetMetadata) { +StackSafetyGlobalInfoWrapperPass::StackSafetyGlobalInfoWrapperPass() + : ModulePass(ID) { initializeStackSafetyGlobalInfoWrapperPassPass( *PassRegistry::getPassRegistry()); } @@ -738,11 +737,11 @@ bool StackSafetyGlobalInfoWrapperPass::runOnModule(Module &M) { .Info; }); SSGI = SSDFA.run(); - return SetMetadata ? SSGI.setMetadata(M) : false; + return SSGI.setMetadata(M); } -ModulePass *llvm::createStackSafetyGlobalInfoWrapperPass(bool SetMetadata) { - return new StackSafetyGlobalInfoWrapperPass(SetMetadata); +ModulePass *llvm::createStackSafetyGlobalInfoWrapperPass() { + return new StackSafetyGlobalInfoWrapperPass(); } static const char LocalPassArg[] = "stack-safety-local"; _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits