[clang-tools-extra] [clang-tidy][NFC] replace comparison of begin and end iterators with range empty (PR #91994)

2024-05-15 Thread Julian Schmidt via cfe-commits 

https://github.com/5chmidti closed 
https://github.com/llvm/llvm-project/pull/91994
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][NFC] replace comparison of begin and end iterators with range empty (PR #91994)

2024-05-13 Thread Piotr Zegar via cfe-commits 

https://github.com/PiotrZSL approved this pull request.

LGTM

https://github.com/llvm/llvm-project/pull/91994
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][NFC] replace comparison of begin and end iterators with range empty (PR #91994)

2024-05-13 Thread Julian Schmidt via cfe-commits 

5chmidti wrote:

(The commit was a bit older, where I still used the private email, fixed by 
recommitting with the public one)

https://github.com/llvm/llvm-project/pull/91994
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][NFC] replace comparison of begin and end iterators with range empty (PR #91994)

2024-05-13 Thread Julian Schmidt via cfe-commits 

https://github.com/5chmidti updated 
https://github.com/llvm/llvm-project/pull/91994

>From a73f5a9cb3127893dd65ba2040634a5f9f6924b0 Mon Sep 17 00:00:00 2001
From: Julian Schmidt 
Date: Mon, 13 May 2024 18:53:25 +0200
Subject: [PATCH] [clang-tidy][NFC] replace comparison of begin and end
 iterators with range empty

Improves readability by changing comparisons of `*_begin` and `*_end`
iterators into `.empty()` on their range.
---
 .../clang-tidy/bugprone/SuspiciousEnumUsageCheck.cpp  | 3 +--
 .../MisleadingCaptureDefaultByValueCheck.cpp  | 3 +--
 clang-tools-extra/clang-tidy/misc/UnusedParametersCheck.cpp   | 4 +---
 .../clang-tidy/modernize/UseConstraintsCheck.cpp  | 2 +-
 4 files changed, 4 insertions(+), 8 deletions(-)

diff --git a/clang-tools-extra/clang-tidy/bugprone/SuspiciousEnumUsageCheck.cpp 
b/clang-tools-extra/clang-tidy/bugprone/SuspiciousEnumUsageCheck.cpp
index ca1ae551cc632..2fca7ae2e7eee 100644
--- a/clang-tools-extra/clang-tidy/bugprone/SuspiciousEnumUsageCheck.cpp
+++ b/clang-tools-extra/clang-tidy/bugprone/SuspiciousEnumUsageCheck.cpp
@@ -171,8 +171,7 @@ void SuspiciousEnumUsageCheck::check(const 
MatchFinder::MatchResult ) {
 // Skip when one of the parameters is an empty enum. The
 // hasDisjointValueRange function could not decide the values properly in
 // case of an empty enum.
-if (EnumDec->enumerator_begin() == EnumDec->enumerator_end() ||
-OtherEnumDec->enumerator_begin() == OtherEnumDec->enumerator_end())
+if (EnumDec->enumerators().empty() || OtherEnumDec->enumerators().empty())
   return;
 
 if (!hasDisjointValueRange(EnumDec, OtherEnumDec))
diff --git 
a/clang-tools-extra/clang-tidy/cppcoreguidelines/MisleadingCaptureDefaultByValueCheck.cpp
 
b/clang-tools-extra/clang-tidy/cppcoreguidelines/MisleadingCaptureDefaultByValueCheck.cpp
index 00dfa17a1ccf6..5dee7f91a9341 100644
--- 
a/clang-tools-extra/clang-tidy/cppcoreguidelines/MisleadingCaptureDefaultByValueCheck.cpp
+++ 
b/clang-tools-extra/clang-tidy/cppcoreguidelines/MisleadingCaptureDefaultByValueCheck.cpp
@@ -67,8 +67,7 @@ static std::string createReplacementText(const LambdaExpr 
*Lambda) {
   AppendName("this");
 }
   }
-  if (!Replacement.empty() &&
-  Lambda->explicit_capture_begin() != Lambda->explicit_capture_end()) {
+  if (!Replacement.empty() && !Lambda->explicit_captures().empty()) {
 // Add back separator if we are adding explicit capture variables.
 Stream << ", ";
   }
diff --git a/clang-tools-extra/clang-tidy/misc/UnusedParametersCheck.cpp 
b/clang-tools-extra/clang-tidy/misc/UnusedParametersCheck.cpp
index 3f1d2f9f58099..c2d9286312dc4 100644
--- a/clang-tools-extra/clang-tidy/misc/UnusedParametersCheck.cpp
+++ b/clang-tools-extra/clang-tidy/misc/UnusedParametersCheck.cpp
@@ -192,9 +192,7 @@ void UnusedParametersCheck::check(const 
MatchFinder::MatchResult ) {
 
 // In non-strict mode ignore function definitions with empty bodies
 // (constructor initializer counts for non-empty body).
-if (StrictMode ||
-(Function->getBody()->child_begin() !=
- Function->getBody()->child_end()) ||
+if (StrictMode || !Function->getBody()->children().empty() ||
 (isa(Function) &&
  cast(Function)->getNumCtorInitializers() > 0))
   warnOnUnusedParameter(Result, Function, I);
diff --git a/clang-tools-extra/clang-tidy/modernize/UseConstraintsCheck.cpp 
b/clang-tools-extra/clang-tidy/modernize/UseConstraintsCheck.cpp
index 6d7d1d6b87c60..1585925ee9967 100644
--- a/clang-tools-extra/clang-tidy/modernize/UseConstraintsCheck.cpp
+++ b/clang-tools-extra/clang-tidy/modernize/UseConstraintsCheck.cpp
@@ -254,7 +254,7 @@ findInsertionForConstraint(const FunctionDecl *Function, 
ASTContext ) {
 return utils::lexer::findPreviousTokenKind(Init->getSourceLocation(),
SM, LangOpts, tok::colon);
 }
-if (Constructor->init_begin() != Constructor->init_end())
+if (!Constructor->inits().empty())
   return std::nullopt;
   }
   if (Function->isDeleted()) {

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][NFC] replace comparison of begin and end iterators with range empty (PR #91994)

2024-05-13 Thread Julian Schmidt via cfe-commits 

https://github.com/5chmidti edited 
https://github.com/llvm/llvm-project/pull/91994
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][NFC] replace comparison of begin and end iterators with range empty (PR #91994)

2024-05-13 Thread via cfe-commits 

github-actions[bot] wrote:

⚠️ We detected that you are using a GitHub private e-mail address to contribute 
to the repo. Please turn off [Keep my email addresses 
private](https://github.com/settings/emails) setting in your account. See 
[LLVM 
Discourse](https://discourse.llvm.org/t/hidden-emails-on-github-should-we-do-something-about-it)
 for more information.

https://github.com/llvm/llvm-project/pull/91994
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][NFC] replace comparison of begin and end iterators with range empty (PR #91994)

2024-05-13 Thread via cfe-commits 

llvmbot wrote:




@llvm/pr-subscribers-clang-tidy

Author: Julian Schmidt (5chmidti)


Changes

Improves readability by changing comparisons of `*begin` and `*end`
iterators into `.empty()` on their range.


---
Full diff: https://github.com/llvm/llvm-project/pull/91994.diff


4 Files Affected:

- (modified) clang-tools-extra/clang-tidy/bugprone/SuspiciousEnumUsageCheck.cpp 
(+1-2) 
- (modified) 
clang-tools-extra/clang-tidy/cppcoreguidelines/MisleadingCaptureDefaultByValueCheck.cpp
 (+1-2) 
- (modified) clang-tools-extra/clang-tidy/misc/UnusedParametersCheck.cpp (+1-3) 
- (modified) clang-tools-extra/clang-tidy/modernize/UseConstraintsCheck.cpp 
(+1-1) 


``diff
diff --git a/clang-tools-extra/clang-tidy/bugprone/SuspiciousEnumUsageCheck.cpp 
b/clang-tools-extra/clang-tidy/bugprone/SuspiciousEnumUsageCheck.cpp
index ca1ae551cc632..2fca7ae2e7eee 100644
--- a/clang-tools-extra/clang-tidy/bugprone/SuspiciousEnumUsageCheck.cpp
+++ b/clang-tools-extra/clang-tidy/bugprone/SuspiciousEnumUsageCheck.cpp
@@ -171,8 +171,7 @@ void SuspiciousEnumUsageCheck::check(const 
MatchFinder::MatchResult ) {
 // Skip when one of the parameters is an empty enum. The
 // hasDisjointValueRange function could not decide the values properly in
 // case of an empty enum.
-if (EnumDec->enumerator_begin() == EnumDec->enumerator_end() ||
-OtherEnumDec->enumerator_begin() == OtherEnumDec->enumerator_end())
+if (EnumDec->enumerators().empty() || OtherEnumDec->enumerators().empty())
   return;
 
 if (!hasDisjointValueRange(EnumDec, OtherEnumDec))
diff --git 
a/clang-tools-extra/clang-tidy/cppcoreguidelines/MisleadingCaptureDefaultByValueCheck.cpp
 
b/clang-tools-extra/clang-tidy/cppcoreguidelines/MisleadingCaptureDefaultByValueCheck.cpp
index 00dfa17a1ccf6..5dee7f91a9341 100644
--- 
a/clang-tools-extra/clang-tidy/cppcoreguidelines/MisleadingCaptureDefaultByValueCheck.cpp
+++ 
b/clang-tools-extra/clang-tidy/cppcoreguidelines/MisleadingCaptureDefaultByValueCheck.cpp
@@ -67,8 +67,7 @@ static std::string createReplacementText(const LambdaExpr 
*Lambda) {
   AppendName("this");
 }
   }
-  if (!Replacement.empty() &&
-  Lambda->explicit_capture_begin() != Lambda->explicit_capture_end()) {
+  if (!Replacement.empty() && !Lambda->explicit_captures().empty()) {
 // Add back separator if we are adding explicit capture variables.
 Stream << ", ";
   }
diff --git a/clang-tools-extra/clang-tidy/misc/UnusedParametersCheck.cpp 
b/clang-tools-extra/clang-tidy/misc/UnusedParametersCheck.cpp
index 3f1d2f9f58099..c2d9286312dc4 100644
--- a/clang-tools-extra/clang-tidy/misc/UnusedParametersCheck.cpp
+++ b/clang-tools-extra/clang-tidy/misc/UnusedParametersCheck.cpp
@@ -192,9 +192,7 @@ void UnusedParametersCheck::check(const 
MatchFinder::MatchResult ) {
 
 // In non-strict mode ignore function definitions with empty bodies
 // (constructor initializer counts for non-empty body).
-if (StrictMode ||
-(Function->getBody()->child_begin() !=
- Function->getBody()->child_end()) ||
+if (StrictMode || !Function->getBody()->children().empty() ||
 (isa(Function) &&
  cast(Function)->getNumCtorInitializers() > 0))
   warnOnUnusedParameter(Result, Function, I);
diff --git a/clang-tools-extra/clang-tidy/modernize/UseConstraintsCheck.cpp 
b/clang-tools-extra/clang-tidy/modernize/UseConstraintsCheck.cpp
index 6d7d1d6b87c60..1585925ee9967 100644
--- a/clang-tools-extra/clang-tidy/modernize/UseConstraintsCheck.cpp
+++ b/clang-tools-extra/clang-tidy/modernize/UseConstraintsCheck.cpp
@@ -254,7 +254,7 @@ findInsertionForConstraint(const FunctionDecl *Function, 
ASTContext ) {
 return utils::lexer::findPreviousTokenKind(Init->getSourceLocation(),
SM, LangOpts, tok::colon);
 }
-if (Constructor->init_begin() != Constructor->init_end())
+if (!Constructor->inits().empty())
   return std::nullopt;
   }
   if (Function->isDeleted()) {

``




https://github.com/llvm/llvm-project/pull/91994
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][NFC] replace comparison of begin and end iterators with range empty (PR #91994)

2024-05-13 Thread Julian Schmidt via cfe-commits 

https://github.com/5chmidti created 
https://github.com/llvm/llvm-project/pull/91994

Improves readability by changing comparisons of `*begin` and `*end`
iterators into `.empty()` on their range.


>From a2cf452b69c9a4ad173db34ed9098a76d65187da Mon Sep 17 00:00:00 2001
From: Julian Schmidt <44101708+5chmi...@users.noreply.github.com>
Date: Tue, 16 Jan 2024 18:18:57 +0100
Subject: [PATCH] [clang-tidy][NFC] replace comparison of begin and end
 iterators with range empty

Improves readability by changing comparisons of `*begin` and `*end`
iterators into `.empty()` on their range.
---
 .../clang-tidy/bugprone/SuspiciousEnumUsageCheck.cpp  | 3 +--
 .../MisleadingCaptureDefaultByValueCheck.cpp  | 3 +--
 clang-tools-extra/clang-tidy/misc/UnusedParametersCheck.cpp   | 4 +---
 .../clang-tidy/modernize/UseConstraintsCheck.cpp  | 2 +-
 4 files changed, 4 insertions(+), 8 deletions(-)

diff --git a/clang-tools-extra/clang-tidy/bugprone/SuspiciousEnumUsageCheck.cpp 
b/clang-tools-extra/clang-tidy/bugprone/SuspiciousEnumUsageCheck.cpp
index ca1ae551cc632..2fca7ae2e7eee 100644
--- a/clang-tools-extra/clang-tidy/bugprone/SuspiciousEnumUsageCheck.cpp
+++ b/clang-tools-extra/clang-tidy/bugprone/SuspiciousEnumUsageCheck.cpp
@@ -171,8 +171,7 @@ void SuspiciousEnumUsageCheck::check(const 
MatchFinder::MatchResult ) {
 // Skip when one of the parameters is an empty enum. The
 // hasDisjointValueRange function could not decide the values properly in
 // case of an empty enum.
-if (EnumDec->enumerator_begin() == EnumDec->enumerator_end() ||
-OtherEnumDec->enumerator_begin() == OtherEnumDec->enumerator_end())
+if (EnumDec->enumerators().empty() || OtherEnumDec->enumerators().empty())
   return;
 
 if (!hasDisjointValueRange(EnumDec, OtherEnumDec))
diff --git 
a/clang-tools-extra/clang-tidy/cppcoreguidelines/MisleadingCaptureDefaultByValueCheck.cpp
 
b/clang-tools-extra/clang-tidy/cppcoreguidelines/MisleadingCaptureDefaultByValueCheck.cpp
index 00dfa17a1ccf6..5dee7f91a9341 100644
--- 
a/clang-tools-extra/clang-tidy/cppcoreguidelines/MisleadingCaptureDefaultByValueCheck.cpp
+++ 
b/clang-tools-extra/clang-tidy/cppcoreguidelines/MisleadingCaptureDefaultByValueCheck.cpp
@@ -67,8 +67,7 @@ static std::string createReplacementText(const LambdaExpr 
*Lambda) {
   AppendName("this");
 }
   }
-  if (!Replacement.empty() &&
-  Lambda->explicit_capture_begin() != Lambda->explicit_capture_end()) {
+  if (!Replacement.empty() && !Lambda->explicit_captures().empty()) {
 // Add back separator if we are adding explicit capture variables.
 Stream << ", ";
   }
diff --git a/clang-tools-extra/clang-tidy/misc/UnusedParametersCheck.cpp 
b/clang-tools-extra/clang-tidy/misc/UnusedParametersCheck.cpp
index 3f1d2f9f58099..c2d9286312dc4 100644
--- a/clang-tools-extra/clang-tidy/misc/UnusedParametersCheck.cpp
+++ b/clang-tools-extra/clang-tidy/misc/UnusedParametersCheck.cpp
@@ -192,9 +192,7 @@ void UnusedParametersCheck::check(const 
MatchFinder::MatchResult ) {
 
 // In non-strict mode ignore function definitions with empty bodies
 // (constructor initializer counts for non-empty body).
-if (StrictMode ||
-(Function->getBody()->child_begin() !=
- Function->getBody()->child_end()) ||
+if (StrictMode || !Function->getBody()->children().empty() ||
 (isa(Function) &&
  cast(Function)->getNumCtorInitializers() > 0))
   warnOnUnusedParameter(Result, Function, I);
diff --git a/clang-tools-extra/clang-tidy/modernize/UseConstraintsCheck.cpp 
b/clang-tools-extra/clang-tidy/modernize/UseConstraintsCheck.cpp
index 6d7d1d6b87c60..1585925ee9967 100644
--- a/clang-tools-extra/clang-tidy/modernize/UseConstraintsCheck.cpp
+++ b/clang-tools-extra/clang-tidy/modernize/UseConstraintsCheck.cpp
@@ -254,7 +254,7 @@ findInsertionForConstraint(const FunctionDecl *Function, 
ASTContext ) {
 return utils::lexer::findPreviousTokenKind(Init->getSourceLocation(),
SM, LangOpts, tok::colon);
 }
-if (Constructor->init_begin() != Constructor->init_end())
+if (!Constructor->inits().empty())
   return std::nullopt;
   }
   if (Function->isDeleted()) {

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits