[flang] [llvm] [lld] [clang] [AMDGPU] Introduce GFX9/10.1/10.3/11 Generic Targets (PR #76955)

[Alex Voicu via cfe-commits]

@@ -49,6 +49,11 @@ constexpr uint32_t VersionMajorV5 = 1;
 /// HSA metadata minor version for code object V5.
 constexpr uint32_t VersionMinorV5 = 2;
 
+/// HSA metadata major version for code object V6.
+constexpr uint32_t VersionMajorV6 = 1;
+/// HSA metadata minor version for code object V6.
+constexpr uint32_t VersionMinorV6 = 3;

AlexVlx wrote:

Minor nit: there's formally no HSA 1.3, as far as I recall (things stopped at 
1.2). Someone looking at this might erroneously infer it exists as a foundation 
mandated standard (and go look up the documentation), or assume it's coming 
soonTM. It might be beneficial to call that out here, since it would be 
difficult to break the current progression / use of "HSA" metadata.

https://github.com/llvm/llvm-project/pull/76955
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[flang] [llvm] [lld] [clang] [AMDGPU] Introduce GFX9/10.1/10.3/11 Generic Targets (PR #76955)

[Alex Voicu via cfe-commits]

https://github.com/AlexVlx approved this pull request.

LGTM in general, versioning seems fine; I had a pair of very minor 
nits/questions, but they're not blocking concerns. Thanks!

https://github.com/llvm/llvm-project/pull/76955
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[flang] [llvm] [lld] [clang] [AMDGPU] Introduce GFX9/10.1/10.3/11 Generic Targets (PR #76955)

[Tony Tye via cfe-commits]

https://github.com/t-tye requested changes to this pull request.


https://github.com/llvm/llvm-project/pull/76955
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[flang] [llvm] [lld] [clang] [AMDGPU] Introduce GFX9/10.1/10.3/11 Generic Targets (PR #76955)

[Pierre van Houtryve via cfe-commits]

@@ -792,6 +793,17 @@ enum : unsigned {
   EF_AMDGPU_MACH_AMDGCN_FIRST = EF_AMDGPU_MACH_AMDGCN_GFX600,
   EF_AMDGPU_MACH_AMDGCN_LAST = EF_AMDGPU_MACH_AMDGCN_GFX1201,
 
+  // Generic AMDGCN processors
+  // clang-format off
+  EF_AMDGPU_MACH_AMDGCN_GFX9_GENERIC  = 0x0c0,

Pierre-vh wrote:

TODO: put it in the list above instead of its own namespace

https://github.com/llvm/llvm-project/pull/76955
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits