Re: [libcxx] r292607 - Don't default older GCC's to C++17, but C++14 or C++11 instead

2017-01-27 Thread Hans Wennborg via cfe-commits 
On Thu, Jan 26, 2017 at 6:09 PM, Marshall Clow  wrote:
> On Thu, Jan 26, 2017 at 10:22 AM, Hans Wennborg  wrote:
>>
>> What's the status here? Waiting for Marshall?
>
>
> I'm fine with merging this to the 4.0 branch

Merged in r293301.

Thanks,
Hans
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [libcxx] r292607 - Don't default older GCC's to C++17, but C++14 or C++11 instead

2017-01-26 Thread Marshall Clow via cfe-commits 
On Thu, Jan 26, 2017 at 10:22 AM, Hans Wennborg  wrote:

> What's the status here? Waiting for Marshall?
>

I'm fine with merging this to the 4.0 branch

-- Marshall
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [libcxx] r292607 - Don't default older GCC's to C++17, but C++14 or C++11 instead

2017-01-26 Thread Renato Golin via cfe-commits 
On 26 January 2017 at 18:22, Hans Wennborg  wrote:
> What's the status here? Waiting for Marshall?

Possibly. I can confirm this made all the problem on ARM go away with
GCC 5.3 and 6.3.
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [libcxx] r292607 - Don't default older GCC's to C++17, but C++14 or C++11 instead

2017-01-26 Thread Hans Wennborg via cfe-commits 
What's the status here? Waiting for Marshall?

On Mon, Jan 23, 2017 at 10:20 AM, Hans Wennborg  wrote:
> Sounds good to me.
>
> On Fri, Jan 20, 2017 at 11:38 AM, Eric Fiselier  wrote:
>> We should merge this patch into the 4.0 release branch. It is needed to make
>> "check-all" pass when using GCC 4, 5 and 6.
>>
>> /Eric
>>
>> On Fri, Jan 20, 2017 at 5:54 AM, Eric Fiselier via cfe-commits
>>  wrote:
>>>
>>> Author: ericwf
>>> Date: Fri Jan 20 06:54:45 2017
>>> New Revision: 292607
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=292607&view=rev
>>> Log:
>>> Don't default older GCC's to C++17, but C++14 or C++11 instead
>>>
>>> Modified:
>>> libcxx/trunk/test/libcxx/test/config.py
>>>
>>> Modified: libcxx/trunk/test/libcxx/test/config.py
>>> URL:
>>> http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/libcxx/test/config.py?rev=292607&r1=292606&r2=292607&view=diff
>>>
>>> ==
>>> --- libcxx/trunk/test/libcxx/test/config.py (original)
>>> +++ libcxx/trunk/test/libcxx/test/config.py Fri Jan 20 06:54:45 2017
>>> @@ -423,6 +423,15 @@ class Configuration(object):
>>>  if not std:
>>>  # Choose the newest possible language dialect if none is
>>> given.
>>>  possible_stds = ['c++1z', 'c++14', 'c++11', 'c++03']
>>> +if self.cxx.type == 'gcc':
>>> +maj_v, _, _ = self.cxx.version
>>> +maj_v = int(maj_v)
>>> +if maj_v < 7:
>>> +possible_stds.remove('c++1z')
>>> +# FIXME: How many C++14 tests actually fail under GCC 5
>>> and 6?
>>> +# Should we XFAIL them individually instead?
>>> +if maj_v <= 6:
>>> +possible_stds.remove('c++14')
>>>  for s in possible_stds:
>>>  if self.cxx.hasCompileFlag('-std=%s' % s):
>>>  std = s
>>>
>>>
>>> ___
>>> cfe-commits mailing list
>>> cfe-commits@lists.llvm.org
>>> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>>
>>
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [libcxx] r292607 - Don't default older GCC's to C++17, but C++14 or C++11 instead

2017-01-23 Thread Hans Wennborg via cfe-commits 
Sounds good to me.

On Fri, Jan 20, 2017 at 11:38 AM, Eric Fiselier  wrote:
> We should merge this patch into the 4.0 release branch. It is needed to make
> "check-all" pass when using GCC 4, 5 and 6.
>
> /Eric
>
> On Fri, Jan 20, 2017 at 5:54 AM, Eric Fiselier via cfe-commits
>  wrote:
>>
>> Author: ericwf
>> Date: Fri Jan 20 06:54:45 2017
>> New Revision: 292607
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=292607&view=rev
>> Log:
>> Don't default older GCC's to C++17, but C++14 or C++11 instead
>>
>> Modified:
>> libcxx/trunk/test/libcxx/test/config.py
>>
>> Modified: libcxx/trunk/test/libcxx/test/config.py
>> URL:
>> http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/libcxx/test/config.py?rev=292607&r1=292606&r2=292607&view=diff
>>
>> ==
>> --- libcxx/trunk/test/libcxx/test/config.py (original)
>> +++ libcxx/trunk/test/libcxx/test/config.py Fri Jan 20 06:54:45 2017
>> @@ -423,6 +423,15 @@ class Configuration(object):
>>  if not std:
>>  # Choose the newest possible language dialect if none is
>> given.
>>  possible_stds = ['c++1z', 'c++14', 'c++11', 'c++03']
>> +if self.cxx.type == 'gcc':
>> +maj_v, _, _ = self.cxx.version
>> +maj_v = int(maj_v)
>> +if maj_v < 7:
>> +possible_stds.remove('c++1z')
>> +# FIXME: How many C++14 tests actually fail under GCC 5
>> and 6?
>> +# Should we XFAIL them individually instead?
>> +if maj_v <= 6:
>> +possible_stds.remove('c++14')
>>  for s in possible_stds:
>>  if self.cxx.hasCompileFlag('-std=%s' % s):
>>  std = s
>>
>>
>> ___
>> cfe-commits mailing list
>> cfe-commits@lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>
>
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [libcxx] r292607 - Don't default older GCC's to C++17, but C++14 or C++11 instead

2017-01-20 Thread Eric Fiselier via cfe-commits 
We should merge this patch into the 4.0 release branch. It is needed to
make "check-all" pass when using GCC 4, 5 and 6.

/Eric

On Fri, Jan 20, 2017 at 5:54 AM, Eric Fiselier via cfe-commits <
cfe-commits@lists.llvm.org> wrote:

> Author: ericwf
> Date: Fri Jan 20 06:54:45 2017
> New Revision: 292607
>
> URL: http://llvm.org/viewvc/llvm-project?rev=292607&view=rev
> Log:
> Don't default older GCC's to C++17, but C++14 or C++11 instead
>
> Modified:
> libcxx/trunk/test/libcxx/test/config.py
>
> Modified: libcxx/trunk/test/libcxx/test/config.py
> URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/
> libcxx/test/config.py?rev=292607&r1=292606&r2=292607&view=diff
> 
> ==
> --- libcxx/trunk/test/libcxx/test/config.py (original)
> +++ libcxx/trunk/test/libcxx/test/config.py Fri Jan 20 06:54:45 2017
> @@ -423,6 +423,15 @@ class Configuration(object):
>  if not std:
>  # Choose the newest possible language dialect if none is
> given.
>  possible_stds = ['c++1z', 'c++14', 'c++11', 'c++03']
> +if self.cxx.type == 'gcc':
> +maj_v, _, _ = self.cxx.version
> +maj_v = int(maj_v)
> +if maj_v < 7:
> +possible_stds.remove('c++1z')
> +# FIXME: How many C++14 tests actually fail under GCC 5
> and 6?
> +# Should we XFAIL them individually instead?
> +if maj_v <= 6:
> +possible_stds.remove('c++14')
>  for s in possible_stds:
>  if self.cxx.hasCompileFlag('-std=%s' % s):
>  std = s
>
>
> ___
> cfe-commits mailing list
> cfe-commits@lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r292607 - Don't default older GCC's to C++17, but C++14 or C++11 instead

2017-01-20 Thread Eric Fiselier via cfe-commits 
Author: ericwf
Date: Fri Jan 20 06:54:45 2017
New Revision: 292607

URL: http://llvm.org/viewvc/llvm-project?rev=292607&view=rev
Log:
Don't default older GCC's to C++17, but C++14 or C++11 instead

Modified:
libcxx/trunk/test/libcxx/test/config.py

Modified: libcxx/trunk/test/libcxx/test/config.py
URL: 
http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/libcxx/test/config.py?rev=292607&r1=292606&r2=292607&view=diff
==
--- libcxx/trunk/test/libcxx/test/config.py (original)
+++ libcxx/trunk/test/libcxx/test/config.py Fri Jan 20 06:54:45 2017
@@ -423,6 +423,15 @@ class Configuration(object):
 if not std:
 # Choose the newest possible language dialect if none is given.
 possible_stds = ['c++1z', 'c++14', 'c++11', 'c++03']
+if self.cxx.type == 'gcc':
+maj_v, _, _ = self.cxx.version
+maj_v = int(maj_v)
+if maj_v < 7:
+possible_stds.remove('c++1z')
+# FIXME: How many C++14 tests actually fail under GCC 5 and 6?
+# Should we XFAIL them individually instead?
+if maj_v <= 6:
+possible_stds.remove('c++14')
 for s in possible_stds:
 if self.cxx.hasCompileFlag('-std=%s' % s):
 std = s


___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits