UmeshKalappa0 wrote: > Scattering around `setDSOLocal(false)` makes the logic hard to understand. > I'd strongly prefer to fix the initial setting of dso_local when we create > the global variable. We can refactor the code to make that work.
@efriedma-quic ,thank you for the suggestions and was not sure about adding dso_local for openmp weak linkage vars ,but from the weak semantics point ,its ok to add the dso_local for no-pic /no-pie code ,so updated changes accordingly . https://github.com/llvm/llvm-project/pull/75564 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
