RE: [clang] b670ab7 - recommit 1b978ddba05c [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese
[AMD Official Use Only - Internal Distribution Only] commit 2c31aa2de13a23a00ced87123b92e905f2929c7b should fix this. Thanks. Sam -Original Message- From: Liu, Yaxun (Sam) Sent: Sunday, April 5, 2020 12:20 PM To: Joerg Sonnenberger ; Yaxun Liu Cc: cfe-commits@lists.llvm.org Subject: RE: [clang] b670ab7 - recommit 1b978ddba05c [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese [AMD Official Use Only - Internal Distribution Only] The issue is addressed by https://reviews.llvm.org/D77028 Sam -Original Message- From: Joerg Sonnenberger Sent: Sunday, April 5, 2020 9:48 AM To: Liu, Yaxun (Sam) ; Yaxun Liu Cc: cfe-commits@lists.llvm.org Subject: Re: [clang] b670ab7 - recommit 1b978ddba05c [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese [CAUTION: External Email] On Mon, Mar 23, 2020 at 09:09:31AM -0700, Yaxun Liu via cfe-commits wrote: > > Author: Yaxun (Sam) Liu > Date: 2020-03-23T12:09:07-04:00 > New Revision: b670ab7b6b3d2f26179213be1da1d4ba376f50a3 > > URL: > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith > ub.com%2Fllvm%2Fllvm-project%2Fcommit%2Fb670ab7b6b3d2f26179213be1da1d4 > ba376f50a3data=02%7C01%7Cyaxun.liu%40amd.com%7Cfc099ddf95594ab17e > da08d7d968004e%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C6372169134 > 68808969sdata=WtAm5JbQgR7UDY0FL5AlIvZOSOLPbQTRbKHJvP0Vot8%3D > reserved=0 > DIFF: > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith > ub.com%2Fllvm%2Fllvm-project%2Fcommit%2Fb670ab7b6b3d2f26179213be1da1d4 > ba376f50a3.diffdata=02%7C01%7Cyaxun.liu%40amd.com%7Cfc099ddf95594 > ab17eda08d7d968004e%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C63721 > 6913468808969sdata=wREjtZ%2F5SHC1U4dxGbbSvYYncnhqa%2ByJzHBxv%2FIh > PlY%3Dreserved=0 > > LOG: recommit 1b978ddba05c [CUDA][HIP][OpenMP] Emit deferred > diagnostics by a post-parsing AST travese This change is responsible for a significant performance regression. Somewhat reduced example is attached. With -fopenmp, it needs ~5s, without 0.02s. Joerg ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
RE: [clang] b670ab7 - recommit 1b978ddba05c [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese
[AMD Official Use Only - Internal Distribution Only] The issue is addressed by https://reviews.llvm.org/D77028 Sam -Original Message- From: Joerg Sonnenberger Sent: Sunday, April 5, 2020 9:48 AM To: Liu, Yaxun (Sam) ; Yaxun Liu Cc: cfe-commits@lists.llvm.org Subject: Re: [clang] b670ab7 - recommit 1b978ddba05c [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese [CAUTION: External Email] On Mon, Mar 23, 2020 at 09:09:31AM -0700, Yaxun Liu via cfe-commits wrote: > > Author: Yaxun (Sam) Liu > Date: 2020-03-23T12:09:07-04:00 > New Revision: b670ab7b6b3d2f26179213be1da1d4ba376f50a3 > > URL: > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith > ub.com%2Fllvm%2Fllvm-project%2Fcommit%2Fb670ab7b6b3d2f26179213be1da1d4 > ba376f50a3data=02%7C01%7Cyaxun.liu%40amd.com%7Cfc099ddf95594ab17e > da08d7d968004e%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C6372169134 > 68808969sdata=WtAm5JbQgR7UDY0FL5AlIvZOSOLPbQTRbKHJvP0Vot8%3D > reserved=0 > DIFF: > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith > ub.com%2Fllvm%2Fllvm-project%2Fcommit%2Fb670ab7b6b3d2f26179213be1da1d4 > ba376f50a3.diffdata=02%7C01%7Cyaxun.liu%40amd.com%7Cfc099ddf95594 > ab17eda08d7d968004e%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C63721 > 6913468808969sdata=wREjtZ%2F5SHC1U4dxGbbSvYYncnhqa%2ByJzHBxv%2FIh > PlY%3Dreserved=0 > > LOG: recommit 1b978ddba05c [CUDA][HIP][OpenMP] Emit deferred > diagnostics by a post-parsing AST travese This change is responsible for a significant performance regression. Somewhat reduced example is attached. With -fopenmp, it needs ~5s, without 0.02s. Joerg ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [clang] b670ab7 - recommit 1b978ddba05c [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese
On Mon, Mar 23, 2020 at 09:09:31AM -0700, Yaxun Liu via cfe-commits wrote: > > Author: Yaxun (Sam) Liu > Date: 2020-03-23T12:09:07-04:00 > New Revision: b670ab7b6b3d2f26179213be1da1d4ba376f50a3 > > URL: > https://github.com/llvm/llvm-project/commit/b670ab7b6b3d2f26179213be1da1d4ba376f50a3 > DIFF: > https://github.com/llvm/llvm-project/commit/b670ab7b6b3d2f26179213be1da1d4ba376f50a3.diff > > LOG: recommit 1b978ddba05c [CUDA][HIP][OpenMP] Emit deferred diagnostics by a > post-parsing AST travese This change is responsible for a significant performance regression. Somewhat reduced example is attached. With -fopenmp, it needs ~5s, without 0.02s. Joerg ; ; namespace std { inline namespace __1 { template struct char_traits; template class basic_ostream; typedef basic_ostream ostream; template basic_ostream<_Traits>& operator<<(basic_ostream<_Traits>& __os, const char* __str) ; extern ostream cerr; } ; } template class flet { public: flet(T , const T ) ; }; ; template class _scoped_numeral { typedef typename Manager::numeral numeral; public: _scoped_numeral(Manager ) ; operator numeral&() ; }; template class buffer { public: ; unsigned size() const ; ; ; T & operator[](unsigned idxT ) ; }; template class buffer ; template class sbuffer : public buffer { }; class mpz { public: mpz(int v) ; }; template class mpz_manager { public: ; typedef mpz numeral; void mul2k(mpz , unsigned k, mpz r) ; }; typedef mpz_manager unsynch_mpz_manager; typedef _scoped_numeral scoped_mpz; class mpq { }; template class mpq_manager : public mpz_manager { public: typedef mpq numeral; bool is_zero; void mul( mpq b, mpq ) ; void set(mpq , mpq source) ; }; typedef mpq_manager unsynch_mpq_manager; typedef _scoped_numeral scoped_mpq; ; template class interval_manager { public: ; typedef typename C::interval interval; bool is_P(interval n) const ; void set(interval , interval s); void neg(interval a, interval ); void add(interval a, interval b, interval ); void mul(interval a, interval b, interval ); }; template class _scoped_interval { typedef typename Manager::interval interval; public: _scoped_interval(Manager ) ; operator interval&() ; }; namespace realclosure { class num; ; class manager { struct imp; typedef num numeral; }; struct value; class num { friend class