RE: r260333 - This patch adds doxygen comments for all the intrinsincs in the header file f16cintrin.h. The doxygen comments are automatically generated based on Sony's intrinsics document.

2016-02-11 Thread Romanova, Katya via cfe-commits 
Sure. I’ll change it. Do you mind if I do it when I’m back from vacation (i.e. 
a couple of weeks from now)?
I will send a patch.
Thank you!
Katya.

From: Eric Christopher [mailto:echri...@gmail.com]
Sent: Wednesday, February 10, 2016 5:08 PM
To: Romanova, Katya; cfe-commits@lists.llvm.org
Subject: Re: r260333 - This patch adds doxygen comments for all the intrinsincs 
in the header file f16cintrin.h. The doxygen comments are automatically 
generated based on Sony's intrinsics document.


On Wed, Feb 10, 2016 at 5:07 PM Joerg Sonnenberger 
> wrote:
On Thu, Feb 11, 2016 at 12:18:49AM +, Eric Christopher via cfe-commits 
wrote:
> Mostly that you didn't mention it in your commit message.
>
> I'd rather prefer the rest of the file be changed to match the __ rather
> than the other way around :)

Depends. If it is a macro, not using __ is fine. If it is an inline
function, it *must* use the protected namespace, since an application can
#define a fancy junk here.

Yep. Which is why I'd prefer the rest of the file changed to match the __. I 
was just trying to get Katya to do it :)

-eric
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r260333 - This patch adds doxygen comments for all the intrinsincs in the header file f16cintrin.h. The doxygen comments are automatically generated based on Sony's intrinsics document.

2016-02-10 Thread Eric Christopher via cfe-commits 
Mostly that you didn't mention it in your commit message.

I'd rather prefer the rest of the file be changed to match the __ rather
than the other way around :)

-eric

On Wed, Feb 10, 2016 at 4:14 PM Romanova, Katya <
katya_roman...@playstation.sony.com> wrote:

> Hi Eric,
>
> Everywhere else in this file formal parameter “a” is used. This one “__a”
>  was inconsistent.
>
> However, if you don’t like it, I could change it back.
>
>
>
> Katya.
>
>
>
> *From:* Eric Christopher [mailto:echri...@gmail.com]
> *Sent:* Wednesday, February 10, 2016 3:16 PM
> *To:* Romanova, Katya; cfe-commits@lists.llvm.org
> *Subject:* Re: r260333 - This patch adds doxygen comments for all the
> intrinsincs in the header file f16cintrin.h. The doxygen comments are
> automatically generated based on Sony's intrinsics document.
>
>
>
>
>
> On Tue, Feb 9, 2016 at 4:16 PM Ekaterina Romanova via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
> Author: kromanova
> Date: Tue Feb  9 18:12:24 2016
> New Revision: 260333
>
> URL: http://llvm.org/viewvc/llvm-project?rev=260333=rev
> Log:
> This patch adds doxygen comments for all the intrinsincs in the header
> file f16cintrin.h. The doxygen comments are automatically generated based
> on Sony's intrinsics document.
>
> -_mm_cvtph_ps(__m128i __a)
> +_mm_cvtph_ps(__m128i a)
>  {
> -  return (__m128)__builtin_ia32_vcvtph2ps((__v8hi)__a);
> +  return (__m128)__builtin_ia32_vcvtph2ps((__v8hi)a);
>  }
>
>
>
> Ur? What's with this change?
>
>
>
> -eric
>
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

RE: r260333 - This patch adds doxygen comments for all the intrinsincs in the header file f16cintrin.h. The doxygen comments are automatically generated based on Sony's intrinsics document.

2016-02-10 Thread Romanova, Katya via cfe-commits 
Hi Eric,
Everywhere else in this file formal parameter “a” is used. This one “__a”  was 
inconsistent.
However, if you don’t like it, I could change it back.

Katya.

From: Eric Christopher [mailto:echri...@gmail.com]
Sent: Wednesday, February 10, 2016 3:16 PM
To: Romanova, Katya; cfe-commits@lists.llvm.org
Subject: Re: r260333 - This patch adds doxygen comments for all the intrinsincs 
in the header file f16cintrin.h. The doxygen comments are automatically 
generated based on Sony's intrinsics document.


On Tue, Feb 9, 2016 at 4:16 PM Ekaterina Romanova via cfe-commits 
> wrote:
Author: kromanova
Date: Tue Feb  9 18:12:24 2016
New Revision: 260333

URL: http://llvm.org/viewvc/llvm-project?rev=260333=rev
Log:
This patch adds doxygen comments for all the intrinsincs in the header file 
f16cintrin.h. The doxygen comments are automatically generated based on Sony's 
intrinsics document.

-_mm_cvtph_ps(__m128i __a)
+_mm_cvtph_ps(__m128i a)
 {
-  return (__m128)__builtin_ia32_vcvtph2ps((__v8hi)__a);
+  return (__m128)__builtin_ia32_vcvtph2ps((__v8hi)a);
 }

Ur? What's with this change?

-eric
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r260333 - This patch adds doxygen comments for all the intrinsincs in the header file f16cintrin.h. The doxygen comments are automatically generated based on Sony's intrinsics document.

2016-02-10 Thread Eric Christopher via cfe-commits 
On Wed, Feb 10, 2016 at 5:07 PM Joerg Sonnenberger 
wrote:

> On Thu, Feb 11, 2016 at 12:18:49AM +, Eric Christopher via cfe-commits
> wrote:
> > Mostly that you didn't mention it in your commit message.
> >
> > I'd rather prefer the rest of the file be changed to match the __ rather
> > than the other way around :)
>
> Depends. If it is a macro, not using __ is fine. If it is an inline
> function, it *must* use the protected namespace, since an application can
> #define a fancy junk here.
>
>
Yep. Which is why I'd prefer the rest of the file changed to match the __.
I was just trying to get Katya to do it :)

-eric
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits