Re: r285027 - Fix test on non-X86 platforms

2016-10-24 Thread Renato Golin via cfe-commits 
Hi Mehdi, it's also failing on aarch64:

http://lab.llvm.org:8011/builders/clang-cmake-aarch64-42vma/builds/47

And current build was still red. Not to mention all arm bots. Maybe
reverting and trying offline next time.

I can help you with arm environments, if you need.

Cheers,
Renato

On 24 Oct 2016 23:53, "Mehdi Amini via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:

> The test is validating pointer size as well, so it is failing on 32 bits
> right now.
>
> I could try to differentiate some of the check and have them work on both
> size, but I can’t verify that the runtime works (I don’t have a 32 bits
> runtime).
>
> —
> Mehdi
>
>
> On Oct 24, 2016, at 2:48 PM, Craig Topper  wrote:
>
> Doesn't this exclude 32-bit x86?
>
> ~Craig
>
> On Mon, Oct 24, 2016 at 2:22 PM, Mehdi Amini via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: mehdi_amini
>> Date: Mon Oct 24 16:22:01 2016
>> New Revision: 285027
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=285027=rev
>> Log:
>> Fix test on non-X86 platforms
>>
>> This is a fixup for r285019, adding an `#ifdef __x86_64__` since
>> the os_log builtin is platform specific.
>>
>> Modified:
>> cfe/trunk/test/CodeGen/builtins.c
>>
>> Modified: cfe/trunk/test/CodeGen/builtins.c
>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/
>> builtins.c?rev=285027=285026=285027=diff
>> 
>> ==
>> --- cfe/trunk/test/CodeGen/builtins.c (original)
>> +++ cfe/trunk/test/CodeGen/builtins.c Mon Oct 24 16:22:01 2016
>> @@ -369,6 +369,9 @@ long long test_builtin_readcyclecounter(
>>return __builtin_readcyclecounter();
>>  }
>>
>> +// Behavior of __builtin_os_log differs between platforms, so only test
>> on X86
>> +#ifdef __x86_64__
>> +
>>  // CHECK-LABEL: define void @test_builtin_os_log
>>  // CHECK: (i8* [[BUF:%.*]], i32 [[I:%.*]], i8* [[DATA:%.*]])
>>  void test_builtin_os_log(void *buf, int i, const char *data) {
>> @@ -506,3 +509,5 @@ void test_builtin_os_log_percent(void *b
>>// CHECK: store i8* [[DATA2]], i8** [[ARG1_PTR]]
>>__builtin_os_log_format(buf, "%s %%", data);
>>  }
>> +
>> +#endif
>> \ No newline at end of file
>>
>>
>> ___
>> cfe-commits mailing list
>> cfe-commits@lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>>
>
>
>
> ___
> cfe-commits mailing list
> cfe-commits@lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>
>
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r285027 - Fix test on non-X86 platforms

2016-10-24 Thread Mehdi Amini via cfe-commits 
The test is validating pointer size as well, so it is failing on 32 bits right 
now.

I could try to differentiate some of the check and have them work on both size, 
but I can’t verify that the runtime works (I don’t have a 32 bits runtime).

— 
Mehdi


> On Oct 24, 2016, at 2:48 PM, Craig Topper  wrote:
> 
> Doesn't this exclude 32-bit x86?
> 
> ~Craig
> 
> On Mon, Oct 24, 2016 at 2:22 PM, Mehdi Amini via cfe-commits 
> > wrote:
> Author: mehdi_amini
> Date: Mon Oct 24 16:22:01 2016
> New Revision: 285027
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=285027=rev 
> 
> Log:
> Fix test on non-X86 platforms
> 
> This is a fixup for r285019, adding an `#ifdef __x86_64__` since
> the os_log builtin is platform specific.
> 
> Modified:
> cfe/trunk/test/CodeGen/builtins.c
> 
> Modified: cfe/trunk/test/CodeGen/builtins.c
> URL: 
> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/builtins.c?rev=285027=285026=285027=diff
>  
> 
> ==
> --- cfe/trunk/test/CodeGen/builtins.c (original)
> +++ cfe/trunk/test/CodeGen/builtins.c Mon Oct 24 16:22:01 2016
> @@ -369,6 +369,9 @@ long long test_builtin_readcyclecounter(
>return __builtin_readcyclecounter();
>  }
> 
> +// Behavior of __builtin_os_log differs between platforms, so only test on 
> X86
> +#ifdef __x86_64__
> +
>  // CHECK-LABEL: define void @test_builtin_os_log
>  // CHECK: (i8* [[BUF:%.*]], i32 [[I:%.*]], i8* [[DATA:%.*]])
>  void test_builtin_os_log(void *buf, int i, const char *data) {
> @@ -506,3 +509,5 @@ void test_builtin_os_log_percent(void *b
>// CHECK: store i8* [[DATA2]], i8** [[ARG1_PTR]]
>__builtin_os_log_format(buf, "%s %%", data);
>  }
> +
> +#endif
> \ No newline at end of file
> 
> 
> ___
> cfe-commits mailing list
> cfe-commits@lists.llvm.org 
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits 
> 
> 

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r285027 - Fix test on non-X86 platforms

2016-10-24 Thread Craig Topper via cfe-commits 
Doesn't this exclude 32-bit x86?

~Craig

On Mon, Oct 24, 2016 at 2:22 PM, Mehdi Amini via cfe-commits <
cfe-commits@lists.llvm.org> wrote:

> Author: mehdi_amini
> Date: Mon Oct 24 16:22:01 2016
> New Revision: 285027
>
> URL: http://llvm.org/viewvc/llvm-project?rev=285027=rev
> Log:
> Fix test on non-X86 platforms
>
> This is a fixup for r285019, adding an `#ifdef __x86_64__` since
> the os_log builtin is platform specific.
>
> Modified:
> cfe/trunk/test/CodeGen/builtins.c
>
> Modified: cfe/trunk/test/CodeGen/builtins.c
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/
> CodeGen/builtins.c?rev=285027=285026=285027=diff
> 
> ==
> --- cfe/trunk/test/CodeGen/builtins.c (original)
> +++ cfe/trunk/test/CodeGen/builtins.c Mon Oct 24 16:22:01 2016
> @@ -369,6 +369,9 @@ long long test_builtin_readcyclecounter(
>return __builtin_readcyclecounter();
>  }
>
> +// Behavior of __builtin_os_log differs between platforms, so only test
> on X86
> +#ifdef __x86_64__
> +
>  // CHECK-LABEL: define void @test_builtin_os_log
>  // CHECK: (i8* [[BUF:%.*]], i32 [[I:%.*]], i8* [[DATA:%.*]])
>  void test_builtin_os_log(void *buf, int i, const char *data) {
> @@ -506,3 +509,5 @@ void test_builtin_os_log_percent(void *b
>// CHECK: store i8* [[DATA2]], i8** [[ARG1_PTR]]
>__builtin_os_log_format(buf, "%s %%", data);
>  }
> +
> +#endif
> \ No newline at end of file
>
>
> ___
> cfe-commits mailing list
> cfe-commits@lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits