Author: epilk Date: Mon Jun 20 15:04:15 2016 New Revision: 273193 URL: http://llvm.org/viewvc/llvm-project?rev=273193&view=rev Log: [Sema] Only define function as move assignment when needed
Fixes PR27941, a crash on invalid. Differential revision: http://reviews.llvm.org/D20923 Modified: cfe/trunk/lib/Sema/SemaExpr.cpp cfe/trunk/test/SemaCXX/cxx0x-defaulted-functions.cpp Modified: cfe/trunk/lib/Sema/SemaExpr.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaExpr.cpp?rev=273193&r1=273192&r2=273193&view=diff ============================================================================== --- cfe/trunk/lib/Sema/SemaExpr.cpp (original) +++ cfe/trunk/lib/Sema/SemaExpr.cpp Mon Jun 20 15:04:15 2016 @@ -13012,7 +13012,7 @@ void Sema::MarkFunctionReferenced(Source if (MethodDecl->isDefaulted() && !MethodDecl->isDeleted()) { if (MethodDecl->isCopyAssignmentOperator()) DefineImplicitCopyAssignment(Loc, MethodDecl); - else + else if (MethodDecl->isMoveAssignmentOperator()) DefineImplicitMoveAssignment(Loc, MethodDecl); } } else if (isa<CXXConversionDecl>(MethodDecl) && Modified: cfe/trunk/test/SemaCXX/cxx0x-defaulted-functions.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaCXX/cxx0x-defaulted-functions.cpp?rev=273193&r1=273192&r2=273193&view=diff ============================================================================== --- cfe/trunk/test/SemaCXX/cxx0x-defaulted-functions.cpp (original) +++ cfe/trunk/test/SemaCXX/cxx0x-defaulted-functions.cpp Mon Jun 20 15:04:15 2016 @@ -196,3 +196,15 @@ namespace PR15597 { A<int> a; B<int> b; // expected-note {{here}} } + +namespace PR27941 { +struct ExplicitBool { + ExplicitBool &operator=(bool) = default; // expected-error{{only special member functions may be defaulted}} + int member; +}; + +int fn() { + ExplicitBool t; + t = true; +} +} _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits