r338893 - revert r338831 - Fix unused variable warning in tablegen generated code

[Erich Keane via cfe-commits]

Author: erichkeane
Date: Fri Aug  3 07:24:34 2018
New Revision: 338893

URL: http://llvm.org/viewvc/llvm-project?rev=338893=rev
Log:
revert r338831 - Fix unused variable warning in tablegen generated code

No longer necessary thanks to r338889 (and friends).

Modified:
cfe/trunk/utils/TableGen/ClangAttrEmitter.cpp

Modified: cfe/trunk/utils/TableGen/ClangAttrEmitter.cpp
URL: 
http://llvm.org/viewvc/llvm-project/cfe/trunk/utils/TableGen/ClangAttrEmitter.cpp?rev=338893=338892=338893=diff
==
--- cfe/trunk/utils/TableGen/ClangAttrEmitter.cpp (original)
+++ cfe/trunk/utils/TableGen/ClangAttrEmitter.cpp Fri Aug  3 07:24:34 2018
@@ -3274,15 +3274,11 @@ static std::string GenerateCustomApperta
 return "";
   }
 
-  const StringRef CheckCodeValue = Subject.getValueAsString("CheckCode");
-
   OS << "static bool " << FnName << "(const Decl *D) {\n";
-  if (CheckCodeValue != "false") {
-OS << "  if (const auto *S = dyn_cast<";
-OS << GetSubjectWithSuffix(Base);
-OS << ">(D))\n";
-OS << "return " << Subject.getValueAsString("CheckCode") << ";\n";
-  }
+  OS << "  if (const auto *S = dyn_cast<";
+  OS << GetSubjectWithSuffix(Base);
+  OS << ">(D))\n";
+  OS << "return " << Subject.getValueAsString("CheckCode") << ";\n";
   OS << "  return false;\n";
   OS << "}\n\n";
 


___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r338831 - Fix unused variable warning in tablegen generated code

[Karl-Johan Karlsson via cfe-commits]

Author: karka
Date: Fri Aug  3 02:13:15 2018
New Revision: 338831

URL: http://llvm.org/viewvc/llvm-project?rev=338831=rev
Log:
Fix unused variable warning in tablegen generated code

Modified:
cfe/trunk/utils/TableGen/ClangAttrEmitter.cpp

Modified: cfe/trunk/utils/TableGen/ClangAttrEmitter.cpp
URL: 
http://llvm.org/viewvc/llvm-project/cfe/trunk/utils/TableGen/ClangAttrEmitter.cpp?rev=338831=338830=338831=diff
==
--- cfe/trunk/utils/TableGen/ClangAttrEmitter.cpp (original)
+++ cfe/trunk/utils/TableGen/ClangAttrEmitter.cpp Fri Aug  3 02:13:15 2018
@@ -3274,11 +3274,15 @@ static std::string GenerateCustomApperta
 return "";
   }
 
+  const StringRef CheckCodeValue = Subject.getValueAsString("CheckCode");
+
   OS << "static bool " << FnName << "(const Decl *D) {\n";
-  OS << "  if (const auto *S = dyn_cast<";
-  OS << GetSubjectWithSuffix(Base);
-  OS << ">(D))\n";
-  OS << "return " << Subject.getValueAsString("CheckCode") << ";\n";
+  if (CheckCodeValue != "false") {
+OS << "  if (const auto *S = dyn_cast<";
+OS << GetSubjectWithSuffix(Base);
+OS << ">(D))\n";
+OS << "return " << Subject.getValueAsString("CheckCode") << ";\n";
+  }
   OS << "  return false;\n";
   OS << "}\n\n";
 


___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits