RE: r339307 - [CMake] Use normalized Windows target triples
Hi Petr, Various Windows bots have been failing with ~270 test failures, and this commit seems like the most probable culprit. For example: http://lab.llvm.org:8011/builders/clang-x86-ninja-win7/builds/12460 Could you please investigate? Thanks, --paulr > -Original Message- > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of > Petr Hosek via cfe-commits > Sent: Wednesday, August 08, 2018 10:16 PM > To: cfe-commits@lists.llvm.org > Subject: r339307 - [CMake] Use normalized Windows target triples > > Author: phosek > Date: Wed Aug 8 19:16:18 2018 > New Revision: 339307 > > URL: http://llvm.org/viewvc/llvm-project?rev=339307=rev > Log: > [CMake] Use normalized Windows target triples > > Changes the default Windows target triple returned by > GetHostTriple.cmake from the old environment names (which we wanted to > move away from) to newer, normalized ones. This also requires updating > all tests to use the new systems names in constraints. > > Differential Revision: https://reviews.llvm.org/D47381 > > Modified: > cfe/trunk/test/CodeGen/2007-06-18-SextAttrAggregate.c > cfe/trunk/test/CodeGenCXX/vtable-debug-info.cpp > cfe/trunk/test/Driver/coverage_no_integrated_as.c > cfe/trunk/test/Driver/crash-report-null.test > cfe/trunk/test/Driver/inhibit-downstream-commands.c > cfe/trunk/test/Driver/linker-opts.c > cfe/trunk/test/Driver/no-integrated-as.s > cfe/trunk/test/Lexer/cross-windows-on-linux.cpp > cfe/trunk/test/Modules/crash-vfs-path-emptydir-entries.m > cfe/trunk/test/Modules/crash-vfs-path-symlink-component.m > cfe/trunk/test/Modules/crash-vfs-path-symlink-topheader.m > cfe/trunk/test/Modules/crash-vfs-path-traversal.m > cfe/trunk/test/Modules/crash-vfs-relative-overlay.m > cfe/trunk/test/Modules/crash-vfs-umbrella-frameworks.m > cfe/trunk/test/SemaTemplate/instantiation-depth-default.cpp > cfe/trunk/test/VFS/umbrella-framework-import-skipnonexist.m > cfe/trunk/test/lit.cfg.py > > Modified: cfe/trunk/test/CodeGen/2007-06-18-SextAttrAggregate.c > URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/2007-06- > 18-SextAttrAggregate.c?rev=339307=339306=339307=diff > == > > --- cfe/trunk/test/CodeGen/2007-06-18-SextAttrAggregate.c (original) > +++ cfe/trunk/test/CodeGen/2007-06-18-SextAttrAggregate.c Wed Aug 8 > 19:16:18 2018 > @@ -1,5 +1,5 @@ > // RUN: %clang_cc1 %s -o - -emit-llvm | FileCheck %s > -// XFAIL: aarch64, arm64, x86_64-pc-win32, x86_64-w64-mingw32, x86_64-pc- > windows-gnu > +// XFAIL: aarch64, arm64, x86_64-pc-windows-msvc, x86_64-w64-windows-gnu, > x86_64-pc-windows-gnu > > // PR1513 > > > Modified: cfe/trunk/test/CodeGenCXX/vtable-debug-info.cpp > URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/vtable- > debug-info.cpp?rev=339307=339306=339307=diff > == > > --- cfe/trunk/test/CodeGenCXX/vtable-debug-info.cpp (original) > +++ cfe/trunk/test/CodeGenCXX/vtable-debug-info.cpp Wed Aug 8 19:16:18 > 2018 > @@ -1,6 +1,6 @@ > // RUN: %clang -emit-llvm -S -g %s -o /dev/null > // Radar 8730409 > -// XFAIL: win32 > +// XFAIL: windows-msvc > > // FIXME: This test crashes on *-pc-win32 > // for lack of debugging support on -integrated-as (MCCOFF). > > Modified: cfe/trunk/test/Driver/coverage_no_integrated_as.c > URL: http://llvm.org/viewvc/llvm- > project/cfe/trunk/test/Driver/coverage_no_integrated_as.c?rev=339307=33 > 9306=339307=diff > == > > --- cfe/trunk/test/Driver/coverage_no_integrated_as.c (original) > +++ cfe/trunk/test/Driver/coverage_no_integrated_as.c Wed Aug 8 19:16:18 > 2018 > @@ -1,5 +1,5 @@ > // REQUIRES: clang-driver > -// XFAIL: win32,win64 > +// XFAIL: windows-msvc > > // RUN: %clang -### -S -fprofile-arcs %s 2>&1 | FileCheck -check- > prefix=CHECK-GCNO-DEFAULT-LOCATION %s > // RUN: %clang -### -S -fprofile-arcs -no-integrated-as %s 2>&1 | > FileCheck -check-prefix=CHECK-GCNO-DEFAULT-LOCATION %s > > Modified: cfe/trunk/test/Driver/crash-report-null.test > URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/crash- > report-null.test?rev=339307=339306=339307=diff > == > > --- cfe/trunk/test/Driver/crash-report-null.test (original) > +++ cfe/trunk/test/Driver/crash-report-null.test Wed Aug 8 19:16:18 2018 > @@ -1,7 +1,7 @@ > // RUN: not env FORCE_CLANG_DIAGNOSTICS_CRASH=1 %clang -fsyntax-only -x c >
r339307 - [CMake] Use normalized Windows target triples
Author: phosek
Date: Wed Aug 8 19:16:18 2018
New Revision: 339307
URL: http://llvm.org/viewvc/llvm-project?rev=339307=rev
Log:
[CMake] Use normalized Windows target triples
Changes the default Windows target triple returned by
GetHostTriple.cmake from the old environment names (which we wanted to
move away from) to newer, normalized ones. This also requires updating
all tests to use the new systems names in constraints.
Differential Revision: https://reviews.llvm.org/D47381
Modified:
cfe/trunk/test/CodeGen/2007-06-18-SextAttrAggregate.c
cfe/trunk/test/CodeGenCXX/vtable-debug-info.cpp
cfe/trunk/test/Driver/coverage_no_integrated_as.c
cfe/trunk/test/Driver/crash-report-null.test
cfe/trunk/test/Driver/inhibit-downstream-commands.c
cfe/trunk/test/Driver/linker-opts.c
cfe/trunk/test/Driver/no-integrated-as.s
cfe/trunk/test/Lexer/cross-windows-on-linux.cpp
cfe/trunk/test/Modules/crash-vfs-path-emptydir-entries.m
cfe/trunk/test/Modules/crash-vfs-path-symlink-component.m
cfe/trunk/test/Modules/crash-vfs-path-symlink-topheader.m
cfe/trunk/test/Modules/crash-vfs-path-traversal.m
cfe/trunk/test/Modules/crash-vfs-relative-overlay.m
cfe/trunk/test/Modules/crash-vfs-umbrella-frameworks.m
cfe/trunk/test/SemaTemplate/instantiation-depth-default.cpp
cfe/trunk/test/VFS/umbrella-framework-import-skipnonexist.m
cfe/trunk/test/lit.cfg.py
Modified: cfe/trunk/test/CodeGen/2007-06-18-SextAttrAggregate.c
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/2007-06-18-SextAttrAggregate.c?rev=339307=339306=339307=diff
==
--- cfe/trunk/test/CodeGen/2007-06-18-SextAttrAggregate.c (original)
+++ cfe/trunk/test/CodeGen/2007-06-18-SextAttrAggregate.c Wed Aug 8 19:16:18
2018
@@ -1,5 +1,5 @@
// RUN: %clang_cc1 %s -o - -emit-llvm | FileCheck %s
-// XFAIL: aarch64, arm64, x86_64-pc-win32, x86_64-w64-mingw32,
x86_64-pc-windows-gnu
+// XFAIL: aarch64, arm64, x86_64-pc-windows-msvc, x86_64-w64-windows-gnu,
x86_64-pc-windows-gnu
// PR1513
Modified: cfe/trunk/test/CodeGenCXX/vtable-debug-info.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/vtable-debug-info.cpp?rev=339307=339306=339307=diff
==
--- cfe/trunk/test/CodeGenCXX/vtable-debug-info.cpp (original)
+++ cfe/trunk/test/CodeGenCXX/vtable-debug-info.cpp Wed Aug 8 19:16:18 2018
@@ -1,6 +1,6 @@
// RUN: %clang -emit-llvm -S -g %s -o /dev/null
// Radar 8730409
-// XFAIL: win32
+// XFAIL: windows-msvc
// FIXME: This test crashes on *-pc-win32
// for lack of debugging support on -integrated-as (MCCOFF).
Modified: cfe/trunk/test/Driver/coverage_no_integrated_as.c
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/coverage_no_integrated_as.c?rev=339307=339306=339307=diff
==
--- cfe/trunk/test/Driver/coverage_no_integrated_as.c (original)
+++ cfe/trunk/test/Driver/coverage_no_integrated_as.c Wed Aug 8 19:16:18 2018
@@ -1,5 +1,5 @@
// REQUIRES: clang-driver
-// XFAIL: win32,win64
+// XFAIL: windows-msvc
// RUN: %clang -### -S -fprofile-arcs %s 2>&1 | FileCheck
-check-prefix=CHECK-GCNO-DEFAULT-LOCATION %s
// RUN: %clang -### -S -fprofile-arcs -no-integrated-as %s 2>&1 | FileCheck
-check-prefix=CHECK-GCNO-DEFAULT-LOCATION %s
Modified: cfe/trunk/test/Driver/crash-report-null.test
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/crash-report-null.test?rev=339307=339306=339307=diff
==
--- cfe/trunk/test/Driver/crash-report-null.test (original)
+++ cfe/trunk/test/Driver/crash-report-null.test Wed Aug 8 19:16:18 2018
@@ -1,7 +1,7 @@
// RUN: not env FORCE_CLANG_DIAGNOSTICS_CRASH=1 %clang -fsyntax-only -x c
/dev/null -lstdc++ 2>&1 | FileCheck %s
// FIXME: Investigating. "fatal error: file 'nul' modified since it was first
processed"
-// XFAIL: mingw32
+// XFAIL: windows-gnu
// CHECK: Preprocessed source(s) and associated run script(s) are located at:
// CHECK-NEXT: note: diagnostic msg: {{.*}}null-{{.*}}.c
Modified: cfe/trunk/test/Driver/inhibit-downstream-commands.c
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/inhibit-downstream-commands.c?rev=339307=339306=339307=diff
==
--- cfe/trunk/test/Driver/inhibit-downstream-commands.c (original)
+++ cfe/trunk/test/Driver/inhibit-downstream-commands.c Wed Aug 8 19:16:18 2018
@@ -2,5 +2,5 @@
// CHECK: error: unknown type name 'invalid'
// CHECK-NOT: clang: error: assembler command failed
// CHECK-NOT: clang: error: linker command failed
-// XFAIL: win32
+// XFAIL: windows-msvc
invalid C code!
Modified: cfe/trunk/test/Driver/linker-opts.c
URL:
[clang-tools-extra] r339307 - [CMake] Use normalized Windows target triples
Author: phosek
Date: Wed Aug 8 19:16:18 2018
New Revision: 339307
URL: http://llvm.org/viewvc/llvm-project?rev=339307=rev
Log:
[CMake] Use normalized Windows target triples
Changes the default Windows target triple returned by
GetHostTriple.cmake from the old environment names (which we wanted to
move away from) to newer, normalized ones. This also requires updating
all tests to use the new systems names in constraints.
Differential Revision: https://reviews.llvm.org/D47381
Modified:
clang-tools-extra/trunk/test/clangd/did-change-configuration-params.test
clang-tools-extra/trunk/test/clangd/test-uri-posix.test
clang-tools-extra/trunk/test/clangd/test-uri-windows.test
Modified:
clang-tools-extra/trunk/test/clangd/did-change-configuration-params.test
URL:
http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clangd/did-change-configuration-params.test?rev=339307=339306=339307=diff
==
--- clang-tools-extra/trunk/test/clangd/did-change-configuration-params.test
(original)
+++ clang-tools-extra/trunk/test/clangd/did-change-configuration-params.test
Wed Aug 8 19:16:18 2018
@@ -1,6 +1,6 @@
# RUN: clangd -compile_args_from=lsp -lit-test < %s 2> %t | FileCheck
-strict-whitespace %s
# RUN: cat %t | FileCheck --check-prefix=ERR %s
-# UNSUPPORTED: mingw32,win32
+# UNSUPPORTED: windows-gnu,windows-msvc
{"jsonrpc":"2.0","id":0,"method":"initialize","params":{"processId":123,"rootPath":"clangd","capabilities":{},"trace":"off"}}
---
{"jsonrpc":"2.0","method":"workspace/didChangeConfiguration","params":{"settings":{"compilationDatabaseChanges":{"/clangd-test/foo.c":
{"workingDirectory":"/clangd-test", "compilationCommand": ["clang", "-c",
"foo.c"]}
Modified: clang-tools-extra/trunk/test/clangd/test-uri-posix.test
URL:
http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clangd/test-uri-posix.test?rev=339307=339306=339307=diff
==
--- clang-tools-extra/trunk/test/clangd/test-uri-posix.test (original)
+++ clang-tools-extra/trunk/test/clangd/test-uri-posix.test Wed Aug 8 19:16:18
2018
@@ -1,5 +1,5 @@
# RUN: clangd -lit-test < %s | FileCheck -strict-whitespace %s
-# UNSUPPORTED: mingw32,win32
+# UNSUPPORTED: windows-gnu,windows-msvc
# Test authority-less URI
{"jsonrpc":"2.0","id":0,"method":"initialize","params":{"processId":123,"rootPath":"clangd","capabilities":{},"trace":"off"}}
---
Modified: clang-tools-extra/trunk/test/clangd/test-uri-windows.test
URL:
http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clangd/test-uri-windows.test?rev=339307=339306=339307=diff
==
--- clang-tools-extra/trunk/test/clangd/test-uri-windows.test (original)
+++ clang-tools-extra/trunk/test/clangd/test-uri-windows.test Wed Aug 8
19:16:18 2018
@@ -1,5 +1,5 @@
# RUN: clangd -lit-test < %s | FileCheck -strict-whitespace %s
-# REQUIRES: mingw32 || win32
+# REQUIRES: windows-gnu || windows-msvc
# Test authority-less URI
{"jsonrpc":"2.0","id":0,"method":"initialize","params":{"processId":123,"rootPath":"clangd","capabilities":{},"trace":"off"}}
---
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
