Re: r361340 - [Analysis] Link library dependencies to Analysis plugins
I've submitted a patch to fix this, https://reviews.llvm.org/D62445. Without it, non of the bots can build/test any plugins. On Fri, May 24, 2019 at 5:47 PM Akira Hatanaka via cfe-commits < cfe-commits@lists.llvm.org> wrote: > I reverted the patch in r361685 to make the bot green again. > > > On May 23, 2019, at 5:22 PM, Akira Hatanaka wrote: > > > > Hi Petr, > > > > This seems to have caused Analysis/checker-plugins.c to fail. Can you > investigate it or revert your commit? > > > > > http://green.lab.llvm.org/green/job/clang-stage2-cmake-RgSan/6381/consoleFull#-5275661368254eaf0-7326-4999-85b0-388101f2d404 > > > >> On May 21, 2019, at 5:47 PM, Petr Hosek via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> > >> Author: phosek > >> Date: Tue May 21 17:47:37 2019 > >> New Revision: 361340 > >> > >> URL: http://llvm.org/viewvc/llvm-project?rev=361340&view=rev > >> Log: > >> [Analysis] Link library dependencies to Analysis plugins > >> > >> These are needed to avoid undefined symbols which aren't satisfied > >> by Clang itself. > >> > >> Differential Revision: https://reviews.llvm.org/D62174 > >> > >> Modified: > >> > cfe/trunk/test/Analysis/plugins/CheckerDependencyHandling/CMakeLists.txt > >> cfe/trunk/test/Analysis/plugins/CheckerOptionHandling/CMakeLists.txt > >> cfe/trunk/test/Analysis/plugins/SampleAnalyzer/CMakeLists.txt > >> > >> Modified: > cfe/trunk/test/Analysis/plugins/CheckerDependencyHandling/CMakeLists.txt > >> URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Analysis/plugins/CheckerDependencyHandling/CMakeLists.txt?rev=361340&r1=361339&r2=361340&view=diff > >> > == > >> --- > cfe/trunk/test/Analysis/plugins/CheckerDependencyHandling/CMakeLists.txt > (original) > >> +++ > cfe/trunk/test/Analysis/plugins/CheckerDependencyHandling/CMakeLists.txt > Tue May 21 17:47:37 2019 > >> @@ -1,11 +1,12 @@ > >> set(LLVM_EXPORTED_SYMBOL_FILE > ${CMAKE_CURRENT_SOURCE_DIR}/CheckerDependencyHandlingAnalyzerPlugin.exports) > >> add_llvm_library(CheckerDependencyHandlingAnalyzerPlugin MODULE > CheckerDependencyHandling.cpp PLUGIN_TOOL clang) > >> > >> -if(LLVM_ENABLE_PLUGINS AND (WIN32 OR CYGWIN)) > >> +if(LLVM_ENABLE_PLUGINS) > >> target_link_libraries(CheckerDependencyHandlingAnalyzerPlugin PRIVATE > >>clangAnalysis > >>clangAST > >>clangStaticAnalyzerCore > >> +clangStaticAnalyzerFrontend > >>LLVMSupport > >>) > >> endif() > >> > >> Modified: > cfe/trunk/test/Analysis/plugins/CheckerOptionHandling/CMakeLists.txt > >> URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Analysis/plugins/CheckerOptionHandling/CMakeLists.txt?rev=361340&r1=361339&r2=361340&view=diff > >> > == > >> --- > cfe/trunk/test/Analysis/plugins/CheckerOptionHandling/CMakeLists.txt > (original) > >> +++ > cfe/trunk/test/Analysis/plugins/CheckerOptionHandling/CMakeLists.txt Tue > May 21 17:47:37 2019 > >> @@ -1,11 +1,12 @@ > >> set(LLVM_EXPORTED_SYMBOL_FILE > ${CMAKE_CURRENT_SOURCE_DIR}/CheckerOptionHandlingAnalyzerPlugin.exports) > >> add_llvm_library(CheckerOptionHandlingAnalyzerPlugin MODULE > CheckerOptionHandling.cpp PLUGIN_TOOL clang) > >> > >> -if(LLVM_ENABLE_PLUGINS AND (WIN32 OR CYGWIN)) > >> +if(LLVM_ENABLE_PLUGINS) > >> target_link_libraries(CheckerOptionHandlingAnalyzerPlugin PRIVATE > >>clangAnalysis > >>clangAST > >>clangStaticAnalyzerCore > >> +clangStaticAnalyzerFrontend > >>LLVMSupport > >>) > >> endif() > >> > >> Modified: cfe/trunk/test/Analysis/plugins/SampleAnalyzer/CMakeLists.txt > >> URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Analysis/plugins/SampleAnalyzer/CMakeLists.txt?rev=361340&r1=361339&r2=361340&view=diff > >> > == > >> --- cfe/trunk/test/Analysis/plugins/SampleAnalyzer/CMakeLists.txt > (original) > >> +++ cfe/trunk/test/Analysis/plugins/SampleAnalyzer/CMakeLists.txt Tue > May 21 17:47:37 2019 > >> @@ -1,11 +1,12 @@ > >> set(LLVM_EXPORTED_SYMBOL_FILE > ${CMAKE_CURRENT_SOURCE_DIR}/SampleAnalyzerPlugin.exports) > >> add_llvm_library(SampleAnalyzerPlugin MODULE MainCallChecker.cpp > PLUGIN_TOOL clang) > >> > >> -if(LLVM_ENABLE_PLUGINS AND (WIN32 OR CYGWIN)) > >> +if(LLVM_ENABLE_PLUGINS) > >> target_link_libraries(SampleAnalyzerPlugin PRIVATE > >>clangAnalysis > >>clangAST > >>clangStaticAnalyzerCore > >> +clangStaticAnalyzerFrontend > >>LLVMSupport > >>) > >> endif() > >> > >> > >> ___ > >> cfe-commits mailing list > >> cfe-commits@lists.llvm.org > >> https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits > > > > ___ > cfe-commits mailing list > cfe-commits@lists.llvm.org > https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits > ___ cf
Re: r361340 - [Analysis] Link library dependencies to Analysis plugins
I reverted the patch in r361685 to make the bot green again. > On May 23, 2019, at 5:22 PM, Akira Hatanaka wrote: > > Hi Petr, > > This seems to have caused Analysis/checker-plugins.c to fail. Can you > investigate it or revert your commit? > > http://green.lab.llvm.org/green/job/clang-stage2-cmake-RgSan/6381/consoleFull#-5275661368254eaf0-7326-4999-85b0-388101f2d404 > >> On May 21, 2019, at 5:47 PM, Petr Hosek via cfe-commits >> wrote: >> >> Author: phosek >> Date: Tue May 21 17:47:37 2019 >> New Revision: 361340 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=361340&view=rev >> Log: >> [Analysis] Link library dependencies to Analysis plugins >> >> These are needed to avoid undefined symbols which aren't satisfied >> by Clang itself. >> >> Differential Revision: https://reviews.llvm.org/D62174 >> >> Modified: >> cfe/trunk/test/Analysis/plugins/CheckerDependencyHandling/CMakeLists.txt >> cfe/trunk/test/Analysis/plugins/CheckerOptionHandling/CMakeLists.txt >> cfe/trunk/test/Analysis/plugins/SampleAnalyzer/CMakeLists.txt >> >> Modified: >> cfe/trunk/test/Analysis/plugins/CheckerDependencyHandling/CMakeLists.txt >> URL: >> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Analysis/plugins/CheckerDependencyHandling/CMakeLists.txt?rev=361340&r1=361339&r2=361340&view=diff >> == >> --- cfe/trunk/test/Analysis/plugins/CheckerDependencyHandling/CMakeLists.txt >> (original) >> +++ cfe/trunk/test/Analysis/plugins/CheckerDependencyHandling/CMakeLists.txt >> Tue May 21 17:47:37 2019 >> @@ -1,11 +1,12 @@ >> set(LLVM_EXPORTED_SYMBOL_FILE >> ${CMAKE_CURRENT_SOURCE_DIR}/CheckerDependencyHandlingAnalyzerPlugin.exports) >> add_llvm_library(CheckerDependencyHandlingAnalyzerPlugin MODULE >> CheckerDependencyHandling.cpp PLUGIN_TOOL clang) >> >> -if(LLVM_ENABLE_PLUGINS AND (WIN32 OR CYGWIN)) >> +if(LLVM_ENABLE_PLUGINS) >> target_link_libraries(CheckerDependencyHandlingAnalyzerPlugin PRIVATE >>clangAnalysis >>clangAST >>clangStaticAnalyzerCore >> +clangStaticAnalyzerFrontend >>LLVMSupport >>) >> endif() >> >> Modified: >> cfe/trunk/test/Analysis/plugins/CheckerOptionHandling/CMakeLists.txt >> URL: >> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Analysis/plugins/CheckerOptionHandling/CMakeLists.txt?rev=361340&r1=361339&r2=361340&view=diff >> == >> --- cfe/trunk/test/Analysis/plugins/CheckerOptionHandling/CMakeLists.txt >> (original) >> +++ cfe/trunk/test/Analysis/plugins/CheckerOptionHandling/CMakeLists.txt Tue >> May 21 17:47:37 2019 >> @@ -1,11 +1,12 @@ >> set(LLVM_EXPORTED_SYMBOL_FILE >> ${CMAKE_CURRENT_SOURCE_DIR}/CheckerOptionHandlingAnalyzerPlugin.exports) >> add_llvm_library(CheckerOptionHandlingAnalyzerPlugin MODULE >> CheckerOptionHandling.cpp PLUGIN_TOOL clang) >> >> -if(LLVM_ENABLE_PLUGINS AND (WIN32 OR CYGWIN)) >> +if(LLVM_ENABLE_PLUGINS) >> target_link_libraries(CheckerOptionHandlingAnalyzerPlugin PRIVATE >>clangAnalysis >>clangAST >>clangStaticAnalyzerCore >> +clangStaticAnalyzerFrontend >>LLVMSupport >>) >> endif() >> >> Modified: cfe/trunk/test/Analysis/plugins/SampleAnalyzer/CMakeLists.txt >> URL: >> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Analysis/plugins/SampleAnalyzer/CMakeLists.txt?rev=361340&r1=361339&r2=361340&view=diff >> == >> --- cfe/trunk/test/Analysis/plugins/SampleAnalyzer/CMakeLists.txt (original) >> +++ cfe/trunk/test/Analysis/plugins/SampleAnalyzer/CMakeLists.txt Tue May 21 >> 17:47:37 2019 >> @@ -1,11 +1,12 @@ >> set(LLVM_EXPORTED_SYMBOL_FILE >> ${CMAKE_CURRENT_SOURCE_DIR}/SampleAnalyzerPlugin.exports) >> add_llvm_library(SampleAnalyzerPlugin MODULE MainCallChecker.cpp PLUGIN_TOOL >> clang) >> >> -if(LLVM_ENABLE_PLUGINS AND (WIN32 OR CYGWIN)) >> +if(LLVM_ENABLE_PLUGINS) >> target_link_libraries(SampleAnalyzerPlugin PRIVATE >>clangAnalysis >>clangAST >>clangStaticAnalyzerCore >> +clangStaticAnalyzerFrontend >>LLVMSupport >>) >> endif() >> >> >> ___ >> cfe-commits mailing list >> cfe-commits@lists.llvm.org >> https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits > ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: r361340 - [Analysis] Link library dependencies to Analysis plugins
Hi Petr, This seems to have caused Analysis/checker-plugins.c to fail. Can you investigate it or revert your commit? http://green.lab.llvm.org/green/job/clang-stage2-cmake-RgSan/6381/consoleFull#-5275661368254eaf0-7326-4999-85b0-388101f2d404 > On May 21, 2019, at 5:47 PM, Petr Hosek via cfe-commits > wrote: > > Author: phosek > Date: Tue May 21 17:47:37 2019 > New Revision: 361340 > > URL: http://llvm.org/viewvc/llvm-project?rev=361340&view=rev > Log: > [Analysis] Link library dependencies to Analysis plugins > > These are needed to avoid undefined symbols which aren't satisfied > by Clang itself. > > Differential Revision: https://reviews.llvm.org/D62174 > > Modified: >cfe/trunk/test/Analysis/plugins/CheckerDependencyHandling/CMakeLists.txt >cfe/trunk/test/Analysis/plugins/CheckerOptionHandling/CMakeLists.txt >cfe/trunk/test/Analysis/plugins/SampleAnalyzer/CMakeLists.txt > > Modified: > cfe/trunk/test/Analysis/plugins/CheckerDependencyHandling/CMakeLists.txt > URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Analysis/plugins/CheckerDependencyHandling/CMakeLists.txt?rev=361340&r1=361339&r2=361340&view=diff > == > --- cfe/trunk/test/Analysis/plugins/CheckerDependencyHandling/CMakeLists.txt > (original) > +++ cfe/trunk/test/Analysis/plugins/CheckerDependencyHandling/CMakeLists.txt > Tue May 21 17:47:37 2019 > @@ -1,11 +1,12 @@ > set(LLVM_EXPORTED_SYMBOL_FILE > ${CMAKE_CURRENT_SOURCE_DIR}/CheckerDependencyHandlingAnalyzerPlugin.exports) > add_llvm_library(CheckerDependencyHandlingAnalyzerPlugin MODULE > CheckerDependencyHandling.cpp PLUGIN_TOOL clang) > > -if(LLVM_ENABLE_PLUGINS AND (WIN32 OR CYGWIN)) > +if(LLVM_ENABLE_PLUGINS) > target_link_libraries(CheckerDependencyHandlingAnalyzerPlugin PRIVATE > clangAnalysis > clangAST > clangStaticAnalyzerCore > +clangStaticAnalyzerFrontend > LLVMSupport > ) > endif() > > Modified: cfe/trunk/test/Analysis/plugins/CheckerOptionHandling/CMakeLists.txt > URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Analysis/plugins/CheckerOptionHandling/CMakeLists.txt?rev=361340&r1=361339&r2=361340&view=diff > == > --- cfe/trunk/test/Analysis/plugins/CheckerOptionHandling/CMakeLists.txt > (original) > +++ cfe/trunk/test/Analysis/plugins/CheckerOptionHandling/CMakeLists.txt Tue > May 21 17:47:37 2019 > @@ -1,11 +1,12 @@ > set(LLVM_EXPORTED_SYMBOL_FILE > ${CMAKE_CURRENT_SOURCE_DIR}/CheckerOptionHandlingAnalyzerPlugin.exports) > add_llvm_library(CheckerOptionHandlingAnalyzerPlugin MODULE > CheckerOptionHandling.cpp PLUGIN_TOOL clang) > > -if(LLVM_ENABLE_PLUGINS AND (WIN32 OR CYGWIN)) > +if(LLVM_ENABLE_PLUGINS) > target_link_libraries(CheckerOptionHandlingAnalyzerPlugin PRIVATE > clangAnalysis > clangAST > clangStaticAnalyzerCore > +clangStaticAnalyzerFrontend > LLVMSupport > ) > endif() > > Modified: cfe/trunk/test/Analysis/plugins/SampleAnalyzer/CMakeLists.txt > URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Analysis/plugins/SampleAnalyzer/CMakeLists.txt?rev=361340&r1=361339&r2=361340&view=diff > == > --- cfe/trunk/test/Analysis/plugins/SampleAnalyzer/CMakeLists.txt (original) > +++ cfe/trunk/test/Analysis/plugins/SampleAnalyzer/CMakeLists.txt Tue May 21 > 17:47:37 2019 > @@ -1,11 +1,12 @@ > set(LLVM_EXPORTED_SYMBOL_FILE > ${CMAKE_CURRENT_SOURCE_DIR}/SampleAnalyzerPlugin.exports) > add_llvm_library(SampleAnalyzerPlugin MODULE MainCallChecker.cpp PLUGIN_TOOL > clang) > > -if(LLVM_ENABLE_PLUGINS AND (WIN32 OR CYGWIN)) > +if(LLVM_ENABLE_PLUGINS) > target_link_libraries(SampleAnalyzerPlugin PRIVATE > clangAnalysis > clangAST > clangStaticAnalyzerCore > +clangStaticAnalyzerFrontend > LLVMSupport > ) > endif() > > > ___ > cfe-commits mailing list > cfe-commits@lists.llvm.org > https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
r361340 - [Analysis] Link library dependencies to Analysis plugins
Author: phosek Date: Tue May 21 17:47:37 2019 New Revision: 361340 URL: http://llvm.org/viewvc/llvm-project?rev=361340&view=rev Log: [Analysis] Link library dependencies to Analysis plugins These are needed to avoid undefined symbols which aren't satisfied by Clang itself. Differential Revision: https://reviews.llvm.org/D62174 Modified: cfe/trunk/test/Analysis/plugins/CheckerDependencyHandling/CMakeLists.txt cfe/trunk/test/Analysis/plugins/CheckerOptionHandling/CMakeLists.txt cfe/trunk/test/Analysis/plugins/SampleAnalyzer/CMakeLists.txt Modified: cfe/trunk/test/Analysis/plugins/CheckerDependencyHandling/CMakeLists.txt URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Analysis/plugins/CheckerDependencyHandling/CMakeLists.txt?rev=361340&r1=361339&r2=361340&view=diff == --- cfe/trunk/test/Analysis/plugins/CheckerDependencyHandling/CMakeLists.txt (original) +++ cfe/trunk/test/Analysis/plugins/CheckerDependencyHandling/CMakeLists.txt Tue May 21 17:47:37 2019 @@ -1,11 +1,12 @@ set(LLVM_EXPORTED_SYMBOL_FILE ${CMAKE_CURRENT_SOURCE_DIR}/CheckerDependencyHandlingAnalyzerPlugin.exports) add_llvm_library(CheckerDependencyHandlingAnalyzerPlugin MODULE CheckerDependencyHandling.cpp PLUGIN_TOOL clang) -if(LLVM_ENABLE_PLUGINS AND (WIN32 OR CYGWIN)) +if(LLVM_ENABLE_PLUGINS) target_link_libraries(CheckerDependencyHandlingAnalyzerPlugin PRIVATE clangAnalysis clangAST clangStaticAnalyzerCore +clangStaticAnalyzerFrontend LLVMSupport ) endif() Modified: cfe/trunk/test/Analysis/plugins/CheckerOptionHandling/CMakeLists.txt URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Analysis/plugins/CheckerOptionHandling/CMakeLists.txt?rev=361340&r1=361339&r2=361340&view=diff == --- cfe/trunk/test/Analysis/plugins/CheckerOptionHandling/CMakeLists.txt (original) +++ cfe/trunk/test/Analysis/plugins/CheckerOptionHandling/CMakeLists.txt Tue May 21 17:47:37 2019 @@ -1,11 +1,12 @@ set(LLVM_EXPORTED_SYMBOL_FILE ${CMAKE_CURRENT_SOURCE_DIR}/CheckerOptionHandlingAnalyzerPlugin.exports) add_llvm_library(CheckerOptionHandlingAnalyzerPlugin MODULE CheckerOptionHandling.cpp PLUGIN_TOOL clang) -if(LLVM_ENABLE_PLUGINS AND (WIN32 OR CYGWIN)) +if(LLVM_ENABLE_PLUGINS) target_link_libraries(CheckerOptionHandlingAnalyzerPlugin PRIVATE clangAnalysis clangAST clangStaticAnalyzerCore +clangStaticAnalyzerFrontend LLVMSupport ) endif() Modified: cfe/trunk/test/Analysis/plugins/SampleAnalyzer/CMakeLists.txt URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Analysis/plugins/SampleAnalyzer/CMakeLists.txt?rev=361340&r1=361339&r2=361340&view=diff == --- cfe/trunk/test/Analysis/plugins/SampleAnalyzer/CMakeLists.txt (original) +++ cfe/trunk/test/Analysis/plugins/SampleAnalyzer/CMakeLists.txt Tue May 21 17:47:37 2019 @@ -1,11 +1,12 @@ set(LLVM_EXPORTED_SYMBOL_FILE ${CMAKE_CURRENT_SOURCE_DIR}/SampleAnalyzerPlugin.exports) add_llvm_library(SampleAnalyzerPlugin MODULE MainCallChecker.cpp PLUGIN_TOOL clang) -if(LLVM_ENABLE_PLUGINS AND (WIN32 OR CYGWIN)) +if(LLVM_ENABLE_PLUGINS) target_link_libraries(SampleAnalyzerPlugin PRIVATE clangAnalysis clangAST clangStaticAnalyzerCore +clangStaticAnalyzerFrontend LLVMSupport ) endif() ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits